Skip to content

Scheduling infrastructure for absolutely everyone.

fix: encoding bug (#21004)

Udit Takkar0b59a5d1845d
diff --git a/packages/sms/attendee/awaiting-payment-sms.ts b/packages/sms/attendee/awaiting-payment-sms.ts
index 9513e7d7a86..99d5e755e19 100644
--- a/packages/sms/attendee/awaiting-payment-sms.ts
+++ b/packages/sms/attendee/awaiting-payment-sms.ts
@@ -14,12 +14,14 @@ export default class AwaitingPaymentSMS extends SMSManager {
const messageText = `${t("meeting_awaiting_payment")}: ${t("complete_your_booking_subject", {
title: this.calEvent.title,
date: this.getFormattedDate(attendee.timeZone, attendee.language.locale),
+ interpolation: { escapeValue: false },
})}`;
const bookingUrl = `${this.calEvent.bookerUrl ?? WEBAPP_URL}/booking/${this.calEvent.uid}?changes=true`;
const urlText = t("you_can_view_booking_details_with_this_url", {
url: bookingUrl,
+ interpolation: { escapeValue: false },
});
return `${messageText}\n\n${urlText}`;
diff --git a/packages/sms/attendee/cancelled-seat-sms.ts b/packages/sms/attendee/cancelled-seat-sms.ts
index 354505ebf84..79c5b6d49df 100644
--- a/packages/sms/attendee/cancelled-seat-sms.ts
+++ b/packages/sms/attendee/cancelled-seat-sms.ts
@@ -15,6 +15,7 @@ export default class CancelledSeatSMS extends SMSManager {
})}\n\n${t("event_no_longer_attending_subject", {
name: this.calEvent.team?.name || this.calEvent.organizer.name,
date: this.getFormattedDate(attendee.timeZone, attendee.language.locale),
+ interpolation: { escapeValue: false },
})} `;
return `${messageText}`;
diff --git a/packages/sms/attendee/event-cancelled-sms.ts b/packages/sms/attendee/event-cancelled-sms.ts
index 68b9d134e9f..c26c924c53d 100644
--- a/packages/sms/attendee/event-cancelled-sms.ts
+++ b/packages/sms/attendee/event-cancelled-sms.ts
@@ -17,11 +17,13 @@ export default class EventCancelledSMS extends SMSManager {
{
title: this.calEvent.title,
date: this.getFormattedDate(attendee.timeZone, attendee.language.locale),
+ interpolation: { escapeValue: false },
}
)}`;
const urlText = t("you_can_view_booking_details_with_this_url", {
url: bookingUrl,
+ interpolation: { escapeValue: false },
});
return `${messageText}\n\n${urlText}`;
diff --git a/packages/sms/attendee/event-declined-sms.ts b/packages/sms/attendee/event-declined-sms.ts
index db883305cf8..3d99fbdb5c0 100644
--- a/packages/sms/attendee/event-declined-sms.ts
+++ b/packages/sms/attendee/event-declined-sms.ts
@@ -13,6 +13,7 @@ export default class EventDeclinedSMS extends SMSManager {
const eventDeclinedText = t("event_declined_subject", {
title: this.calEvent.title,
date: this.getFormattedDate(attendee.timeZone, attendee.language.locale),
+ interpolation: { escapeValue: false },
});
const messageText = `${t("hey_there")} ${attendee.name}, ${t(
diff --git a/packages/sms/attendee/event-location-changed-sms.ts b/packages/sms/attendee/event-location-changed-sms.ts
index bed90322a95..fbcca8e177b 100644
--- a/packages/sms/attendee/event-location-changed-sms.ts
+++ b/packages/sms/attendee/event-location-changed-sms.ts
@@ -17,6 +17,7 @@ export default class EventLocationChangedSMS extends SMSManager {
const urlText = t("you_can_view_booking_details_with_this_url", {
url: bookingUrl,
+ interpolation: { escapeValue: false },
});
return `${messageText}\n\n${urlText}`;
diff --git a/packages/sms/attendee/event-request-sms.ts b/packages/sms/attendee/event-request-sms.ts
index 93d2c8c53e3..29b34d3b85f 100644
--- a/packages/sms/attendee/event-request-sms.ts
+++ b/packages/sms/attendee/event-request-sms.ts
@@ -13,15 +13,18 @@ export default class EventRequestSMS extends SMSManager {
const bookingSubmittedText = t("booking_submitted", {
name: attendee.name,
+ interpolation: { escapeValue: false },
});
const bookingUrl = `${this.calEvent.bookerUrl ?? WEBAPP_URL}/booking/${this.calEvent.uid}`;
const urlText = t("you_can_view_booking_details_with_this_url", {
url: bookingUrl,
+ interpolation: { escapeValue: false },
});
const userNeedsToConfirmOrRejectBookingText = t("user_needs_to_confirm_or_reject_booking", {
user: this.calEvent.organizer.name,
+ interpolation: { escapeValue: false },
});
const messageText = `${bookingSubmittedText}. ${userNeedsToConfirmOrRejectBookingText}\n\n${urlText}`;
diff --git a/packages/sms/attendee/event-request-to-reschedule-sms.ts b/packages/sms/attendee/event-request-to-reschedule-sms.ts
index 34c0e9abd9c..16dca7534a2 100644
--- a/packages/sms/attendee/event-request-to-reschedule-sms.ts
+++ b/packages/sms/attendee/event-request-to-reschedule-sms.ts
@@ -14,6 +14,7 @@ export default class EventRequestToRescheduleSMS extends SMSManager {
const requestRescheduleSubtitle = t("request_reschedule_subtitle", {
organizer: this.calEvent.organizer.name,
+ interpolation: { escapeValue: false },
});
const needToRescheduleOrCancelText = t("need_to_reschedule_or_cancel");
diff --git a/packages/sms/attendee/event-rescheduled-sms.ts b/packages/sms/attendee/event-rescheduled-sms.ts
index 9adaa7924e4..013dc571b4f 100644
--- a/packages/sms/attendee/event-rescheduled-sms.ts
+++ b/packages/sms/attendee/event-rescheduled-sms.ts
@@ -14,11 +14,13 @@ export default class EventSuccessfullyReScheduledSMS extends SMSManager {
const bookerUrl = `${this.calEvent.bookerUrl ?? WEBAPP_URL}/booking/${this.calEvent.uid}`;
const bookerUrlText = t("you_can_view_booking_details_with_this_url", {
url: bookerUrl,
+ interpolation: { escapeValue: false },
});
const eventTypeHasBeenRescheduledOnTimeDateText = t("event_type_has_been_rescheduled_on_time_date", {
title: this.calEvent.title,
date: this.getFormattedDate(attendee.timeZone, attendee.language.locale),
+ interpolation: { escapeValue: false },
});
const messageText = `${t("hey_there")} ${
diff --git a/packages/sms/attendee/event-scheduled-sms.ts b/packages/sms/attendee/event-scheduled-sms.ts
index 873e6ce5058..5ae0cd92d8e 100644
--- a/packages/sms/attendee/event-scheduled-sms.ts
+++ b/packages/sms/attendee/event-scheduled-sms.ts
@@ -14,12 +14,14 @@ export default class EventSuccessfullyScheduledSMS extends SMSManager {
const confirmationText = t("confirming_your_booking_sms", {
name: attendee.name,
date: this.getFormattedDate(attendee.timeZone, attendee.language.locale),
+ interpolation: { escapeValue: false },
});
const bookingUrl = `${this.calEvent.bookerUrl ?? WEBAPP_URL}/booking/${this.calEvent.uid}`;
const urlText = t("you_can_view_booking_details_with_this_url", {
url: bookingUrl,
+ interpolation: { escapeValue: false },
});
return `${confirmationText}\n\n${urlText}`;
diff --git a/packages/sms/sms-manager.ts b/packages/sms/sms-manager.ts
index 008e1c762cc..3ce4a74f436 100644
--- a/packages/sms/sms-manager.ts
+++ b/packages/sms/sms-manager.ts
@@ -37,8 +37,7 @@ const handleSendingSMS = ({
if (!team?.parent?.isOrganization) return;
await checkSMSRateLimit({ identifier: `handleSendingSMS:team:${teamId}`, rateLimitingType: "sms" });
- const sanitizedMessage = smsMessage.replace(///g, "/");
- const sms = twilio.sendSMS(reminderPhone, sanitizedMessage, senderID, teamId);
+ const sms = twilio.sendSMS(reminderPhone, smsMessage, senderID, teamId);
resolve(sms);
} catch (e) {
reject(console.error(`twilio.sendSMS failed`, e));