Skip to content

Scheduling infrastructure for absolutely everyone.

refactor: trpc test file is importing @calcom/web (#25979)

Benny Joo176aeaafd8a6
diff --git a/packages/trpc/eslint.config.mjs b/packages/trpc/eslint.config.mjs
index ec9b33eb001..81700c496c0 100644
--- a/packages/trpc/eslint.config.mjs
+++ b/packages/trpc/eslint.config.mjs
@@ -1,8 +1,14 @@
import { config } from "@calcom/eslint-config/base";
+import { forbid } from "@calcom/eslint-config/base";
export default [
...config,
{
ignores: ["./types/**"],
},
+ forbid({
+ from: "../apps/web/**",
+ target: ".",
+ message: "trpc package should not import from apps/web to avoid circular dependencies.",
+ }),
];
diff --git a/packages/trpc/server/routers/viewer/calendars/setDestinationCalendar.handler.test.ts b/packages/trpc/server/routers/viewer/calendars/setDestinationCalendar.handler.test.ts
index 96905b8d320..ffd0ef3df8d 100644
--- a/packages/trpc/server/routers/viewer/calendars/setDestinationCalendar.handler.test.ts
+++ b/packages/trpc/server/routers/viewer/calendars/setDestinationCalendar.handler.test.ts
@@ -1,155 +1,166 @@
-import prisma from "../../../../../../tests/libs/__mocks__/prisma";
-
-import {
- createBookingScenario,
- TestData,
- getOrganizer,
- getScenarioData,
- createOrganization,
- createDelegationCredential,
-} from "@calcom/web/test/utils/bookingScenario/bookingScenario";
-import { setupAndTeardown } from "@calcom/web/test/utils/bookingScenario/setupAndTeardown";
-
-import { describe, it, vi, expect } from "vitest";
+import { describe, it, vi, expect, beforeEach, afterEach } from "vitest";
+import { getUsersCredentialsIncludeServiceAccountKey } from "@calcom/app-store/delegationCredential";
import { getConnectedCalendars } from "@calcom/features/calendars/lib/CalendarManager";
-import { SchedulingType, MembershipRole } from "@calcom/prisma/enums";
+import { DestinationCalendarRepository } from "@calcom/features/calendars/repositories/DestinationCalendarRepository";
import { TRPCError } from "@trpc/server";
-import type { TrpcSessionUser } from "../../../types";
import { setDestinationCalendarHandler } from "./setDestinationCalendar.handler";
+type MockUser = {
+ id: number;
+ email: string;
+ userLevelSelectedCalendars: Array<{
+ integration: string;
+ externalId: string;
+ credentialId: number | null;
+ delegationCredentialId?: number | null;
+ }>;
+};
+
vi.mock("@calcom/features/calendars/lib/CalendarManager", () => ({
getConnectedCalendars: vi.fn(),
getCalendarCredentials: vi.fn().mockImplementation((creds) => creds),
}));
-describe("setDestinationCalendarHandler", () => {
- setupAndTeardown();
+vi.mock("@calcom/app-store/delegationCredential", () => ({
+ getUsersCredentialsIncludeServiceAccountKey: vi.fn(),
+}));
- it("should successfully set destination calendar with DelegationCredential credentials", async () => {
- const org = await createOrganization({
- name: "Test Org",
- slug: "testorg",
- });
+vi.mock("@calcom/features/calendars/repositories/DestinationCalendarRepository", () => ({
+ DestinationCalendarRepository: {
+ upsert: vi.fn(),
+ },
+}));
- const childTeam = {
- id: 202,
- name: "Team 1",
- slug: "team-1",
- parentId: org.id,
- };
+// Mock data helpers
+function createMockUser({
+ id,
+ email,
+ userLevelSelectedCalendars = [],
+}: {
+ id: number;
+ email: string;
+ userLevelSelectedCalendars?: Array<{
+ integration: string;
+ externalId: string;
+ credentialId: number | null;
+ delegationCredentialId?: number | null;
+ }>;
+}): MockUser {
+ return {
+ id,
+ email,
+ userLevelSelectedCalendars,
+ };
+}
+
+function createMockCredential({
+ id,
+ delegationCredentialId,
+}: {
+ id: number;
+ delegationCredentialId?: number;
+}) {
+ return {
+ id,
+ delegationCredentialId,
+ type: "google_calendar",
+ key: {},
+ };
+}
+
+function createMockConnectedCalendars({
+ calendars,
+}: {
+ calendars: Array<{
+ externalId: string;
+ integration: string;
+ readOnly: boolean;
+ primary?: boolean | null;
+ email: string;
+ credentialId?: number | null;
+ delegationCredentialId?: number | null;
+ }>;
+}) {
+ return {
+ connectedCalendars: [
+ {
+ calendars,
+ },
+ ],
+ };
+}
- const organizer = getOrganizer({
- name: "Organizer",
- email: "[email protected]",
- id: 101,
- schedules: [TestData.schedules.IstWorkHours],
- teams: [
- {
- membership: {
- accepted: true,
- role: MembershipRole.ADMIN,
- },
- team: {
- id: org.id,
- name: "Test Org",
- slug: "testorg",
- },
- },
- {
- membership: {
- accepted: true,
- role: MembershipRole.ADMIN,
- },
- team: {
- id: childTeam.id,
- name: "Team 1",
- slug: "team-1",
- parentId: org.id,
- },
- },
- ],
- });
+describe("setDestinationCalendarHandler", () => {
+ beforeEach(() => {
+ vi.clearAllMocks();
+ });
- const delegationCredential = await createDelegationCredential(org.id);
+ afterEach(() => {
+ vi.resetAllMocks();
+ });
- const delegationCredentialId = delegationCredential.id;
+ it("should successfully set destination calendar with DelegationCredential credentials", async () => {
+ const delegationCredentialId = 123;
const testExternalId = "[email protected]";
-
- // Mock the getConnectedCalendars response
- (getConnectedCalendars as jest.Mock).mockResolvedValue({
- connectedCalendars: [
+ const organizerEmail = "[email protected]";
+ const organizerId = 101;
+
+ // Create mock user
+ const mockUser = createMockUser({
+ id: organizerId,
+ email: organizerEmail,
+ userLevelSelectedCalendars: [
{
- calendars: [
- {
- externalId: organizer.email,
- integration: "google_calendar",
- readOnly: false,
- primary: true,
- email: organizer.email,
- credentialId: -1,
- delegationCredentialId: delegationCredentialId,
- },
- {
- externalId: testExternalId,
- integration: "google_calendar",
- readOnly: false,
- primary: null,
- email: organizer.email,
- credentialId: -1,
- delegationCredentialId: delegationCredentialId,
- },
- ],
+ integration: "google_calendar",
+ externalId: testExternalId,
+ credentialId: null,
+ delegationCredentialId: delegationCredentialId,
},
],
});
- await createBookingScenario(
- getScenarioData(
+ // Mock credentials
+ const mockCredentials = [
+ createMockCredential({
+ id: -1,
+ delegationCredentialId,
+ }),
+ ];
+
+ // Mock connected calendars response
+ const mockConnectedCalendars = createMockConnectedCalendars({
+ calendars: [
{
- organizer,
- eventTypes: [
- {
- id: 1,
- teamId: childTeam.id,
- schedulingType: SchedulingType.ROUND_ROBIN,
- length: 30,
- hosts: [
- {
- userId: 101,
- isFixed: false,
- },
- ],
- },
- ],
- selectedCalendars: [
- {
- integration: "google_calendar",
- externalId: testExternalId,
- credentialId: null,
- delegationCredentialId: delegationCredentialId,
- },
- ],
+ externalId: organizerEmail,
+ integration: "google_calendar",
+ readOnly: false,
+ primary: true,
+ email: organizerEmail,
+ credentialId: -1,
+ delegationCredentialId: delegationCredentialId,
},
- org
- )
- );
+ {
+ externalId: testExternalId,
+ integration: "google_calendar",
+ readOnly: false,
+ primary: null,
+ email: organizerEmail,
+ credentialId: -1,
+ delegationCredentialId: delegationCredentialId,
+ },
+ ],
+ });
+
+ // Setup mocks
+ vi.mocked(getUsersCredentialsIncludeServiceAccountKey).mockResolvedValue(mockCredentials);
+ vi.mocked(getConnectedCalendars).mockResolvedValue(mockConnectedCalendars);
+ vi.mocked(DestinationCalendarRepository.upsert).mockResolvedValue({});
const ctx = {
- user: {
- id: organizer.id,
- email: organizer.email,
- selectedCalendars: [
- {
- integration: "google_calendar",
- externalId: testExternalId,
- credentialId: null,
- delegationCredentialId: delegationCredentialId,
- },
- ],
- } as NonNullable<TrpcSessionUser>,
+ user: mockUser,
};
await setDestinationCalendarHandler({
@@ -160,36 +171,44 @@ describe("setDestinationCalendarHandler", () => {
},
});
- // Verify the destination calendar was set correctly
- const destinationCalendar = await prisma.destinationCalendar.findFirst({
- where: {
- userId: organizer.id,
+ // Verify the destination calendar repository was called correctly
+ expect(DestinationCalendarRepository.upsert).toHaveBeenCalledWith({
+ where: { userId: organizerId },
+ update: {
+ integration: "google_calendar",
+ externalId: testExternalId,
+ primaryEmail: organizerEmail,
+ credentialId: -1,
+ delegationCredentialId: delegationCredentialId,
},
- });
-
- expect(destinationCalendar).toEqual(
- expect.objectContaining({
+ create: {
+ userId: organizerId,
integration: "google_calendar",
externalId: testExternalId,
- credentialId: null,
+ primaryEmail: organizerEmail,
+ credentialId: -1,
delegationCredentialId: delegationCredentialId,
- })
- );
+ },
+ });
});
it("should throw error when calendar is not found", async () => {
- const organizer = getOrganizer({
- name: "Organizer",
- email: "[email protected]",
- id: 101,
+ const organizerEmail = "[email protected]";
+ const organizerId = 101;
+
+ // Create mock user
+ const mockUser = createMockUser({
+ id: organizerId,
+ email: organizerEmail,
+ userLevelSelectedCalendars: [],
});
+ // Mock empty credentials and calendars
+ vi.mocked(getUsersCredentialsIncludeServiceAccountKey).mockResolvedValue([]);
+ vi.mocked(getConnectedCalendars).mockResolvedValue({ connectedCalendars: [] });
+
const ctx = {
- user: {
- id: organizer.id,
- email: organizer.email,
- selectedCalendars: [],
- } as NonNullable<TrpcSessionUser>,
+ user: mockUser,
};
await expect(
@@ -198,7 +217,6 @@ describe("setDestinationCalendarHandler", () => {
input: {
integration: "google_calendar",
externalId: "non-existent-calendar",
- eventTypeId: null,
},
})
).rejects.toThrow(