Skip to content

Scheduling infrastructure for absolutely everyone.

fix: 500 error on missing response id. Should be 400 (#20420)

Hariom Balhara17f493a4889f
diff --git a/packages/features/bookings/lib/handleNewBooking.ts b/packages/features/bookings/lib/handleNewBooking.ts
index 180ff3095d7..1eb57953b93 100644
--- a/packages/features/bookings/lib/handleNewBooking.ts
+++ b/packages/features/bookings/lib/handleNewBooking.ts
@@ -456,6 +456,10 @@ async function handler(
let routingFormResponse = null;
if (routedTeamMemberIds) {
+ //routingFormResponseId could be 0 for dry run. So, we just avoid undefined value
+ if (routingFormResponseId === undefined) {
+ throw new HttpError({ statusCode: 400, message: "Missing routingFormResponseId" });
+ }
routingFormResponse = await prisma.app_RoutingForms_FormResponse.findUnique({
where: {
id: routingFormResponseId,
diff --git a/packages/features/bookings/lib/handleNewBooking/test/reschedule.test.ts b/packages/features/bookings/lib/handleNewBooking/test/reschedule.test.ts
index 4bd5892e51c..3df591bc870 100644
--- a/packages/features/bookings/lib/handleNewBooking/test/reschedule.test.ts
+++ b/packages/features/bookings/lib/handleNewBooking/test/reschedule.test.ts
@@ -2638,6 +2638,7 @@ describe("handleNewBooking", () => {
start: `${plus1DateString}T04:00:00.000Z`,
end: `${plus1DateString}T04:15:00.000Z`,
routedTeamMemberIds: [101],
+ routingFormResponseId: 12323,
responses: {
email: booker.email,
name: booker.name,