Scheduling infrastructure for absolutely everyone.
feat: add toggle to opt out of booking title translation in instant meetings (#25547)
Joe Au-Yeung3a59cd41cc80
diff --git a/apps/web/public/static/locales/en/common.json b/apps/web/public/static/locales/en/common.jsonindex 3fb28a58406..d89bd841509 100644--- a/apps/web/public/static/locales/en/common.json+++ b/apps/web/public/static/locales/en/common.json@@ -3261,7 +3261,11 @@"filter_operator_is_empty": "Is empty","filter_operator_not_empty": "Not empty","translate_description_button": "Auto translate title and description",- "translate_description_button_description": "Automatically translate titles and descriptions to the visitor’s browser language using AI.",+ "translate_description_button_description": "Automatically translate titles and descriptions to the visitor's browser language using AI.",+ "auto_translate_booking_title": "Auto translate booking title",+ "auto_translate_booking_title_description": "Automatically translate the booking title to the visitor's browser language. Disable this to keep the original title.",+ "auto_translate_instant_meeting_title": "Auto translate instant meeting title",+ "auto_translate_instant_meeting_title_description": "Automatically translate the instant meeting booking title to the visitor's browser language. Disable this to keep the original English title.","rr_distribution_method": "Distribution","rr_distribution_method_description": "Allows for optimising distribution for maximum availability or to aim for a more balanced assignment.","rr_distribution_method_availability_title": "Maximize availability",diff --git a/apps/web/test/lib/handleChildrenEventTypes.test.ts b/apps/web/test/lib/handleChildrenEventTypes.test.tsindex 30be95e0d3c..57f596d3fa7 100644--- a/apps/web/test/lib/handleChildrenEventTypes.test.ts+++ b/apps/web/test/lib/handleChildrenEventTypes.test.ts@@ -136,6 +136,7 @@ describe("handleChildrenEventTypes", () => {useEventTypeDestinationCalendarEmail,secondaryEmailId,autoTranslateDescriptionEnabled,+ autoTranslateInstantMeetingTitleEnabled,includeNoShowInRRCalculation,instantMeetingScheduleId,...evType@@ -161,6 +162,7 @@ describe("handleChildrenEventTypes", () => {useEventTypeDestinationCalendarEmail,secondaryEmailId,autoTranslateDescriptionEnabled,+ autoTranslateInstantMeetingTitleEnabled,includeNoShowInRRCalculation,instantMeetingScheduleId,};@@ -223,6 +225,7 @@ describe("handleChildrenEventTypes", () => {useEventTypeDestinationCalendarEmail,secondaryEmailId,assignRRMembersUsingSegment,+ autoTranslateInstantMeetingTitleEnabled,includeNoShowInRRCalculation,instantMeetingScheduleId,...evType@@ -332,6 +335,7 @@ describe("handleChildrenEventTypes", () => {useEventTypeDestinationCalendarEmail,secondaryEmailId,autoTranslateDescriptionEnabled,+ autoTranslateInstantMeetingTitleEnabled,includeNoShowInRRCalculation,instantMeetingScheduleId,assignRRMembersUsingSegment,@@ -358,6 +362,7 @@ describe("handleChildrenEventTypes", () => {useEventTypeDestinationCalendarEmail,secondaryEmailId,autoTranslateDescriptionEnabled,+ autoTranslateInstantMeetingTitleEnabled,includeNoShowInRRCalculation,instantMeetingScheduleId,assignRRMembersUsingSegment,@@ -420,6 +425,7 @@ describe("handleChildrenEventTypes", () => {lockTimeZoneToggleOnBookingPage,useEventTypeDestinationCalendarEmail,secondaryEmailId,+ autoTranslateInstantMeetingTitleEnabled,includeNoShowInRRCalculation,instantMeetingScheduleId,assignRRMembersUsingSegment,@@ -487,6 +493,7 @@ describe("handleChildrenEventTypes", () => {useEventTypeDestinationCalendarEmail,secondaryEmailId,autoTranslateDescriptionEnabled,+ autoTranslateInstantMeetingTitleEnabled,includeNoShowInRRCalculation,instantMeetingScheduleId,assignRRMembersUsingSegment,@@ -520,6 +527,7 @@ describe("handleChildrenEventTypes", () => {useEventTypeDestinationCalendarEmail,secondaryEmailId,autoTranslateDescriptionEnabled,+ autoTranslateInstantMeetingTitleEnabled,includeNoShowInRRCalculation,instantMeetingScheduleId,assignRRMembersUsingSegment,@@ -533,6 +541,7 @@ describe("handleChildrenEventTypes", () => {timeZone: "UTC",teamId: 1,autoTranslateDescriptionEnabled: false,+ autoTranslateInstantMeetingTitleEnabled: true,secondaryEmailId: null,schedulingType: SchedulingType.MANAGED,requiresBookerEmailVerification: false,diff --git a/packages/features/bookings/lib/handleNewBooking/getEventTypesFromDB.ts b/packages/features/bookings/lib/handleNewBooking/getEventTypesFromDB.tsindex b7646ce77f2..f0f07a8c410 100644--- a/packages/features/bookings/lib/handleNewBooking/getEventTypesFromDB.ts+++ b/packages/features/bookings/lib/handleNewBooking/getEventTypesFromDB.ts@@ -181,6 +181,8 @@ const getEventTypesFromDBSelect = {name: true,},},+ instantMeetingExpiryTimeOffsetInSeconds: true,+ autoTranslateInstantMeetingTitleEnabled: true,} satisfies Prisma.EventTypeSelect;export const getEventTypesFromDB = async (eventTypeId: number) => {diff --git a/packages/features/bookings/lib/service/InstantBookingCreateService.ts b/packages/features/bookings/lib/service/InstantBookingCreateService.tsindex b6a5260ccd4..e6bda9c41d8 100644--- a/packages/features/bookings/lib/service/InstantBookingCreateService.ts+++ b/packages/features/bookings/lib/service/InstantBookingCreateService.ts@@ -197,9 +197,19 @@ export async function handler(const attendeeTimezone = reqBody.timeZone;const attendeeLanguage = reqBody.language;const tAttendees = await getTranslation(attendeeLanguage ?? "en", "common");+ const tEnglish = await getTranslation("en", "common");const fullName = getFullName(bookerName);+ // Determine whether to auto-translate the instant meeting title based on the event type setting+ // Default is true (opt-out), so we only skip translation when explicitly set to false+ const shouldAutoTranslateInstantMeetingTitle = eventType.autoTranslateInstantMeetingTitleEnabled;++ // Get the booking title - either translated to attendee's language or in English+ const bookingTitle = shouldAutoTranslateInstantMeetingTitle+ ? tAttendees("instant_meeting_with_title", { name: fullName })+ : tEnglish("instant_meeting_with_title", { name: fullName });+const invitee = [{email: bookerEmail,@@ -242,7 +252,7 @@ export async function handler(const newBookingData: Prisma.BookingCreateInput = {uid,responses: reqBody.responses === null ? Prisma.JsonNull : reqBody.responses,- title: tAttendees("instant_meeting_with_title", { name: invitee[0].name }),+ title: bookingTitle,startTime: dayjs.utc(reqBody.start).toDate(),endTime: dayjs.utc(reqBody.end).toDate(),description: reqBody.notes,@@ -279,17 +289,7 @@ export async function handler(const token = randomBytes(32).toString("hex");- const eventTypeWithExpiryTimeOffset = await prisma.eventType.findUniqueOrThrow({- where: {- id: bookingData.eventTypeId,- },- select: {- instantMeetingExpiryTimeOffsetInSeconds: true,- },- });-- const instantMeetingExpiryTimeOffsetInSeconds =- eventTypeWithExpiryTimeOffset?.instantMeetingExpiryTimeOffsetInSeconds ?? 90;+ const instantMeetingExpiryTimeOffsetInSeconds = eventType.instantMeetingExpiryTimeOffsetInSeconds ?? 90;const instantMeetingToken = await prisma.instantMeetingToken.create({data: {diff --git a/packages/features/eventtypes/components/tabs/instant/InstantEventController.tsx b/packages/features/eventtypes/components/tabs/instant/InstantEventController.tsxindex 4d6674e4417..a7074a32efb 100644--- a/packages/features/eventtypes/components/tabs/instant/InstantEventController.tsx+++ b/packages/features/eventtypes/components/tabs/instant/InstantEventController.tsx@@ -245,6 +245,21 @@ export default function InstantEventController({</>)}/>+ <Controller+ name="autoTranslateInstantMeetingTitleEnabled"+ render={({ field: { value, onChange } }) => (+ <SettingsToggle+ labelClassName="text-sm"+ title={t("auto_translate_instant_meeting_title")}+ checked={value}+ onCheckedChange={(e) => onChange(e)}+ data-testid="auto-translate-instant-meeting-title-toggle"+ toggleSwitchAtTheEnd={true}+ switchContainerClassName="border-subtle rounded-lg border py-6 px-4 sm:px-6 mt-4"+ description={t("auto_translate_instant_meeting_title_description")}+ />+ )}+ /><InstantMeetingWebhooks eventType={eventType} /></div>)}diff --git a/packages/features/eventtypes/lib/defaultEvents.ts b/packages/features/eventtypes/lib/defaultEvents.tsindex 658c04e6e4e..6be10c54e00 100644--- a/packages/features/eventtypes/lib/defaultEvents.ts+++ b/packages/features/eventtypes/lib/defaultEvents.ts@@ -145,6 +145,7 @@ const commons = {requiresConfirmationWillBlockSlot: false,canSendCalVideoTranscriptionEmails: false,instantMeetingExpiryTimeOffsetInSeconds: 0,+ autoTranslateInstantMeetingTitleEnabled: true,instantMeetingScheduleId: null,instantMeetingParameters: [],eventTypeColor: null,diff --git a/packages/features/eventtypes/lib/types.ts b/packages/features/eventtypes/lib/types.tsindex b614d3e7150..f2862365177 100644--- a/packages/features/eventtypes/lib/types.ts+++ b/packages/features/eventtypes/lib/types.ts@@ -135,6 +135,7 @@ export type FormValues = {seatsShowAvailabilityCount: boolean | null;seatsPerTimeSlotEnabled: boolean;autoTranslateDescriptionEnabled: boolean;+ autoTranslateInstantMeetingTitleEnabled: boolean;fieldTranslations: EventTypeTranslation[];scheduleName: string;minimumBookingNotice: number;diff --git a/packages/features/eventtypes/repositories/eventTypeRepository.ts b/packages/features/eventtypes/repositories/eventTypeRepository.tsindex 983522cce47..d87ed8a0dc3 100644--- a/packages/features/eventtypes/repositories/eventTypeRepository.ts+++ b/packages/features/eventtypes/repositories/eventTypeRepository.ts@@ -570,6 +570,7 @@ export class EventTypeRepository {requiresConfirmationWillBlockSlot: true,requiresBookerEmailVerification: true,autoTranslateDescriptionEnabled: true,+ autoTranslateInstantMeetingTitleEnabled: true,fieldTranslations: {select: {translatedText: true,@@ -868,6 +869,7 @@ export class EventTypeRepository {requiresConfirmationWillBlockSlot: true,requiresBookerEmailVerification: true,autoTranslateDescriptionEnabled: true,+ autoTranslateInstantMeetingTitleEnabled: true,fieldTranslations: {select: {translatedText: true,diff --git a/packages/lib/test/builder.ts b/packages/lib/test/builder.tsindex 119dff6bdb9..80943881182 100644--- a/packages/lib/test/builder.ts+++ b/packages/lib/test/builder.ts@@ -155,6 +155,7 @@ export const buildEventType = (eventType?: Partial<EventType>): EventType => {assignRRMembersUsingSegment: false,rrSegmentQueryValue: null,autoTranslateDescriptionEnabled: false,+ autoTranslateInstantMeetingTitleEnabled: true,useEventLevelSelectedCalendars: false,allowReschedulingPastBookings: false,hideOrganizerEmail: false,diff --git a/packages/platform/atoms/event-types/hooks/useEventTypeForm.ts b/packages/platform/atoms/event-types/hooks/useEventTypeForm.tsindex 467e581e006..e68a08cca94 100644--- a/packages/platform/atoms/event-types/hooks/useEventTypeForm.ts+++ b/packages/platform/atoms/event-types/hooks/useEventTypeForm.ts@@ -118,6 +118,7 @@ export const useEventTypeForm = ({})),seatsPerTimeSlotEnabled: eventType.seatsPerTimeSlot,autoTranslateDescriptionEnabled: eventType.autoTranslateDescriptionEnabled,+ autoTranslateInstantMeetingTitleEnabled: eventType.autoTranslateInstantMeetingTitleEnabled ?? true,rescheduleWithSameRoundRobinHost: eventType.rescheduleWithSameRoundRobinHost,assignAllTeamMembers: eventType.assignAllTeamMembers,assignRRMembersUsingSegment: eventType.assignRRMembersUsingSegment,diff --git a/packages/prisma/migrations/20251202143411_add_auto_translate_title_enabled/migration.sql b/packages/prisma/migrations/20251202143411_add_auto_translate_title_enabled/migration.sqlnew file mode 100644index 00000000000..273175dbde6--- /dev/null+++ b/packages/prisma/migrations/20251202143411_add_auto_translate_title_enabled/migration.sql@@ -0,0 +1,2 @@+-- AlterTable+ALTER TABLE "public"."EventType" ADD COLUMN "autoTranslateInstantMeetingTitleEnabled" BOOLEAN NOT NULL DEFAULT true;diff --git a/packages/prisma/schema.prisma b/packages/prisma/schema.prismaindex 12aa23f0216..dfa785bf36e 100644--- a/packages/prisma/schema.prisma+++ b/packages/prisma/schema.prisma@@ -182,6 +182,7 @@ model EventType {canSendCalVideoTranscriptionEmails Boolean @default(true)autoTranslateDescriptionEnabled Boolean @default(false)+ autoTranslateInstantMeetingTitleEnabled Boolean @default(true)/// @zod.import(["import { recurringEventType } from '../../zod-utils'"]).custom.use(recurringEventType)recurringEvent Json?disableGuests Boolean @default(false)diff --git a/packages/trpc/server/routers/viewer/eventTypes/heavy/update.handler.ts b/packages/trpc/server/routers/viewer/eventTypes/heavy/update.handler.tsindex 7e926f9b6e8..3f8d24a2a61 100644--- a/packages/trpc/server/routers/viewer/eventTypes/heavy/update.handler.ts+++ b/packages/trpc/server/routers/viewer/eventTypes/heavy/update.handler.ts@@ -93,6 +93,7 @@ export const updateHandler = async ({ ctx, input }: UpdateOptions) => {aiPhoneCallConfig,isRRWeightsEnabled,autoTranslateDescriptionEnabled,+ autoTranslateInstantMeetingTitleEnabled,description: newDescription,title: newTitle,seatsPerTimeSlot,@@ -231,7 +232,8 @@ export const updateHandler = async ({ ctx, input }: UpdateOptions) => {const data: Prisma.EventTypeUpdateInput = {...rest,- // autoTranslate feature is allowed for org users only+ // Only update autoTranslateInstantMeetingTitleEnabled when explicitly provided to avoid overwriting saved opt-out+ ...(autoTranslateInstantMeetingTitleEnabled !== undefined && { autoTranslateInstantMeetingTitleEnabled }),// Only set if explicitly provided to avoid overwriting existing value with false...(autoTranslateDescriptionEnabled !== undefined && {autoTranslateDescriptionEnabled: Boolean(ctx.user.organizationId && autoTranslateDescriptionEnabled),diff --git a/packages/trpc/server/routers/viewer/teams/inviteMember/inviteMember.handler.integration-test.ts b/packages/trpc/server/routers/viewer/teams/inviteMember/inviteMember.handler.integration-test.tsindex eb0c59588d1..ca4ede014fe 100644--- a/packages/trpc/server/routers/viewer/teams/inviteMember/inviteMember.handler.integration-test.ts+++ b/packages/trpc/server/routers/viewer/teams/inviteMember/inviteMember.handler.integration-test.ts@@ -1,10 +1,9 @@import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";import { prisma } from "@calcom/prisma";-import type { Team, User, Membership, Profile } from "@calcom/prisma/client";+import type { Prisma, Team, User, Membership, Profile } from "@calcom/prisma/client";import { MembershipRole } from "@calcom/prisma/enums";import type { TrpcSessionUser } from "@calcom/trpc/server/types";-import type { JsonValue } from "@calcom/types/Json";import inviteMemberHandler, { inviteMembersWithNoInviterPermissionCheck } from "./inviteMember.handler";@@ -66,7 +65,7 @@ async function createTestTeam(data: {slug: string;isOrganization?: boolean;parentId?: number;- metadata?: JsonValue;+ metadata?: Prisma.TeamCreateInput["metadata"];organizationSettings?: {orgAutoAcceptEmail: string;isOrganizationVerified?: boolean;