Skip to content

Scheduling infrastructure for absolutely everyone.

refactor: v2 return booking host email (#18864)

Lauris Skraucis4235a36887c3
diff --git a/apps/api/v2/src/ee/bookings/2024-08-13/controllers/e2e/user-bookings.e2e-spec.ts b/apps/api/v2/src/ee/bookings/2024-08-13/controllers/e2e/user-bookings.e2e-spec.ts
index 9bdc41262fe..6f001fda889 100644
--- a/apps/api/v2/src/ee/bookings/2024-08-13/controllers/e2e/user-bookings.e2e-spec.ts
+++ b/apps/api/v2/src/ee/bookings/2024-08-13/controllers/e2e/user-bookings.e2e-spec.ts
@@ -354,6 +354,7 @@ describe("Bookings Endpoints 2024-08-13", () => {
expect(data.uid).toBeDefined();
expect(data.hosts[0].id).toEqual(user.id);
expect(data.hosts[0].username).toEqual(user.username);
+ expect(data.hosts[0].email).toEqual(user.email);
expect(data.status).toEqual("accepted");
expect(data.start).toEqual(body.start);
expect(data.end).toEqual(new Date(Date.UTC(2030, 0, 8, 14, 0, 0)).toISOString());
@@ -518,6 +519,7 @@ describe("Bookings Endpoints 2024-08-13", () => {
expect(data.uid).toEqual(createdBooking.uid);
expect(data.hosts[0].id).toEqual(user.id);
expect(data.hosts[0].username).toEqual(user.username);
+ expect(data.hosts[0].email).toEqual(user.email);
expect(data.status).toEqual(createdBooking.status);
expect(data.start).toEqual(createdBooking.start);
expect(data.end).toEqual(createdBooking.end);
@@ -552,6 +554,8 @@ describe("Bookings Endpoints 2024-08-13", () => {
expect(data.id).toEqual(createdRecurringBooking[0].id);
expect(data.uid).toEqual(createdRecurringBooking[0].uid);
expect(data.hosts[0].id).toEqual(user.id);
+ expect(data.hosts[0].username).toEqual(user.username);
+ expect(data.hosts[0].email).toEqual(user.email);
expect(data.status).toEqual(createdRecurringBooking[0].status);
expect(data.start).toEqual(createdRecurringBooking[0].start);
expect(data.end).toEqual(createdRecurringBooking[0].end);
@@ -1021,6 +1025,8 @@ describe("Bookings Endpoints 2024-08-13", () => {
expect(data.id).toBeDefined();
expect(data.uid).toBeDefined();
expect(data.hosts[0].id).toEqual(user.id);
+ expect(data.hosts[0].username).toEqual(user.username);
+ expect(data.hosts[0].email).toEqual(user.email);
expect(data.status).toEqual(createdBooking.status);
expect(data.duration).toEqual(createdBooking.duration);
expect(data.eventTypeId).toEqual(createdBooking.eventTypeId);
@@ -1078,6 +1084,8 @@ describe("Bookings Endpoints 2024-08-13", () => {
expect(data.id).toBeDefined();
expect(data.uid).toBeDefined();
expect(data.hosts[0].id).toEqual(user.id);
+ expect(data.hosts[0].username).toEqual(user.username);
+ expect(data.hosts[0].email).toEqual(user.email);
expect(data.status).toEqual(createdRecurringBooking[0].status);
expect(data.start).toEqual(body.start);
expect(data.end).toEqual(new Date(Date.UTC(2035, 0, 9, 15, 0, 0)).toISOString());
@@ -1158,6 +1166,8 @@ describe("Bookings Endpoints 2024-08-13", () => {
expect(data.id).toEqual(booking.id);
expect(data.uid).toEqual(booking.uid);
expect(data.hosts[0].id).toEqual(user.id);
+ expect(data.hosts[0].username).toEqual(user.username);
+ expect(data.hosts[0].email).toEqual(user.email);
expect(data.status).toEqual(booking.status);
expect(data.start).toEqual(booking.start);
expect(data.end).toEqual(booking.end);
@@ -1190,6 +1200,8 @@ describe("Bookings Endpoints 2024-08-13", () => {
expect(data.id).toEqual(booking.id);
expect(data.uid).toEqual(booking.uid);
expect(data.hosts[0].id).toEqual(user.id);
+ expect(data.hosts[0].username).toEqual(user.username);
+ expect(data.hosts[0].email).toEqual(user.email);
expect(data.status).toEqual(booking.status);
expect(data.start).toEqual(booking.start);
expect(data.end).toEqual(booking.end);
@@ -1228,6 +1240,8 @@ describe("Bookings Endpoints 2024-08-13", () => {
expect(data.id).toBeDefined();
expect(data.uid).toBeDefined();
expect(data.hosts[0].id).toEqual(user.id);
+ expect(data.hosts[0].username).toEqual(user.username);
+ expect(data.hosts[0].email).toEqual(user.email);
expect(data.status).toEqual("cancelled");
expect(data.cancellationReason).toEqual(body.cancellationReason);
expect(data.start).toEqual(rescheduledBooking.start);
diff --git a/apps/api/v2/swagger/documentation.json b/apps/api/v2/swagger/documentation.json
index 0de90fa49c9..e02b0cc3698 100644
--- a/apps/api/v2/swagger/documentation.json
+++ b/apps/api/v2/swagger/documentation.json
@@ -15101,6 +15101,10 @@
"type": "string",
"example": "Jane Doe"
},
+ "email": {
+ "type": "string",
+ "example": "[email protected]"
+ },
"username": {
"type": "string",
"example": "jane100"
@@ -15113,6 +15117,7 @@
"required": [
"id",
"name",
+ "email",
"username",
"timeZone"
]
diff --git a/docs/api-reference/v2/openapi.json b/docs/api-reference/v2/openapi.json
index 85acb066f80..34d47852013 100644
--- a/docs/api-reference/v2/openapi.json
+++ b/docs/api-reference/v2/openapi.json
@@ -13584,6 +13584,10 @@
"type": "string",
"example": "Jane Doe"
},
+ "email": {
+ "type": "string",
+ "example": "[email protected]"
+ },
"username": {
"type": "string",
"example": "jane100"
@@ -13593,7 +13597,7 @@
"example": "America/Los_Angeles"
}
},
- "required": ["id", "name", "username", "timeZone"]
+ "required": ["id", "name", "email", "username", "timeZone"]
},
"EventType": {
"type": "object",
diff --git a/packages/platform/types/bookings/2024-08-13/outputs/booking.output.ts b/packages/platform/types/bookings/2024-08-13/outputs/booking.output.ts
index 4a6a7af7ce8..451bf2a7691 100644
--- a/packages/platform/types/bookings/2024-08-13/outputs/booking.output.ts
+++ b/packages/platform/types/bookings/2024-08-13/outputs/booking.output.ts
@@ -90,6 +90,11 @@ class BookingHost {
@Expose()
name!: string;
+ @ApiProperty({ type: String, example: "[email protected]" })
+ @IsString()
+ @Expose()
+ email!: string;
+
@ApiProperty({ type: String, example: "jane100" })
@IsString()
@Expose()