Scheduling infrastructure for absolutely everyone.
fix: Filter invalid keys and handle disabled states during booking limit transformation, with added tests (#28035)
Muhammad Usman4b247640a87e
diff --git a/apps/api/v2/src/ee/event-types/event-types_2024_06_14/transformers/api-to-internal/api-to-internal.spec.ts b/apps/api/v2/src/ee/event-types/event-types_2024_06_14/transformers/api-to-internal/api-to-internal.spec.tsindex 7383079a4b3..2235e1281ee 100644--- a/apps/api/v2/src/ee/event-types/event-types_2024_06_14/transformers/api-to-internal/api-to-internal.spec.ts+++ b/apps/api/v2/src/ee/event-types/event-types_2024_06_14/transformers/api-to-internal/api-to-internal.spec.ts@@ -22,7 +22,6 @@ import type {SeatOptionsDisabledSchema,SeatOptionsTransformedSchema,} from "@calcom/platform-types";-import {type CustomField,type SystemField,@@ -689,6 +688,32 @@ describe("transformIntervalLimitsApiToInternal", () => {expect(result).toEqual(expectedOutput);});++ it("should handle bookingLimitsCount with disabled: false and valid counts", () => {+ const input: BookingLimitsCount_2024_06_14 = {+ day: 5,+ disabled: false,+ };++ const expectedOutput = {+ PER_DAY: 5,+ };+ const result = transformIntervalLimitsApiToInternal(input);++ expect(result).toEqual(expectedOutput);+ expect(result).not.toHaveProperty("undefined");+ });++ it("should handle bookingLimitsCount with disabled: true", () => {+ const input: BookingLimitsCount_2024_06_14 = {+ disabled: true,+ };++ const expectedOutput = {};+ const result = transformIntervalLimitsApiToInternal(input);++ expect(result).toEqual(expectedOutput);+ });});describe("transformFutureBookingLimitsApiToInternal", () => {diff --git a/apps/api/v2/src/ee/event-types/event-types_2024_06_14/transformers/api-to-internal/interval-limits.ts b/apps/api/v2/src/ee/event-types/event-types_2024_06_14/transformers/api-to-internal/interval-limits.tsindex e7686b30ff7..d3c11b96f96 100644--- a/apps/api/v2/src/ee/event-types/event-types_2024_06_14/transformers/api-to-internal/interval-limits.ts+++ b/apps/api/v2/src/ee/event-types/event-types_2024_06_14/transformers/api-to-internal/interval-limits.ts@@ -1,7 +1,7 @@import { BookingLimitsEnum_2024_06_14 } from "@calcom/platform-enums";import {- type CreateEventTypeInput_2024_06_14,type BookingLimitsKeyOutputType_2024_06_14,+ type CreateEventTypeInput_2024_06_14,type TransformBookingLimitsSchema_2024_06_14,} from "@calcom/platform-types";@@ -13,7 +13,10 @@ export function transformIntervalLimitsApiToInternal(return res;}inputBookingLimits &&- Object.entries(inputBookingLimits).map(([key, value]) => {+ Object.entries(inputBookingLimits).forEach(([key, value]) => {+ if (!(key in BookingLimitsEnum_2024_06_14)) {+ return;+ }const outputKey: BookingLimitsKeyOutputType_2024_06_14 = BookingLimitsEnum_2024_06_14[key as keyof typeof BookingLimitsEnum_2024_06_14] satisfies BookingLimitsKeyOutputType_2024_06_14;