Scheduling infrastructure for absolutely everyone.
fix: validate eventTypeId is number in API v1 bookings endpoint (#22433)
Keith Williams57564381cb83
diff --git a/apps/api/v1/pages/api/bookings/_post.ts b/apps/api/v1/pages/api/bookings/_post.tsindex 9b6628d04a5..fc173abf909 100644--- a/apps/api/v1/pages/api/bookings/_post.ts+++ b/apps/api/v1/pages/api/bookings/_post.ts@@ -222,6 +222,13 @@ async function handler(req: NextApiRequest) {};if (isSystemWideAdmin) userId = req.body.userId || userId;+ if (req.body.eventTypeId !== undefined && typeof req.body.eventTypeId !== "number") {+ throw new HttpError({+ statusCode: 400,+ message: "Bad request, eventTypeId must be a number",+ });+ }+if (isOrganizationOwnerOrAdmin) {const accessibleUsersIds = await getAccessibleUsers({adminUserId: userId,diff --git a/apps/api/v1/test/lib/bookings/_post.test.ts b/apps/api/v1/test/lib/bookings/_post.test.tsindex 9aa9b516d73..0afe571a689 100644--- a/apps/api/v1/test/lib/bookings/_post.test.ts+++ b/apps/api/v1/test/lib/bookings/_post.test.ts@@ -25,6 +25,44 @@ vi.mock("@calcom/lib/server/i18n", () => {};});+describe("POST /api/bookings - eventTypeId validation", () => {+ test("String eventTypeId should return 400", async () => {+ const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({+ method: "POST",+ body: {+ eventTypeId: "invalid-string",+ },+ });++ await handler(req, res);++ expect(res._getStatusCode()).toBe(400);+ expect(JSON.parse(res._getData())).toEqual(+ expect.objectContaining({+ message: "Bad request, eventTypeId must be a number",+ })+ );+ });++ test("Number eventTypeId should not trigger validation error", async () => {+ const { req, res } = createMocks<CustomNextApiRequest, CustomNextApiResponse>({+ method: "POST",+ body: {+ eventTypeId: 123,+ },+ });++ await handler(req, res);++ const statusCode = res._getStatusCode();+ const responseData = JSON.parse(res._getData());++ if (statusCode === 400) {+ expect(responseData.message).not.toBe("Bad request, eventTypeId must be a number");+ }+ });+});+describe.skipIf(true)("POST /api/bookings", () => {describe("Errors", () => {test("Missing required data", async () => {