Skip to content

Scheduling infrastructure for absolutely everyone.

fix salesforce query (#20196)

Hariom Balhara7250e2225757
diff --git a/packages/app-store/salesforce/lib/CrmService.test.ts b/packages/app-store/salesforce/lib/CrmService.test.ts
index 45d0cbe5458..e8a2400a63e 100644
--- a/packages/app-store/salesforce/lib/CrmService.test.ts
+++ b/packages/app-store/salesforce/lib/CrmService.test.ts
@@ -568,7 +568,7 @@ describe("SalesforceCRMService", () => {
it("should return all possible account websites from email domain", () => {
const result = service.getAllPossibleAccountWebsiteFromEmailDomain("example.com");
expect(result).toEqual(
- "example.com, www.example.com, http://www.example.com, http://example.com, https://www.example.com, https://example.com"
+ "'example.com', 'www.example.com', 'http://www.example.com', 'http://example.com', 'https://www.example.com', 'https://example.com'"
);
});
});
diff --git a/packages/app-store/salesforce/lib/CrmService.ts b/packages/app-store/salesforce/lib/CrmService.ts
index 5e6a2a13c49..18b5cde0377 100644
--- a/packages/app-store/salesforce/lib/CrmService.ts
+++ b/packages/app-store/salesforce/lib/CrmService.ts
@@ -894,14 +894,15 @@ export default class SalesforceCRMService implements CRM {
}
public getAllPossibleAccountWebsiteFromEmailDomain(emailDomain: string) {
- return [
+ const websites = [
emailDomain,
`www.${emailDomain}`,
`http://www.${emailDomain}`,
`http://${emailDomain}`,
`https://www.${emailDomain}`,
`https://${emailDomain}`,
- ].join(", ");
+ ];
+ return websites.map((website) => `'${website}'`).join(", ");
}
private async getAccountIdBasedOnEmailDomainOfContacts(email: string) {
diff --git a/packages/app-store/salesforce/lib/__tests__/salesforceMock.ts b/packages/app-store/salesforce/lib/__tests__/salesforceMock.ts
index 98135cd02c5..a29646b78f6 100644
--- a/packages/app-store/salesforce/lib/__tests__/salesforceMock.ts
+++ b/packages/app-store/salesforce/lib/__tests__/salesforceMock.ts
@@ -139,7 +139,8 @@ export const createSalesforceMock = () => {
if (whereClause.includes("Website IN")) {
const websitesMatch = whereClause.match(/Website IN \((.+)\)/i);
if (websitesMatch) {
- const websites = websitesMatch[1].split(",").map((w) => w.trim());
+ // Split by comma, trim spaces and quotes
+ const websites = websitesMatch[1].split(",").map((w) => w.trim().replace(/^'|'$/g, ""));
result = result.filter((r) => websites.includes(r.Website));
}
}