Skip to content

Scheduling infrastructure for absolutely everyone.

fix: remove sticky positioning from page headers in pages on scroll (#27242)

Eesh Midha72d6fcb3717c
diff --git a/apps/web/app/(use-page-wrapper)/apps/routing-forms/forms/[[...pages]]/Forms.tsx b/apps/web/app/(use-page-wrapper)/apps/routing-forms/forms/[[...pages]]/Forms.tsx
index d60500e9dc8..bbb702400cf 100644
--- a/apps/web/app/(use-page-wrapper)/apps/routing-forms/forms/[[...pages]]/Forms.tsx
+++ b/apps/web/app/(use-page-wrapper)/apps/routing-forms/forms/[[...pages]]/Forms.tsx
@@ -149,6 +149,7 @@ export default function RoutingForms({ appUrl }: { appUrl: string }) {
return (
<LicenseRequired>
<ShellMain
+ disableSticky={true}
heading={t("routing")}
CTA={
hasPaidPlan && forms?.length ? (
diff --git a/apps/web/app/(use-page-wrapper)/settings/organizations/(org-user-only)/[id]/members/layout.tsx b/apps/web/app/(use-page-wrapper)/settings/organizations/(org-user-only)/[id]/members/layout.tsx
index eef834cf8b7..3ca093d60e7 100644
--- a/apps/web/app/(use-page-wrapper)/settings/organizations/(org-user-only)/[id]/members/layout.tsx
+++ b/apps/web/app/(use-page-wrapper)/settings/organizations/(org-user-only)/[id]/members/layout.tsx
@@ -10,6 +10,7 @@ export default async function Layout({ children }: { children: React.ReactNode }
return (
<Shell
withoutMain={false}
+ disableSticky={true}
heading={t("organization_members")}
subtitle={t("organization_description")}
headerClassName="hidden md:block"
diff --git a/apps/web/app/(use-page-wrapper)/settings/platform/members/layout.tsx b/apps/web/app/(use-page-wrapper)/settings/platform/members/layout.tsx
index 94dc169f9f8..0f880c807d7 100644
--- a/apps/web/app/(use-page-wrapper)/settings/platform/members/layout.tsx
+++ b/apps/web/app/(use-page-wrapper)/settings/platform/members/layout.tsx
@@ -23,6 +23,7 @@ export default async function Layout({ children }: { children: React.ReactNode }
/>
</div>
}
+ disableSticky={true}
title={t("platform_members")}
subtitle={t("platform_members_description")}
withoutMain={false}
diff --git a/apps/web/modules/ee/workflows/views/WorkflowsPage.tsx b/apps/web/modules/ee/workflows/views/WorkflowsPage.tsx
index 78841ddc988..67eadcee7f5 100644
--- a/apps/web/modules/ee/workflows/views/WorkflowsPage.tsx
+++ b/apps/web/modules/ee/workflows/views/WorkflowsPage.tsx
@@ -56,6 +56,7 @@ function WorkflowsPage({ filteredList }: PageProps) {
<Shell withoutMain>
<LicenseRequired>
<ShellMain
+ disableSticky={true}
heading={t("workflows")}
subtitle={t("workflows_to_automate_notifications")}
title={t("workflows")}
diff --git a/apps/web/modules/shell/Shell.tsx b/apps/web/modules/shell/Shell.tsx
index 74c54a00c54..f861cb3df7b 100644
--- a/apps/web/modules/shell/Shell.tsx
+++ b/apps/web/modules/shell/Shell.tsx
@@ -87,6 +87,7 @@ export type LayoutProps = {
afterHeading?: ReactNode;
smallHeading?: boolean;
isPlatformUser?: boolean;
+ disableSticky?: boolean;
};
const KBarWrapper = ({ children, withKBar = false }: { withKBar: boolean; children: React.ReactNode }) =>
@@ -132,8 +133,9 @@ export function ShellMain(props: LayoutProps) {
{(props.heading || !!props.backPath) && (
<div
className={classNames(
- "bg-default sticky top-0 z-10 mb-0 flex items-center md:mb-6 md:mt-0",
- props.smallHeading ? "lg:mb-7" : "lg:mb-8"
+ "bg-default mb-0 flex items-center md:mb-6 md:mt-0",
+ props.smallHeading ? "lg:mb-7" : "lg:mb-8",
+ !props.disableSticky && "sticky top-0 z-10"
)}>
{!!props.backPath && (
<Button