Skip to content

Scheduling infrastructure for absolutely everyone.

fix: Standardize email field editable to system-but-optional (#24416)

Anik Dhabal Babub881e025f6d0
diff --git a/apps/api/v2/src/ee/event-types/event-types_2024_04_15/services/event-types.service.ts b/apps/api/v2/src/ee/event-types/event-types_2024_04_15/services/event-types.service.ts
index 7a08114549f..d7cc75cd79b 100644
--- a/apps/api/v2/src/ee/event-types/event-types_2024_04_15/services/event-types.service.ts
+++ b/apps/api/v2/src/ee/event-types/event-types_2024_04_15/services/event-types.service.ts
@@ -137,7 +137,11 @@ export class EventTypesService_2024_04_15 {
!bookingFields.find((field) => field.type === "email") &&
!bookingFields.find((field) => field.type === "phone")
) {
- bookingFields.push({ ...systemBeforeFieldEmail, type: BaseField.email, editable: Editable.system });
+ bookingFields.push({
+ ...systemBeforeFieldEmail,
+ type: BaseField.email,
+ editable: Editable.systemButOptional,
+ });
}
await updateEventType({
diff --git a/apps/api/v2/src/ee/event-types/event-types_2024_06_14/transformers/internal-to-api/booking-fields.ts b/apps/api/v2/src/ee/event-types/event-types_2024_06_14/transformers/internal-to-api/booking-fields.ts
index 73ab5e90095..c83bcc4a3a9 100644
--- a/apps/api/v2/src/ee/event-types/event-types_2024_06_14/transformers/internal-to-api/booking-fields.ts
+++ b/apps/api/v2/src/ee/event-types/event-types_2024_06_14/transformers/internal-to-api/booking-fields.ts
@@ -556,7 +556,7 @@ export const systemBeforeFieldEmail: EmailSystemField = {
type: "email",
name: "email",
required: true,
- editable: "system",
+ editable: "system-but-optional",
sources: [
{
label: "Default",
diff --git a/apps/web/test/utils/bookingScenario/bookingScenario.ts b/apps/web/test/utils/bookingScenario/bookingScenario.ts
index 06e33ce6f80..4c07a7112a2 100644
--- a/apps/web/test/utils/bookingScenario/bookingScenario.ts
+++ b/apps/web/test/utils/bookingScenario/bookingScenario.ts
@@ -2397,7 +2397,7 @@ export const getDefaultBookingFields = ({
label: "",
hidden: false,
sources: [{ id: "default", type: "default", label: "Default" }],
- editable: "system",
+ editable: "system-but-optional",
required: true,
placeholder: "",
defaultLabel: "email_address",