Skip to content

Scheduling infrastructure for absolutely everyone.

refactor(app-store): move credential query to repository pattern (#29724)

Anirban Singhaca90ca2c9453
diff --git a/packages/app-store/repositories/PrismaCredentialRepository.ts b/packages/app-store/repositories/PrismaCredentialRepository.ts
new file mode 100644
index 00000000000..0901159f51a
--- /dev/null
+++ b/packages/app-store/repositories/PrismaCredentialRepository.ts
@@ -0,0 +1,40 @@
+import { buildNonDelegationCredentials } from "@calcom/lib/delegationCredential";
+import { prisma } from "@calcom/prisma";
+import type { Prisma } from "@calcom/prisma/client";
+import type { AppCategories } from "@calcom/prisma/client";
+import { credentialForCalendarServiceSelect } from "@calcom/prisma/selects/credential";
+
+export class PrismaCredentialRepository {
+ constructor(private readonly prismaClient: typeof prisma){}
+
+ async findNonDelegationCredentialsByAppCategories({
+ idToSearchObject,
+ appCategories,
+ }: {
+ idToSearchObject: Prisma.CredentialWhereInput;
+ appCategories: AppCategories[];
+ }){
+
+ const credentials = await this.prismaClient.credential.findMany({
+ where: {
+ ...idToSearchObject,
+ app: {
+ categories: {
+ hasSome: appCategories
+ }
+ }
+ },
+ select: {
+ ...credentialForCalendarServiceSelect,
+ team: {
+ select: {
+ name: true
+ }
+ }
+ }
+ })
+
+
+ return buildNonDelegationCredentials(credentials)
+ }
+}
\ No newline at end of file
diff --git a/packages/app-store/server.ts b/packages/app-store/server.ts
index a6729e9badd..33e068d383b 100644
--- a/packages/app-store/server.ts
+++ b/packages/app-store/server.ts
@@ -2,11 +2,10 @@ import type { TFunction } from "i18next";
import { enrichUserWithDelegationConferencingCredentialsWithoutOrgId } from "@calcom/app-store/delegationCredential";
import { defaultVideoAppCategories } from "@calcom/app-store/utils";
-import { buildNonDelegationCredentials } from "@calcom/lib/delegationCredential";
import { prisma } from "@calcom/prisma";
import type { Prisma } from "@calcom/prisma/client";
import { AppCategories } from "@calcom/prisma/enums";
-import { credentialForCalendarServiceSelect } from "@calcom/prisma/selects/credential";
+import { PrismaCredentialRepository } from "./repositories/PrismaCredentialRepository";
import getEnabledAppsFromCredentials from "./_utils/getEnabledAppsFromCredentials";
import { defaultLocations } from "./locations";
@@ -62,23 +61,10 @@ export async function getLocationGroupedOptions(
});
}
- const nonDelegationCredentials = await prisma.credential.findMany({
- where: {
- ...idToSearchObject,
- app: {
- categories: {
- hasSome: defaultVideoAppCategories,
- },
- },
- },
- select: {
- ...credentialForCalendarServiceSelect,
- team: {
- select: {
- name: true,
- },
- },
- },
+ const credentialRepository = new PrismaCredentialRepository(prisma);
+ const nonDelegationCredentials = await credentialRepository.findNonDelegationCredentialsByAppCategories({
+ idToSearchObject,
+ appCategories: defaultVideoAppCategories,
});
let credentials;
@@ -94,8 +80,7 @@ export async function getLocationGroupedOptions(
);
credentials = allCredentials;
} else {
- // TODO: We can avoid calling buildNonDelegationCredentials here by moving the above prisma query to the repository and doing it there
- credentials = buildNonDelegationCredentials(nonDelegationCredentials);
+ credentials = nonDelegationCredentials;
}
const integrations = await getEnabledAppsFromCredentials(credentials, { filterOnCredentials: true });