Skip to content

Scheduling infrastructure for absolutely everyone.

chore: Improve error handling for avatar API, shouldn't result in timeouts (#21493)

Alex van Andeld1f7b043e87e
diff --git a/packages/features/auth/signup/utils/prefillAvatar.ts b/packages/features/auth/signup/utils/prefillAvatar.ts
index e94f29e4be8..628c53a788f 100644
--- a/packages/features/auth/signup/utils/prefillAvatar.ts
+++ b/packages/features/auth/signup/utils/prefillAvatar.ts
@@ -60,24 +60,42 @@ const getImageUrlAvatarAPI = async (email: string) => {
return null;
}
- const response = await fetch("https://avatarapi.com/v2/api.aspx", {
- method: "POST",
- headers: {
- "Content-Type": "text/plain",
- },
- body: JSON.stringify({
- username: process.env.AVATARAPI_USERNAME,
- password: process.env.AVATARAPI_PASSWORD,
- email: email,
- }),
- });
-
- const info = await response.json();
+ const controller = new AbortController();
+ const timeout = setTimeout(() => controller.abort(), 10_000);
- if (!info.Success) {
- console.log("Error from avatar api: ", info.Error);
+ try {
+ const response = await fetch("https://avatarapi.com/v2/api.aspx", {
+ method: "POST",
+ headers: {
+ "Content-Type": "text/plain",
+ },
+ body: JSON.stringify({
+ username: process.env.AVATARAPI_USERNAME,
+ password: process.env.AVATARAPI_PASSWORD,
+ email,
+ }),
+ signal: controller.signal,
+ });
+
+ clearTimeout(timeout);
+
+ const info = await response.json();
+
+ if (!info.Success) {
+ if (info.Error === "Not found") {
+ // Expected case: no avatar for this email
+ return null;
+ }
+ console.warn("Avatar API error:", info.Error);
+ return null;
+ }
+ return info.Image as string;
+ } catch (error: unknown) {
+ if (error instanceof DOMException && error.name === "AbortError") {
+ console.warn("Avatar API request timed out");
+ } else {
+ console.error("Avatar API request failed:", error);
+ }
return null;
}
-
- return info.Image as string;
};