Skip to content

Scheduling infrastructure for absolutely everyone.

fix: schedule.get unneccsary called from avaiablity view (#20094)

Anik Dhabal Babudf6ee73e053e
diff --git a/packages/features/schedules/components/ScheduleListItem.tsx b/packages/features/schedules/components/ScheduleListItem.tsx
index a781ed5c8be..aa6670153a5 100644
--- a/packages/features/schedules/components/ScheduleListItem.tsx
+++ b/packages/features/schedules/components/ScheduleListItem.tsx
@@ -5,7 +5,6 @@ import { availabilityAsString } from "@calcom/lib/availability";
import { useLocale } from "@calcom/lib/hooks/useLocale";
import { sortAvailabilityStrings } from "@calcom/lib/weekstart";
import type { RouterOutputs } from "@calcom/trpc/react";
-import { trpc } from "@calcom/trpc/react";
import {
Badge,
Button,
@@ -39,8 +38,6 @@ export function ScheduleListItem({
}) {
const { t, i18n } = useLocale();
- const { data, isPending } = trpc.viewer.availability.schedule.get.useQuery({ scheduleId: schedule.id });
-
return (
<li key={schedule.id}>
<div className="hover:bg-muted flex items-center justify-between px-3 py-5 transition sm:px-4">
@@ -93,56 +90,54 @@ export function ScheduleListItem({
StartIcon="ellipsis"
/>
</DropdownMenuTrigger>
- {!isPending && data && (
- <DropdownMenuContent>
- {!schedule.isDefault && (
- <DropdownMenuItem className="min-w-40 focus:ring-muted">
- <DropdownItem
- type="button"
- StartIcon="star"
- onClick={() => {
- updateDefault({
- scheduleId: schedule.id,
- isDefault: true,
- });
- }}>
- {t("set_as_default")}
- </DropdownItem>
- </DropdownMenuItem>
- )}
- <DropdownMenuItem className="outline-none">
+ <DropdownMenuContent>
+ {!schedule.isDefault && (
+ <DropdownMenuItem className="min-w-40 focus:ring-muted">
<DropdownItem
type="button"
- data-testid={`schedule-duplicate${schedule.id}`}
- StartIcon="copy"
+ StartIcon="star"
onClick={() => {
- duplicateFunction({
+ updateDefault({
scheduleId: schedule.id,
+ isDefault: true,
});
}}>
- {t("duplicate")}
- </DropdownItem>
- </DropdownMenuItem>
- <DropdownMenuItem className="min-w-40 focus:ring-muted">
- <DropdownItem
- type="button"
- color="destructive"
- StartIcon="trash"
- data-testid="delete-schedule"
- onClick={() => {
- if (!isDeletable) {
- showToast(t("requires_at_least_one_schedule"), "error");
- } else {
- deleteFunction({
- scheduleId: schedule.id,
- });
- }
- }}>
- {t("delete")}
+ {t("set_as_default")}
</DropdownItem>
</DropdownMenuItem>
- </DropdownMenuContent>
- )}
+ )}
+ <DropdownMenuItem className="outline-none">
+ <DropdownItem
+ type="button"
+ data-testid={`schedule-duplicate${schedule.id}`}
+ StartIcon="copy"
+ onClick={() => {
+ duplicateFunction({
+ scheduleId: schedule.id,
+ });
+ }}>
+ {t("duplicate")}
+ </DropdownItem>
+ </DropdownMenuItem>
+ <DropdownMenuItem className="min-w-40 focus:ring-muted">
+ <DropdownItem
+ type="button"
+ color="destructive"
+ StartIcon="trash"
+ data-testid="delete-schedule"
+ onClick={() => {
+ if (!isDeletable) {
+ showToast(t("requires_at_least_one_schedule"), "error");
+ } else {
+ deleteFunction({
+ scheduleId: schedule.id,
+ });
+ }
+ }}>
+ {t("delete")}
+ </DropdownItem>
+ </DropdownMenuItem>
+ </DropdownMenuContent>
</Dropdown>
</div>
</li>