Scheduling infrastructure for absolutely everyone.
feat(bookings): conditionally show heading/subtitle based on view (#25889)
Eunjae Leee0a28af46e45
diff --git a/apps/web/app/(use-page-wrapper)/(main-nav)/bookings/[status]/page.tsx b/apps/web/app/(use-page-wrapper)/(main-nav)/bookings/[status]/page.tsxindex fe7fedbf513..2176941549f 100644--- a/apps/web/app/(use-page-wrapper)/(main-nav)/bookings/[status]/page.tsx+++ b/apps/web/app/(use-page-wrapper)/(main-nav)/bookings/[status]/page.tsx@@ -1,6 +1,6 @@import { ShellMainAppDir } from "app/(use-page-wrapper)/(main-nav)/ShellMainAppDir";import type { PageProps } from "app/_types";-import { _generateMetadata } from "app/_utils";+import { _generateMetadata, getTranslate } from "app/_utils";import { cookies, headers } from "next/headers";import { redirect } from "next/navigation";import { z } from "zod";@@ -34,6 +34,7 @@ const Page = async ({ params }: PageProps) => {if (!parsed.success) {redirect("/bookings/upcoming");}+ const t = await getTranslate();const session = await getServerSession({ req: buildLegacyRequest(await headers(), await cookies()) });let canReadOthersBookings = false;@@ -59,7 +60,10 @@ const Page = async ({ params }: PageProps) => {: false;return (- <ShellMainAppDir>+ <ShellMainAppDir+ heading={t("bookings")}+ subtitle={t("bookings_description")}+ headerClassName="bookings-shell-heading"><BookingsListstatus={parsed.data.status}userId={session?.user?.id}diff --git a/apps/web/modules/bookings/hooks/useBookingsShellHeadingVisibility.ts b/apps/web/modules/bookings/hooks/useBookingsShellHeadingVisibility.tsnew file mode 100644index 00000000000..f823b4bea68--- /dev/null+++ b/apps/web/modules/bookings/hooks/useBookingsShellHeadingVisibility.ts@@ -0,0 +1,25 @@+"use client";++import { useLayoutEffect } from "react";++const MARKER_CLASS = "bookings-shell-heading";++export function useBookingsShellHeadingVisibility({ visible }: { visible: boolean }) {+ useLayoutEffect(() => {+ const marker = document.querySelector(`.${MARKER_CLASS}`);+ if (!marker) return;++ const headerWrapper = marker.closest("header")?.parentElement;+ if (!headerWrapper) return;++ if (visible) {+ headerWrapper.classList.remove("hidden");+ } else {+ headerWrapper.classList.add("hidden");+ }++ return () => {+ headerWrapper.classList.remove("hidden");+ };+ }, [visible]);+}diff --git a/apps/web/modules/bookings/views/bookings-view.tsx b/apps/web/modules/bookings/views/bookings-view.tsxindex a6b434cbd34..0eafa81e7c9 100644--- a/apps/web/modules/bookings/views/bookings-view.tsx+++ b/apps/web/modules/bookings/views/bookings-view.tsx@@ -10,6 +10,7 @@ import { useLocale } from "@calcom/lib/hooks/useLocale";import classNames from "@calcom/ui/classNames";import { BookingListContainer } from "../components/BookingListContainer";+import { useBookingsShellHeadingVisibility } from "../hooks/useBookingsShellHeadingVisibility";import { useBookingsView } from "../hooks/useBookingsView";import type { validStatuses } from "../lib/validStatuses";@@ -70,6 +71,8 @@ export default function Bookings(props: BookingsProps) {function BookingsContent({ status, permissions, bookingsV3Enabled }: BookingsProps) {const [view] = useBookingsView({ bookingsV3Enabled });+ useBookingsShellHeadingVisibility({ visible: view === "list" });+return (<div className={classNames(view === "calendar" && "-mb-8")}>{view === "list" && (