🐫 CAMEL: The first and the best multi-agent framework. Finding the Scaling Law of Agents. https://www.camel-ai.org
Python agentai-societiesartificial-intelligencecommunicative-aicooperative-aideep-learninglarge-language-modelsmulti-agent-systemsnatural-language-processing
feat: Add unitests for BrowserToolkit (#2000)
Huihui Xu33b8bc2c27d7
diff --git a/camel/toolkits/browser_toolkit.py b/camel/toolkits/browser_toolkit.pyindex 46a3da2c6..cd6a75d1b 100644--- a/camel/toolkits/browser_toolkit.py+++ b/camel/toolkits/browser_toolkit.py@@ -20,6 +20,7 @@ import randomimport reimport shutilimport time+import urllib.parsefrom copy import deepcopyfrom typing import (TYPE_CHECKING,@@ -546,8 +547,10 @@ class BaseBrowser:file_path = Noneif save_image:# Get url name to form a file name- # TODO: Use a safer way for the url name- url_name = self.page_url.split("/")[-1]+ # Use urlparser for a safer extraction the url name+ parsed_url = urllib.parse.urlparse(self.page_url)+ url_name = os.path.basename(str(parsed_url.path)) or "index"+for char in ['\\', '/', ':', '*', '?', '"', '<', '>', '|', '.']:url_name = url_name.replace(char, "_")@@ -673,7 +676,8 @@ class BaseBrowser:rects, # type: ignore[arg-type])if save_image:- url_name = self.page_url.split("/")[-1]+ parsed_url = urllib.parse.urlparse(self.page_url)+ url_name = os.path.basename(str(parsed_url.path)) or "index"for char in ['\\', '/', ':', '*', '?', '"', '<', '>', '|', '.']:url_name = url_name.replace(char, "_")timestamp = datetime.datetime.now().strftime("%m%d%H%M%S")diff --git a/examples/toolkits/browser_toolkit.py b/examples/toolkits/browser_toolkit.pyindex 9ffc7f99d..0b81626e8 100644--- a/examples/toolkits/browser_toolkit.py+++ b/examples/toolkits/browser_toolkit.py@@ -12,7 +12,6 @@# limitations under the License.# ========= Copyright 2023-2024 @ CAMEL-AI.org. All Rights Reserved. =========-from camel.agents import ChatAgentfrom camel.configs import ChatGPTConfigfrom camel.models import ModelFactorydiff --git a/test/toolkits/test_browser_toolkit.py b/test/toolkits/test_browser_toolkit.pyindex 67acafdae..94e7fdea3 100644--- a/test/toolkits/test_browser_toolkit.py+++ b/test/toolkits/test_browser_toolkit.py@@ -11,6 +11,7 @@# See the License for the specific language governing permissions and# limitations under the License.# ========= Copyright 2023-2024 @ CAMEL-AI.org. All Rights Reserved. =========+import ioimport osfrom unittest.mock import MagicMock, patch@@ -21,6 +22,9 @@ from PIL import Imagefrom camel.toolkits.browser_toolkit import (BaseBrowser,BrowserToolkit,+ dom_rectangle_from_dict,+ interactive_region_from_dict,+ visual_viewport_from_dict,)TEST_URL = "https://example.com"@@ -172,3 +176,62 @@ def test_browser_back_navigation(base_browser_fixture):browser.page.go_back.assert_called_once()browser.page.wait_for_load_state.assert_called_once()+++def test_dom_rectangle_from_dict():+ rect_dict = {+ "x": 10,+ "y": 20,+ "width": 100,+ "height": 200,+ "top": 20,+ "right": 110,+ "bottom": 220,+ "left": 10,+ }+ rect = dom_rectangle_from_dict(rect_dict)+ assert rect["width"] == 100+ assert rect["left"] == 10+++def test_interactive_region_from_dict():+ region_dict = {+ "tag_name": "button",+ "role": "button",+ "aria-name": "Submit",+ "v-scrollable": False,+ "rects": [+ {+ "x": 5,+ "y": 5,+ "width": 50,+ "height": 20,+ "top": 5,+ "right": 55,+ "bottom": 25,+ "left": 5,+ }+ ],+ }+ region = interactive_region_from_dict(region_dict)+ assert region["tag_name"] == "button"+ assert len(region["rects"]) == 1+++def test_visual_viewport_from_dict():+ viewport_dict = {+ "height": 800,+ "width": 600,+ "offsetLeft": 0,+ "offsetTop": 0,+ "pageLeft": 0,+ "pageTop": 0,+ "scale": 1,+ "clientWidth": 600,+ "clientHeight": 800,+ "scrollWidth": 600,+ "scrollHeight": 1200,+ }+ viewport = visual_viewport_from_dict(viewport_dict)+ assert viewport["height"] == 800+ assert viewport["scrollHeight"] == 1200