🐫 CAMEL: The first and the best multi-agent framework. Finding the Scaling Law of Agents. https://www.camel-ai.org
Python agentai-societiesartificial-intelligencecommunicative-aicooperative-aideep-learninglarge-language-modelsmulti-agent-systemsnatural-language-processing
fix(toolkits): Move results iteration inside try block for better exception handling (#3342)
Lei Zhang534ce368e01d
diff --git a/camel/toolkits/search_toolkit.py b/camel/toolkits/search_toolkit.pyindex f67c42427..baec68b6d 100644--- a/camel/toolkits/search_toolkit.py+++ b/camel/toolkits/search_toolkit.py@@ -189,7 +189,6 @@ class SearchToolkit(BaseToolkit):represents a search result."""from duckduckgo_search import DDGS- from requests.exceptions import RequestExceptionddgs = DDGS()responses: List[Dict[str, Any]] = []@@ -199,65 +198,62 @@ class SearchToolkit(BaseToolkit):results = ddgs.text(keywords=query, max_results=number_of_result_pages)- except RequestException as e:+ # Iterate over results found+ for i, result in enumerate(results, start=1):+ # Creating a response object with a similar structure+ response = {+ "result_id": i,+ "title": result["title"],+ "description": result["body"],+ "url": result["href"],+ }+ responses.append(response)+ except Exception as e:# Handle specific exceptions or general request exceptionsresponses.append({"error": f"duckduckgo search failed.{e}"})- # Iterate over results found- for i, result in enumerate(results, start=1):- # Creating a response object with a similar structure- response = {- "result_id": i,- "title": result["title"],- "description": result["body"],- "url": result["href"],- }- responses.append(response)-elif source == "images":try:results = ddgs.images(keywords=query, max_results=number_of_result_pages)- except RequestException as e:+ # Iterate over results found+ for i, result in enumerate(results, start=1):+ # Creating a response object with a similar structure+ response = {+ "result_id": i,+ "title": result["title"],+ "image": result["image"],+ "url": result["url"],+ "source": result["source"],+ }+ responses.append(response)+ except Exception as e:# Handle specific exceptions or general request exceptionsresponses.append({"error": f"duckduckgo search failed.{e}"})- # Iterate over results found- for i, result in enumerate(results, start=1):- # Creating a response object with a similar structure- response = {- "result_id": i,- "title": result["title"],- "image": result["image"],- "url": result["url"],- "source": result["source"],- }- responses.append(response)-elif source == "videos":try:results = ddgs.videos(keywords=query, max_results=number_of_result_pages)- except RequestException as e:+ # Iterate over results found+ for i, result in enumerate(results, start=1):+ # Creating a response object with a similar structure+ response = {+ "result_id": i,+ "title": result["title"],+ "description": result["description"],+ "embed_url": result["embed_url"],+ "publisher": result["publisher"],+ "duration": result["duration"],+ "published": result["published"],+ }+ responses.append(response)+ except Exception as e:# Handle specific exceptions or general request exceptionsresponses.append({"error": f"duckduckgo search failed.{e}"})- # Iterate over results found- for i, result in enumerate(results, start=1):- # Creating a response object with a similar structure- response = {- "result_id": i,- "title": result["title"],- "description": result["description"],- "embed_url": result["embed_url"],- "publisher": result["publisher"],- "duration": result["duration"],- "published": result["published"],- }- responses.append(response)-# If no answer found, return an empty listreturn responses