Skip to content

armgit / camel

Public Imported from GitHub
0

🐫 CAMEL: The first and the best multi-agent framework. Finding the Scaling Law of Agents. https://www.camel-ai.org

fix(models): map Reka finish_reason to the OpenAI vocabulary (#4214)

Amir Fathi76da662d656d
diff --git a/camel/models/reka_model.py b/camel/models/reka_model.py
index 5e7a0fd1f..67345cddf 100644
--- a/camel/models/reka_model.py
+++ b/camel/models/reka_model.py
@@ -17,6 +17,7 @@ from typing import TYPE_CHECKING, Any, Dict, List, Optional, Type, Union
from pydantic import BaseModel
from camel.configs import RekaConfig
+from camel.logger import get_logger
from camel.messages import OpenAIMessage
from camel.models import BaseModelBackend
from camel.types import ChatCompletion, ModelType
@@ -49,6 +50,16 @@ try:
except (ImportError, AttributeError):
LLMEvent = None
+logger = get_logger(__name__)
+
+_FINISH_REASON_MAP = {
+ "stop": "stop",
+ "length": "length",
+ # Reka's "context" means the context window was exhausted before a
+ # natural stop, the same class of event OpenAI reports as "length".
+ "context": "length",
+}
+
class RekaModel(BaseModelBackend):
r"""Reka API in a unified OpenAICompatibleModel interface.
@@ -119,6 +130,26 @@ class RekaModel(BaseModelBackend):
**kwargs,
)
+ @staticmethod
+ def _map_finish_reason(reka_reason: str) -> str:
+ r"""Map a Reka finish reason to its OpenAI equivalent.
+
+ Reka's SDK types finish_reason as
+ ``Union[Literal["stop", "length", "context"], Any]``, so a future
+ provider value is a normal, successful response rather than a
+ malformed one. An unrecognized reason falls back to "stop" (the
+ OpenAI default for a completed response) instead of raising, and
+ the raw value is logged so the mapping can be extended.
+ """
+ try:
+ return _FINISH_REASON_MAP[reka_reason]
+ except KeyError:
+ logger.warning(
+ f"Unknown Reka finish reason {reka_reason!r}, "
+ "falling back to 'stop'."
+ )
+ return "stop"
+
def _convert_reka_to_openai_response(
self, response: 'ChatResponse'
) -> ChatCompletion:
@@ -131,6 +162,7 @@ class RekaModel(BaseModelBackend):
Returns:
ChatCompletion: An OpenAI-compatible chat completion response.
"""
+ reka_finish_reason = response.responses[0].finish_reason
openai_response = ChatCompletion.construct(
id=response.id,
choices=[
@@ -139,8 +171,8 @@ class RekaModel(BaseModelBackend):
"role": response.responses[0].message.role,
"content": response.responses[0].message.content,
},
- finish_reason=response.responses[0].finish_reason
- if response.responses[0].finish_reason
+ finish_reason=self._map_finish_reason(reka_finish_reason)
+ if reka_finish_reason
else None,
)
],
diff --git a/test/models/test_reka_model.py b/test/models/test_reka_model.py
index bef58b5b1..ea9135f36 100644
--- a/test/models/test_reka_model.py
+++ b/test/models/test_reka_model.py
@@ -12,6 +12,8 @@
# limitations under the License.
# ========= Copyright 2023-2026 @ CAMEL-AI.org. All Rights Reserved. =========
+from types import SimpleNamespace
+
import pytest
from camel.configs import RekaConfig
@@ -36,3 +38,55 @@ def test_reka_model(model_type: ModelType):
assert isinstance(model.token_counter, OpenAITokenCounter)
assert isinstance(model.model_type.value_for_tiktoken, str)
assert isinstance(model.model_type.token_limit, int)
+
+
+def _mock_reka_response(finish_reason):
+ return SimpleNamespace(
+ id="resp-1",
+ model="reka-core",
+ usage=SimpleNamespace(input_tokens=5, output_tokens=3),
+ responses=[
+ SimpleNamespace(
+ message=SimpleNamespace(role="assistant", content="hi"),
+ finish_reason=finish_reason,
+ )
+ ],
+ )
+
+
+ "reka_reason,expected",
+ [
+ ("stop", "stop"),
+ ("length", "length"),
+ ("context", "length"),
+ (None, None),
+ ],
+)
+def test_convert_reka_to_openai_response_maps_finish_reason(
+ reka_reason, expected
+):
+ r"""Reka's finish_reason values must land in the OpenAI contract.
+
+ Reka's own "context" (context window exhausted) is not a value OpenAI's
+ finish_reason accepts; it must be reported as "length", the closest
+ OpenAI analog for a token/context-budget stop.
+ """
+ model = object.__new__(RekaModel)
+ response = _mock_reka_response(reka_reason)
+
+ result = model._convert_reka_to_openai_response(response)
+
+ assert result.choices[0].finish_reason == expected
+
+
+def test_map_finish_reason_unknown_value_falls_back_to_stop(caplog):
+ r"""An unrecognized Reka finish reason is a forward-compat value, not
+ an error: it must not raise, and should fall back to "stop" with the
+ raw value logged.
+ """
+ with caplog.at_level("WARNING"):
+ result = RekaModel._map_finish_reason("some_new_reason")
+
+ assert result == "stop"
+ assert "some_new_reason" in caplog.text