Skip to content

armgit / camel

Public Imported from GitHub
0

🐫 CAMEL: The first and the best multi-agent framework. Finding the Scaling Law of Agents. https://www.camel-ai.org

feat: add skill filter (#3843)

Tao Suneaa30691a6f0
diff --git a/camel/toolkits/skill_toolkit.py b/camel/toolkits/skill_toolkit.py
index 22d0fcf25..601d34c5d 100644
--- a/camel/toolkits/skill_toolkit.py
+++ b/camel/toolkits/skill_toolkit.py
@@ -13,7 +13,7 @@
# ========= Copyright 2023-2026 @ CAMEL-AI.org. All Rights Reserved. =========
from pathlib import Path
-from typing import Dict, List, Optional, Tuple, Union
+from typing import Dict, List, Optional, Set, Tuple, Union
import yaml
@@ -33,6 +33,7 @@ class SkillToolkit(BaseToolkit):
def __init__(
self,
working_directory: Optional[str] = None,
+ allowed_skills: Optional[Set[str]] = None,
timeout: Optional[float] = None,
) -> None:
super().__init__(timeout=timeout)
@@ -42,6 +43,11 @@ class SkillToolkit(BaseToolkit):
else Path.cwd().resolve()
)
self._skills_cache: Optional[Dict[str, Dict[str, str]]] = None
+ self._allowed_skills = (
+ None
+ if allowed_skills is None
+ else {name.strip() for name in allowed_skills if name.strip()}
+ )
def _build_description(self) -> str:
skills = self._get_skills()
@@ -135,7 +141,13 @@ class SkillToolkit(BaseToolkit):
def _get_skills(self) -> Dict[str, Dict[str, str]]:
if self._skills_cache is None:
self._skills_cache = self._scan_skills()
- return self._skills_cache
+ if self._allowed_skills is None:
+ return self._skills_cache
+ return {
+ name: skill
+ for name, skill in self._skills_cache.items()
+ if name in self._allowed_skills
+ }
def clear_cache(self) -> None:
r"""Clear the cached skills to force rescanning on next access."""
diff --git a/test/toolkits/test_skill_toolkit.py b/test/toolkits/test_skill_toolkit.py
index 9143fbf6e..eb4de9ee8 100644
--- a/test/toolkits/test_skill_toolkit.py
+++ b/test/toolkits/test_skill_toolkit.py
@@ -71,6 +71,7 @@ def test_initialization():
toolkit = SkillToolkit()
assert toolkit.working_directory == Path.cwd().resolve()
assert toolkit._skills_cache is None
+ assert toolkit._allowed_skills is None
def test_list_skills(skill_toolkit):
@@ -144,3 +145,16 @@ def test_clear_cache(skill_toolkit):
# Cache should be repopulated on next access
skill_toolkit.list_skills()
assert skill_toolkit._skills_cache is not None
+
+
+def test_allowed_skills_filter_on_init(temp_skill_dir):
+ r"""Test filtering skills by allowed list at initialization."""
+ toolkit = SkillToolkit(
+ working_directory=temp_skill_dir,
+ allowed_skills={"test-skill", " "},
+ )
+ skills = toolkit.list_skills()
+ assert len(skills) == 1
+ assert skills[0]["name"] == "test-skill"
+ assert "## Skill: test-skill" in toolkit.load_skill("test-skill")
+ assert "Error:" in toolkit.load_skill("another-skill")