Skip to content

Open-source manufacturing ERP, MES and QMS. Quoting, MRP, inventory, shop floor, quality and lot/serial traceability on one Postgres schema, with a REST API and MCP server. Self-host or use Carbon Cloud.

fix(erp): picking progress uses the percent formatter instead of Math.round

aashu0872f5549d21
diff --git a/apps/erp/app/modules/inventory/ui/PickingLists/PickingListLines.tsx b/apps/erp/app/modules/inventory/ui/PickingLists/PickingListLines.tsx
index 94c3b80a36..1e42eb4e69 100644
--- a/apps/erp/app/modules/inventory/ui/PickingLists/PickingListLines.tsx
+++ b/apps/erp/app/modules/inventory/ui/PickingLists/PickingListLines.tsx
@@ -47,7 +47,7 @@ import {
import { Await, useFetcher } from "react-router";
import { Empty, ItemThumbnail } from "~/components";
import { Enumerable } from "~/components/Enumerable";
-import { usePermissions } from "~/hooks";
+import { usePercentFormatter, usePermissions } from "~/hooks";
import { useItems } from "~/stores";
import { path } from "~/utils/path";
import { isPickingListLocked } from "../../inventory.models";
@@ -205,10 +205,11 @@ function PickingKitCard({
const progress = totalToPick > 0 ? (totalPicked / totalToPick) * 100 : 0;
const { t } = useLingui();
const { isPhone } = useViewport();
+ const percentFormatter = usePercentFormatter();
// Phones: an overline header for the kit, then each line as its own card.
if (isPhone) {
- const percent = Math.round(progress);
+ const percent = percentFormatter.format(progress / 100);
return (
<section className="flex w-full flex-col gap-3">
<div className="flex items-center justify-between gap-3 px-1 text-xs font-medium uppercase tracking-[0.04em] text-muted-foreground">
@@ -218,7 +219,7 @@ function PickingKitCard({
{kit.workCenterName ? ` · ${kit.workCenterName}` : ""}
</div>
<span className="shrink-0 tabular-nums">
- <Trans>{percent}% picked</Trans>
+ <Trans>{percent} picked</Trans>
</span>
</div>
{kit.lines.map((line) => (
diff --git a/packages/locale/locales/de/erp.po b/packages/locale/locales/de/erp.po
index ba5d0a45be..59c2555217 100644
--- a/packages/locale/locales/de/erp.po
+++ b/packages/locale/locales/de/erp.po
@@ -507,7 +507,7 @@ msgstr "{orderLabel} wird zur Bearbeitung erneut geöffnet als Revision {0}. Das
msgid "{partCount, plural, one {# part} other {# parts}}"
msgstr "{partCount, plural, one {# Teil} other {# Teile}}"
-msgid "{percent}% picked"
+msgid "{percent} picked"
msgstr ""
msgid "{purgeRowCount, plural, one {Permanently delete # row?} other {Permanently delete # rows?}}"
diff --git a/packages/locale/locales/en/erp.po b/packages/locale/locales/en/erp.po
index 5cde8d43a9..3660738183 100644
--- a/packages/locale/locales/en/erp.po
+++ b/packages/locale/locales/en/erp.po
@@ -507,8 +507,8 @@ msgstr "{orderLabel} will be reopened for editing as revision {0}. The document
msgid "{partCount, plural, one {# part} other {# parts}}"
msgstr "{partCount, plural, one {# part} other {# parts}}"
-msgid "{percent}% picked"
-msgstr "{percent}% picked"
+msgid "{percent} picked"
+msgstr "{percent} picked"
msgid "{purgeRowCount, plural, one {Permanently delete # row?} other {Permanently delete # rows?}}"
msgstr "{purgeRowCount, plural, one {Permanently delete # row?} other {Permanently delete # rows?}}"
diff --git a/packages/locale/locales/es/erp.po b/packages/locale/locales/es/erp.po
index 6e5fc77bcb..3ebe589879 100644
--- a/packages/locale/locales/es/erp.po
+++ b/packages/locale/locales/es/erp.po
@@ -507,7 +507,7 @@ msgstr "{orderLabel} se reabrirá para edición como revisión {0}. El documento
msgid "{partCount, plural, one {# part} other {# parts}}"
msgstr "{partCount, plural, one {# pieza} other {# piezas}}"
-msgid "{percent}% picked"
+msgid "{percent} picked"
msgstr ""
msgid "{purgeRowCount, plural, one {Permanently delete # row?} other {Permanently delete # rows?}}"
diff --git a/packages/locale/locales/fr/erp.po b/packages/locale/locales/fr/erp.po
index f621bdbdd1..63327d2c90 100644
--- a/packages/locale/locales/fr/erp.po
+++ b/packages/locale/locales/fr/erp.po
@@ -507,7 +507,7 @@ msgstr "{orderLabel} sera rouvert pour modification en tant que révision {0}. L
msgid "{partCount, plural, one {# part} other {# parts}}"
msgstr "{partCount, plural, one {# pièce} other {# pièces}}"
-msgid "{percent}% picked"
+msgid "{percent} picked"
msgstr ""
msgid "{purgeRowCount, plural, one {Permanently delete # row?} other {Permanently delete # rows?}}"
diff --git a/packages/locale/locales/hi/erp.po b/packages/locale/locales/hi/erp.po
index d51d4f18bf..46b66cac72 100644
--- a/packages/locale/locales/hi/erp.po
+++ b/packages/locale/locales/hi/erp.po
@@ -507,7 +507,7 @@ msgstr "{orderLabel} को रिवीजन {0} के रूप में
msgid "{partCount, plural, one {# part} other {# parts}}"
msgstr "{partCount, plural, one {# पार्ट} other {# पार्ट्स}}"
-msgid "{percent}% picked"
+msgid "{percent} picked"
msgstr ""
msgid "{purgeRowCount, plural, one {Permanently delete # row?} other {Permanently delete # rows?}}"
diff --git a/packages/locale/locales/it/erp.po b/packages/locale/locales/it/erp.po
index a975e092a1..3dbb0e7f30 100644
--- a/packages/locale/locales/it/erp.po
+++ b/packages/locale/locales/it/erp.po
@@ -507,7 +507,7 @@ msgstr "{orderLabel} verrà riaperto per la modifica come revisione {0}. Il docu
msgid "{partCount, plural, one {# part} other {# parts}}"
msgstr "{partCount, plural, one {# componente} other {# componenti}}"
-msgid "{percent}% picked"
+msgid "{percent} picked"
msgstr ""
msgid "{purgeRowCount, plural, one {Permanently delete # row?} other {Permanently delete # rows?}}"
diff --git a/packages/locale/locales/ja/erp.po b/packages/locale/locales/ja/erp.po
index 61bd9fac3e..1ddd3a4cce 100644
--- a/packages/locale/locales/ja/erp.po
+++ b/packages/locale/locales/ja/erp.po
@@ -507,7 +507,7 @@ msgstr "{orderLabel} はリビジョン {0} として編集のため再度オー
msgid "{partCount, plural, one {# part} other {# parts}}"
msgstr "{partCount, plural, one {# 部品} other {# 部品}}"
-msgid "{percent}% picked"
+msgid "{percent} picked"
msgstr ""
msgid "{purgeRowCount, plural, one {Permanently delete # row?} other {Permanently delete # rows?}}"
diff --git a/packages/locale/locales/ko/erp.po b/packages/locale/locales/ko/erp.po
index ec1fee158e..1b20f3c1ea 100644
--- a/packages/locale/locales/ko/erp.po
+++ b/packages/locale/locales/ko/erp.po
@@ -507,7 +507,7 @@ msgstr "{orderLabel}은(는) 리비전 {0}으로 편집하기 위해 다시 열
msgid "{partCount, plural, one {# part} other {# parts}}"
msgstr "{partCount, plural, one {# 부품} other {# 부품}}"
-msgid "{percent}% picked"
+msgid "{percent} picked"
msgstr ""
msgid "{purgeRowCount, plural, one {Permanently delete # row?} other {Permanently delete # rows?}}"
diff --git a/packages/locale/locales/pl/erp.po b/packages/locale/locales/pl/erp.po
index 2c0b2c08b5..295f4c5c49 100644
--- a/packages/locale/locales/pl/erp.po
+++ b/packages/locale/locales/pl/erp.po
@@ -507,7 +507,7 @@ msgstr "{orderLabel} zostanie ponownie otwarty do edycji jako rewizja {0}. Dokum
msgid "{partCount, plural, one {# part} other {# parts}}"
msgstr "{partCount, plural, one {# Część} other {# Części}}"
-msgid "{percent}% picked"
+msgid "{percent} picked"
msgstr ""
msgid "{purgeRowCount, plural, one {Permanently delete # row?} other {Permanently delete # rows?}}"
diff --git a/packages/locale/locales/pt/erp.po b/packages/locale/locales/pt/erp.po
index bb973b5207..eb69a621cd 100644
--- a/packages/locale/locales/pt/erp.po
+++ b/packages/locale/locales/pt/erp.po
@@ -507,7 +507,7 @@ msgstr "{orderLabel} será reaberto para edição como revisão {0}. O documento
msgid "{partCount, plural, one {# part} other {# parts}}"
msgstr "{partCount, plural, one {# peça} other {# peças}}"
-msgid "{percent}% picked"
+msgid "{percent} picked"
msgstr ""
msgid "{purgeRowCount, plural, one {Permanently delete # row?} other {Permanently delete # rows?}}"
diff --git a/packages/locale/locales/ru/erp.po b/packages/locale/locales/ru/erp.po
index 148bc919ef..602a7e9955 100644
--- a/packages/locale/locales/ru/erp.po
+++ b/packages/locale/locales/ru/erp.po
@@ -507,7 +507,7 @@ msgstr "{orderLabel} будет переоткрыт для редактиров
msgid "{partCount, plural, one {# part} other {# parts}}"
msgstr "{partCount, plural, one {# деталь} other {# деталей}}"
-msgid "{percent}% picked"
+msgid "{percent} picked"
msgstr ""
msgid "{purgeRowCount, plural, one {Permanently delete # row?} other {Permanently delete # rows?}}"
diff --git a/packages/locale/locales/tr/erp.po b/packages/locale/locales/tr/erp.po
index 954905ae4b..1e544800fe 100644
--- a/packages/locale/locales/tr/erp.po
+++ b/packages/locale/locales/tr/erp.po
@@ -507,7 +507,7 @@ msgstr "{orderLabel} revizyon {0} olarak düzenlenmek üzere yeniden açılacakt
msgid "{partCount, plural, one {# part} other {# parts}}"
msgstr "{partCount, plural, one {# parça} other {# parça}}"
-msgid "{percent}% picked"
+msgid "{percent} picked"
msgstr ""
msgid "{purgeRowCount, plural, one {Permanently delete # row?} other {Permanently delete # rows?}}"
diff --git a/packages/locale/locales/zh/erp.po b/packages/locale/locales/zh/erp.po
index eb054c7f15..9c5c45088c 100644
--- a/packages/locale/locales/zh/erp.po
+++ b/packages/locale/locales/zh/erp.po
@@ -507,7 +507,7 @@ msgstr "{orderLabel} 将被重新打开以作为修订版本 {0} 进行编辑。
msgid "{partCount, plural, one {# part} other {# parts}}"
msgstr "{partCount, plural, one {# 零件} other {# 零件}}"
-msgid "{percent}% picked"
+msgid "{percent} picked"
msgstr ""
msgid "{purgeRowCount, plural, one {Permanently delete # row?} other {Permanently delete # rows?}}"