Open-source manufacturing ERP, MES and QMS. Quoting, MRP, inventory, shop floor, quality and lot/serial traceability on one Postgres schema, with a REST API and MCP server. Self-host or use Carbon Cloud.
TypeScript ai-agentsbill-of-materialserpinventory-managementleanmanufacturingmanufacturing-execution-systemmcp-servermesmrpopen-source-erppostgresqlproduction-planningqmsquality-management-systemreact-routerself-hostedsupabasetraceabilitytypescript
Merge remote-tracking branch 'origin/main' into naveenkash/item-master-revision-data-copy
naveenkash58c7fe51189b
diff --cc .ai/lessons.mdindex dffdcde260,873dd16d4c..5a8cb6fcd1--- a/.ai/lessons.md+++ b/.ai/lessons.md@@@ -2868,28 -2868,13 +2868,39 @@@ tag until proven otherwise**Applies to:** `packages/utils/src/async.ts` (`limit`), any hand-written semaphore.++## Copying child rows onto a new record can make that record undeletable++**Context:** A new item revision now inherits the source revision's supplier parts and their+price breaks (`copyItemPlanningAndPurchasing`, called by `createRevision`). A change notice+discards its draft revision by deleting the draft item.++**Problem:** `supplierPart.itemId → item` is `ON DELETE CASCADE`, but+`supplierPartPrice → supplierPart` is `ON DELETE RESTRICT`. An item delete therefore cascades+into a supplier part that a price break refuses to let go, and the whole delete fails with+`23503`. Before the copy, a fresh revision had no supplier parts, so nothing exercised that+path; after it, every revision of an item with price breaks carries the blocker: the Item+Master delete was refused, and the change notice's draft discard ignored the delete's error,+so the draft would have survived silently. Reading the migrations for the table being copied+was not enough; the constraint that mattered sat on its child.++**Rule:** Before copying rows onto a record, list the delete rule of every FK that points at+the copied tables (`pg_constraint.confdeltype`, or `grep REFERENCES` for the table name) and+walk every path that deletes the parent. A `RESTRICT`/`NO ACTION` child turns a copy into a+delete blocker. Either delete the child first on that path, in the same transaction as the+parent so a refused parent delete does not lose the child, or change the rule in a migration.+And a delete whose failure the caller ignores is not a delete: return the error.++**Applies to:** `apps/erp/app/modules/items/items.service.ts` (`createRevision`,+`deleteItemsWithPriceBreaks`, `deleteItem`, `discardChangeNoticeDrafts`,+`deleteSupplierPart`), and any copy/duplicate of `supplierPart`.+++ ## "Come back here" must carry the query string++ **Context:** Notification emails link to `/api/link?event=…&documentId=…&companyId=…`, and `requireAuthSession` sends a request away and back for a token refresh, login, MFA or idle unlock.++ **Problem:** `getCurrentPath` returned `pathname` only, so every one of those round trips came back to a bare `/api/link`, which has nothing to resolve and redirects to the home page. The link itself was correct, and it worked on a second click (the token was fresh by then), so it read as an email bug. The token-refresh branch hit anyone idle for longer than the refresh threshold, which is the normal state of someone arriving from an email.++ **Rule:** A "return to where you were" target is `pathname + search`, never `pathname`. When it is passed on inside another URL, encode it (`encodeURIComponent` / `URLSearchParams`), or its own `&` splits it. Test the round trip with a URL that has a query string. Drop React Router's `_routes` param from it, and only when present: middleware sees that param (loaders do not), a page URL that carries it limits which loaders later data requests run, and `searchParams.delete` re-encodes the whole query even when it removes nothing. Whatever sends the target on must be matched by something that reads it: three of the four callbacks ignored the `redirectTo` their login page sent.++ **Applies to:** `packages/auth/src/utils/http.ts` (`getCurrentPath`, `makeRedirectToFromHere`), `requireAuthSession` / `refreshAuthSession`, every app's `login.tsx` callback URL and the `callback.tsx` that consumes it.