Skip to content

Open-source manufacturing ERP, MES and QMS. Quoting, MRP, inventory, shop floor, quality and lot/serial traceability on one Postgres schema, with a REST API and MCP server. Self-host or use Carbon Cloud.

fix(sales): customer portal no longer answers 500

Sidwebworks88cd385651ca
diff --git a/apps/erp/app/components/Table/components/Compact/CompactToolbar.tsx b/apps/erp/app/components/Table/components/Compact/CompactToolbar.tsx
index 243853a858..b6a6bdc75e 100644
--- a/apps/erp/app/components/Table/components/Compact/CompactToolbar.tsx
+++ b/apps/erp/app/components/Table/components/Compact/CompactToolbar.tsx
@@ -33,15 +33,6 @@ import type { ColumnFilter } from "../Filter/types";
import { useFilters } from "../Filter/useFilters";
import { FilterSortSheet } from "./FilterSortSheet";
-const NO_EXPORT: DownloadProps = {
- data: [],
- columnAccessors: {},
- exportValues: {},
- exportOnlyColumns: [],
- columnOrder: [],
- columnVisibility: {}
-};
-
type CompactToolbarProps = {
title?: string;
tableName?: string;
@@ -93,7 +84,6 @@ export function CompactToolbar({
const { t } = useLingui();
const { urlFiltersParams, hasFilters } = useFilters();
const [sheetOpen, setSheetOpen] = useState(false);
- const exportCsv = useCsvDownload(csvExport ?? NO_EXPORT);
const [importTable, setImportTable] = useState<
keyof typeof fieldMappings | null
>(null);
@@ -124,11 +114,8 @@ export function CompactToolbar({
<DropdownMenuContent align="end">
{menuItems}
{menuItems && hasBuiltIns ? <DropdownMenuSeparator /> : null}
- {canExport ? (
- <DropdownMenuItem onClick={exportCsv}>
- <DropdownMenuIcon icon={<LuDownload />} />
- <Trans>Export CSV</Trans>
- </DropdownMenuItem>
+ {canExport && csvExport ? (
+ <ExportCsvItem csvExport={csvExport} />
) : null}
{importCSV?.map(({ table, label }) => (
<DropdownMenuItem key={table} onClick={() => setImportTable(table)}>
@@ -221,3 +208,20 @@ export function CompactToolbar({
</>
);
}
+
+/**
+ * Export CSV, mounted only when there is something to export. Its hook reads
+ * the signed-in company's items, suppliers, people and customers to name the
+ * ids in the file, and a signed-out page — a customer portal — has no company
+ * to read: called unconditionally, it threw "useUser must be used within an
+ * authenticated route" and the page answered 500.
+ */
+function ExportCsvItem({ csvExport }: { csvExport: DownloadProps }) {
+ const exportCsv = useCsvDownload(csvExport);
+ return (
+ <DropdownMenuItem onClick={exportCsv}>
+ <DropdownMenuIcon icon={<LuDownload />} />
+ <Trans>Export CSV</Trans>
+ </DropdownMenuItem>
+ );
+}
diff --git a/apps/erp/app/routes/share+/customer.$id.tsx b/apps/erp/app/routes/share+/customer.$id.tsx
index 5ceb2a06df..1768be4a0a 100644
--- a/apps/erp/app/routes/share+/customer.$id.tsx
+++ b/apps/erp/app/routes/share+/customer.$id.tsx
@@ -391,6 +391,9 @@ export default function CustomerPortal() {
columns={columns}
count={count ?? 0}
compact
+ // Signed out: the export names ids from the signed-in company's
+ // lists, and there is no company here to read them from.
+ withCsvExport={false}
defaultColumnPinning={defaultColumnPinning}
sort={<PortalSort columns={sortableColumns} />}
/>