Skip to content

Open-source manufacturing ERP, MES and QMS. Quoting, MRP, inventory, shop floor, quality and lot/serial traceability on one Postgres schema, with a REST API and MCP server. Self-host or use Carbon Cloud.

feat(settings): edit printers from Settings → Printing (#2081)

Brad Barbin9be412f8cb00
diff --git a/apps/erp/app/modules/settings/ui/Printing/PrintersCard.tsx b/apps/erp/app/modules/settings/ui/Printing/PrintersCard.tsx
index 137a3dab59..a57b4dccdc 100644
--- a/apps/erp/app/modules/settings/ui/Printing/PrintersCard.tsx
+++ b/apps/erp/app/modules/settings/ui/Printing/PrintersCard.tsx
@@ -34,7 +34,13 @@ import {
import { getLabelSizeLabel, labelSizes } from "@carbon/utils";
import { Trans, useLingui } from "@lingui/react/macro";
import { useMemo, useState } from "react";
-import { LuEllipsisVertical, LuPlay, LuPlus, LuTrash } from "react-icons/lu";
+import {
+ LuEllipsisVertical,
+ LuPencil,
+ LuPlay,
+ LuPlus,
+ LuTrash
+} from "react-icons/lu";
import { Empty } from "~/components";
import ConfirmDelete from "~/components/Modals/ConfirmDelete";
import { path } from "~/utils/path";
@@ -50,7 +56,9 @@ export function PrintersCard({
printerRoutes: PrinterRoute[];
}) {
const { t } = useLingui();
- const newPrinterDisclosure = useDisclosure();
+ const printerDisclosure = useDisclosure();
+ // The printer being edited; null while adding a new one.
+ const [printerToEdit, setPrinterToEdit] = useState<PrinterRoute | null>(null);
const routeFetcher = useAction({
onSuccess: ({ data }) => {
if (!data) return;
@@ -58,7 +66,7 @@ export function PrintersCard({
toast.success(
data.created ? t`Printer route created` : t`Printer route updated`
);
- newPrinterDisclosure.onClose();
+ printerDisclosure.onClose();
} else {
toast.success(t`Test label sent to printer`);
}
@@ -102,8 +110,9 @@ export function PrintersCard({
<Button
leftIcon={<LuPlus />}
onClick={() => {
+ setPrinterToEdit(null);
setSelectedFormat("zpl");
- newPrinterDisclosure.onOpen();
+ printerDisclosure.onOpen();
}}
>
<Trans>Add Printer</Trans>
@@ -142,6 +151,17 @@ export function PrintersCard({
/>
</DropdownMenuTrigger>
<DropdownMenuContent align="end">
+ <DropdownMenuItem
+ shortcut={MENU_ITEM_SHORTCUTS.edit}
+ onSelect={() => {
+ setPrinterToEdit(route);
+ setSelectedFormat(route.format);
+ printerDisclosure.onOpen();
+ }}
+ >
+ <DropdownMenuIcon icon={<LuPencil />} />
+ <Trans>Edit</Trans>
+ </DropdownMenuItem>
<DropdownMenuItem
onSelect={() =>
routeFetcher.submit(
@@ -184,11 +204,11 @@ export function PrintersCard({
</CardContent>
</Card>
- {newPrinterDisclosure.isOpen && (
+ {printerDisclosure.isOpen && (
<Modal
open
onOpenChange={(open) => {
- if (!open) newPrinterDisclosure.onClose();
+ if (!open) printerDisclosure.onClose();
}}
>
<ModalContent size="large">
@@ -196,13 +216,40 @@ export function PrintersCard({
method="post"
validator={printerRouteValidator}
fetcher={routeFetcher}
- defaultValues={{ format: "zpl" }}
+ defaultValues={
+ printerToEdit
+ ? {
+ id: printerToEdit.id,
+ locationId: printerToEdit.locationId ?? undefined,
+ name: printerToEdit.name,
+ format: printerToEdit.format,
+ mediaSizeId: printerToEdit.mediaSizeId ?? undefined,
+ printerUrl: printerToEdit.printerUrl,
+ apiKey: printerToEdit.apiKey ?? undefined,
+ templateId: printerToEdit.templateId ?? undefined
+ }
+ : { format: "zpl" }
+ }
className="flex flex-col h-full"
>
<input type="hidden" name="intent" value="upsertRoute" />
+ {printerToEdit && (
+ <>
+ <input type="hidden" name="id" value={printerToEdit.id} />
+ <input
+ type="hidden"
+ name="locationId"
+ value={printerToEdit.locationId ?? ""}
+ />
+ </>
+ )}
<ModalHeader>
<ModalTitle>
- <Trans>Add Printer</Trans>
+ {printerToEdit ? (
+ <Trans>Edit Printer</Trans>
+ ) : (
+ <Trans>Add Printer</Trans>
+ )}
</ModalTitle>
</ModalHeader>
<ModalBody>
@@ -256,12 +303,16 @@ export function PrintersCard({
<Button
size="md"
variant="solid"
- onClick={newPrinterDisclosure.onClose}
+ onClick={printerDisclosure.onClose}
>
<Trans>Cancel</Trans>
</Button>
<Submit>
- <Trans>Add Printer</Trans>
+ {printerToEdit ? (
+ <Trans>Save</Trans>
+ ) : (
+ <Trans>Add Printer</Trans>
+ )}
</Submit>
</HStack>
</ModalFooter>
diff --git a/packages/locale/locales/de/erp.po b/packages/locale/locales/de/erp.po
index 947a827b0c..2eef47f058 100644
--- a/packages/locale/locales/de/erp.po
+++ b/packages/locale/locales/de/erp.po
@@ -9142,6 +9142,9 @@ msgstr "Preisfindung bearbeiten"
msgid "Edit Pricing Rule"
msgstr "Preisregel bearbeiten"
+msgid "Edit Printer"
+msgstr "Drucker bearbeiten"
+
msgid "Edit Process"
msgstr "Prozess bearbeiten"
diff --git a/packages/locale/locales/en/erp.po b/packages/locale/locales/en/erp.po
index 45285912d8..27f483b57d 100644
--- a/packages/locale/locales/en/erp.po
+++ b/packages/locale/locales/en/erp.po
@@ -9142,6 +9142,9 @@ msgstr "Edit Pricing"
msgid "Edit Pricing Rule"
msgstr "Edit Pricing Rule"
+msgid "Edit Printer"
+msgstr "Edit Printer"
+
msgid "Edit Process"
msgstr "Edit Process"
diff --git a/packages/locale/locales/es/erp.po b/packages/locale/locales/es/erp.po
index 03389d7ee0..b242ed1839 100644
--- a/packages/locale/locales/es/erp.po
+++ b/packages/locale/locales/es/erp.po
@@ -9142,6 +9142,9 @@ msgstr "Editar Fijación de precios"
msgid "Edit Pricing Rule"
msgstr "Editar Regla de Precios"
+msgid "Edit Printer"
+msgstr "Editar Impresora"
+
msgid "Edit Process"
msgstr "Editar Proceso"
diff --git a/packages/locale/locales/fr/erp.po b/packages/locale/locales/fr/erp.po
index 3d7deee9c6..1f53fd24fb 100644
--- a/packages/locale/locales/fr/erp.po
+++ b/packages/locale/locales/fr/erp.po
@@ -9142,6 +9142,9 @@ msgstr "Modifier la tarification"
msgid "Edit Pricing Rule"
msgstr "Modifier la règle de tarification"
+msgid "Edit Printer"
+msgstr "Modifier l'imprimante"
+
msgid "Edit Process"
msgstr "Modifier le processus"
diff --git a/packages/locale/locales/hi/erp.po b/packages/locale/locales/hi/erp.po
index ca3d2d2877..ca386d1813 100644
--- a/packages/locale/locales/hi/erp.po
+++ b/packages/locale/locales/hi/erp.po
@@ -9142,6 +9142,9 @@ msgstr "मूल्य निर्धारण संपादित करे
msgid "Edit Pricing Rule"
msgstr "मूल्य निर्धारण नियम संपादित करें"
+msgid "Edit Printer"
+msgstr "प्रिंटर संपादित करें"
+
msgid "Edit Process"
msgstr "प्रक्रिया संपादित करें"
diff --git a/packages/locale/locales/it/erp.po b/packages/locale/locales/it/erp.po
index 09fa8870e8..217cd2d1ee 100644
--- a/packages/locale/locales/it/erp.po
+++ b/packages/locale/locales/it/erp.po
@@ -9142,6 +9142,9 @@ msgstr "Modifica Determinazione dei prezzi"
msgid "Edit Pricing Rule"
msgstr "Modifica Regola di Prezzo"
+msgid "Edit Printer"
+msgstr "Modifica Stampante"
+
msgid "Edit Process"
msgstr "Modifica Processo"
diff --git a/packages/locale/locales/ja/erp.po b/packages/locale/locales/ja/erp.po
index 430be1e51f..d191f4cc08 100644
--- a/packages/locale/locales/ja/erp.po
+++ b/packages/locale/locales/ja/erp.po
@@ -9142,6 +9142,9 @@ msgstr "価格設定を編集"
msgid "Edit Pricing Rule"
msgstr "価格設定ルールを編集"
+msgid "Edit Printer"
+msgstr "プリンターを編集"
+
msgid "Edit Process"
msgstr "プロセスを編集"
diff --git a/packages/locale/locales/ko/erp.po b/packages/locale/locales/ko/erp.po
index 96cdc66338..87b534c431 100644
--- a/packages/locale/locales/ko/erp.po
+++ b/packages/locale/locales/ko/erp.po
@@ -9142,6 +9142,9 @@ msgstr "가격 책정 편집"
msgid "Edit Pricing Rule"
msgstr "가격 규칙 편집"
+msgid "Edit Printer"
+msgstr "프린터 편집"
+
msgid "Edit Process"
msgstr "공법 편집"
diff --git a/packages/locale/locales/pl/erp.po b/packages/locale/locales/pl/erp.po
index 0242ef3be9..0b760c6e6a 100644
--- a/packages/locale/locales/pl/erp.po
+++ b/packages/locale/locales/pl/erp.po
@@ -9142,6 +9142,9 @@ msgstr "Edytuj ustalanie cen"
msgid "Edit Pricing Rule"
msgstr "Edytuj regułę cenową"
+msgid "Edit Printer"
+msgstr "Edytuj drukarkę"
+
msgid "Edit Process"
msgstr "Edytuj proces"
diff --git a/packages/locale/locales/pt/erp.po b/packages/locale/locales/pt/erp.po
index ed0deabb60..963dff0788 100644
--- a/packages/locale/locales/pt/erp.po
+++ b/packages/locale/locales/pt/erp.po
@@ -9142,6 +9142,9 @@ msgstr "Editar Precificação"
msgid "Edit Pricing Rule"
msgstr "Editar Regra de precificação"
+msgid "Edit Printer"
+msgstr "Editar Impressora"
+
msgid "Edit Process"
msgstr "Editar Processo"
diff --git a/packages/locale/locales/ru/erp.po b/packages/locale/locales/ru/erp.po
index 508f270a85..d0c7ffd5d3 100644
--- a/packages/locale/locales/ru/erp.po
+++ b/packages/locale/locales/ru/erp.po
@@ -9142,6 +9142,9 @@ msgstr "Изменить Ценообразование"
msgid "Edit Pricing Rule"
msgstr "Изменить Правило ценообразования"
+msgid "Edit Printer"
+msgstr "Изменить Принтер"
+
msgid "Edit Process"
msgstr "Изменить Процесс"
diff --git a/packages/locale/locales/tr/erp.po b/packages/locale/locales/tr/erp.po
index 4254239698..c84359d88b 100644
--- a/packages/locale/locales/tr/erp.po
+++ b/packages/locale/locales/tr/erp.po
@@ -9142,6 +9142,9 @@ msgstr "Fiyatlandırmayı Düzenle"
msgid "Edit Pricing Rule"
msgstr "Fiyatlandırma Kuralını Düzenle"
+msgid "Edit Printer"
+msgstr "Yazıcıyı Düzenle"
+
msgid "Edit Process"
msgstr "İşlemi Düzenle"
diff --git a/packages/locale/locales/zh/erp.po b/packages/locale/locales/zh/erp.po
index a5bd1a1a3e..f1aa5fb2fb 100644
--- a/packages/locale/locales/zh/erp.po
+++ b/packages/locale/locales/zh/erp.po
@@ -9142,6 +9142,9 @@ msgstr "编辑定价"
msgid "Edit Pricing Rule"
msgstr "编辑定价规则"
+msgid "Edit Printer"
+msgstr "编辑打印机"
+
msgid "Edit Process"
msgstr "编辑流程"