Skip to content

Open-source manufacturing ERP, MES and QMS. Quoting, MRP, inventory, shop floor, quality and lot/serial traceability on one Postgres schema, with a REST API and MCP server. Self-host or use Carbon Cloud.

fix(items): write normalized material ids on create; require create for new sizes

Raulcbc88e3eff5a
diff --git a/apps/erp/app/modules/items/items.service.ts b/apps/erp/app/modules/items/items.service.ts
index e945842881..ebea16d5da 100644
--- a/apps/erp/app/modules/items/items.service.ts
+++ b/apps/erp/app/modules/items/items.service.ts
@@ -5435,12 +5435,7 @@ export async function upsertMaterial(
const materialInsert = await client.from("material").upsert({
id: readableId,
- materialFormId: material.materialFormId,
- materialSubstanceId: material.materialSubstanceId,
- finishId: material.finishId,
- gradeId: material.gradeId,
- dimensionId: material.dimensionId,
- materialTypeId: material.materialTypeId,
+ ...plan.data.next,
companyId: material.companyId,
createdBy: material.createdBy,
customFields: material.customFields
diff --git a/apps/erp/app/routes/x+/material+/$itemId.details.tsx b/apps/erp/app/routes/x+/material+/$itemId.details.tsx
index b7bab3d637..109c12902d 100644
--- a/apps/erp/app/routes/x+/material+/$itemId.details.tsx
+++ b/apps/erp/app/routes/x+/material+/$itemId.details.tsx
@@ -35,6 +35,11 @@ export async function action({ request, params }: ActionFunctionArgs) {
return validationError(validation.error);
}
+ // A new size is a new item revision, so it also needs create.
+ if (validation.data.sizes?.length) {
+ await requirePermissions(request, { create: "parts" });
+ }
+
const updateMaterial = await upsertMaterial(client, getDatabaseClient(), {
...validation.data,
id: itemId,