Database diagrams editor that allows you to visualize and design your DB with a single query.
TypeScript databasedbdb-migrationeditorerdmariadbmssqlmysqlpostgresqlreactreact-flowschema-migrationssqlsqlitetypescriptvisualizationxyflow
fix: DBML export error with multi-line table comments for SQL Server (#852)
Jonathan Fishner0545b411407b
diff --git a/src/lib/data/export-metadata/export-sql-script.ts b/src/lib/data/export-metadata/export-sql-script.tsindex c18403fa..d5292af0 100644--- a/src/lib/data/export-metadata/export-sql-script.ts+++ b/src/lib/data/export-metadata/export-sql-script.ts@@ -1,6 +1,9 @@import type { Diagram } from '../../domain/diagram';import { OPENAI_API_KEY, OPENAI_API_ENDPOINT, LLM_MODEL_NAME } from '@/lib/env';-import { DatabaseType } from '@/lib/domain/database-type';+import {+ DatabaseType,+ databaseTypesWithCommentSupport,+} from '@/lib/domain/database-type';import type { DBTable } from '@/lib/domain/db-table';import type { DataType } from '../data-types/data-types';import { generateCacheKey, getFromCache, setInCache } from './export-sql-cache';@@ -8,6 +11,7 @@ import { exportMSSQL } from './export-per-type/mssql';import { exportPostgreSQL } from './export-per-type/postgresql';import { exportSQLite } from './export-per-type/sqlite';import { exportMySQL } from './export-per-type/mysql';+import { escapeSQLComment } from './export-per-type/common';// Function to simplify verbose data type namesconst simplifyDataType = (typeName: string): string => {@@ -323,15 +327,18 @@ export const exportBaseSQL = ({sqlScript += '\n);\n';- // Add table comment- if (table.comments) {- sqlScript += `COMMENT ON TABLE ${tableName} IS '${table.comments.replace(/'/g, "''")}';\n`;+ // Add table comment (only for databases that support COMMENT ON syntax)+ const supportsCommentOn =+ databaseTypesWithCommentSupport.includes(targetDatabaseType);++ if (table.comments && supportsCommentOn) {+ sqlScript += `COMMENT ON TABLE ${tableName} IS '${escapeSQLComment(table.comments)}';\n`;}table.fields.forEach((field) => {- // Add column comment- if (field.comments) {- sqlScript += `COMMENT ON COLUMN ${tableName}.${field.name} IS '${field.comments.replace(/'/g, "''")}';\n`;+ // Add column comment (only for databases that support COMMENT ON syntax)+ if (field.comments && supportsCommentOn) {+ sqlScript += `COMMENT ON COLUMN ${tableName}.${field.name} IS '${escapeSQLComment(field.comments)}';\n`;}});diff --git a/src/lib/domain/database-type.ts b/src/lib/domain/database-type.tsindex 5168cdfe..426cd6da 100644--- a/src/lib/domain/database-type.ts+++ b/src/lib/domain/database-type.ts@@ -9,3 +9,9 @@ export enum DatabaseType {COCKROACHDB = 'cockroachdb',ORACLE = 'oracle',}++export const databaseTypesWithCommentSupport: DatabaseType[] = [+ DatabaseType.POSTGRESQL,+ DatabaseType.COCKROACHDB,+ DatabaseType.ORACLE,+];