Skip to content

Database diagrams editor that allows you to visualize and design your DB with a single query.

fix(performance): Optimize performance of field comments editing (#610)

Guy Ben-Aharon5dd7fe75d1b0
diff --git a/src/pages/editor-page/side-panel/tables-section/table-list/table-list-item/table-list-item-content/table-field/table-field.tsx b/src/pages/editor-page/side-panel/tables-section/table-list/table-list-item/table-list-item-content/table-field/table-field.tsx
index 40082971..187c540c 100644
--- a/src/pages/editor-page/side-panel/tables-section/table-list/table-list-item/table-list-item-content/table-field/table-field.tsx
+++ b/src/pages/editor-page/side-panel/tables-section/table-list/table-list-item/table-list-item-content/table-field/table-field.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+import React, { useEffect, useRef } from 'react';
import { Ellipsis, GripVertical, Trash2, KeyRound } from 'lucide-react';
import { Input } from '@/components/input/input';
import { Button } from '@/components/button/button';
@@ -25,6 +25,7 @@ import { TableFieldToggle } from './table-field-toggle';
import { useSortable } from '@dnd-kit/sortable';
import { CSS } from '@dnd-kit/utilities';
import { SelectBox } from '@/components/select-box/select-box';
+import { debounce } from '@/lib/utils';
export interface TableFieldProps {
field: DBField;
@@ -39,6 +40,7 @@ export const TableField: React.FC<TableFieldProps> = ({
}) => {
const { databaseType } = useChartDB();
const { t } = useTranslation();
+ const [comments, setComments] = React.useState(field.comments);
const { attributes, listeners, setNodeRef, transform, transition } =
useSortable({ id: field.id });
@@ -52,6 +54,28 @@ export const TableField: React.FC<TableFieldProps> = ({
transition,
};
+ const debouncedUpdateCommentRef = useRef<((value?: string) => void) | null>(
+ null
+ );
+
+ useEffect(() => {
+ debouncedUpdateCommentRef.current = debounce((value?: string) => {
+ updateField({
+ comments: value,
+ });
+ }, 500);
+
+ return () => {
+ debouncedUpdateCommentRef.current = null;
+ };
+ }, [updateField]);
+
+ useEffect(() => {
+ if (debouncedUpdateCommentRef.current) {
+ debouncedUpdateCommentRef.current(comments);
+ }
+ }, [comments]);
+
return (
<div
className="flex flex-1 touch-none flex-row justify-between p-1"
@@ -199,11 +223,9 @@ export const TableField: React.FC<TableFieldProps> = ({
)}
</Label>
<Textarea
- value={field.comments}
+ value={comments}
onChange={(e) =>
- updateField({
- comments: e.target.value,
- })
+ setComments(e.target.value)
}
placeholder={t(
'side_panel.tables_section.table.field_actions.no_comments'