Skip to content

Database diagrams editor that allows you to visualize and design your DB with a single query.

fix for import script escaping for sql server

johnnyfish7e9d9ececf37
diff --git a/src/lib/data/export-metadata/export-sql-script.ts b/src/lib/data/export-metadata/export-sql-script.ts
index a02622af..0beb09c5 100644
--- a/src/lib/data/export-metadata/export-sql-script.ts
+++ b/src/lib/data/export-metadata/export-sql-script.ts
@@ -200,7 +200,7 @@ const generateSQLPrompt = (databaseType: DatabaseType, sqlScript: string) => {
You are generating SQL scripts for creating database tables and sequences, handling primary keys, indices, and other table attributes.
The following instructions will guide you in optimizing the scripts for the ${databaseType} dialect:
- **Column Names**: Do **not** modify the names of columns. Ensure that all column names in the generated SQL script are exactly as provided in the input schema. If the input specifies a column name, it must appear in the output script unchanged.
- - **Column Name Conflicts**: When a column name conflicts with a data type or reserved keyword (e.g., fulltext), escape the column name by enclosing it.
+ - **Column Name Conflicts**: When a column name conflicts with a data type or reserved keyword (e.g., fulltext, Primary, Column), escape the column name by enclosing it.
`;
const dialectInstructionMap: Record<DatabaseType, string> = {
@@ -231,6 +231,8 @@ const generateSQLPrompt = (databaseType: DatabaseType, sqlScript: string) => {
- **Identity Columns**: Always prefer using the \`IDENTITY\` keyword (e.g., \`INT IDENTITY(1,1)\`) for auto-incrementing primary key columns when possible.
- **Conditional Logic**: Use a conditional block like \`IF NOT EXISTS (SELECT * FROM sys.objects WHERE ...)\` since SQL Server doesn’t support \`IF NOT EXISTS\` directly in \`CREATE\` statements.
- **Avoid Unsupported Syntax**: Ensure the script does not include unsupported statements like \`CREATE TABLE IF NOT EXISTS\`.
+
+ **Reminder**: Ensure all column names that conflict with reserved keywords or data types (e.g., primary, column, table), escape the column name by enclosing it.
`,
mariadb: `
- **Table Creation**: Use \`CREATE TABLE IF NOT EXISTS\` for creating tables. While creating the table structure, ensure that all foreign key columns use the correct data types as determined in the foreign key review.
diff --git a/src/lib/data/import-metadata/scripts/sqlserver-script.ts b/src/lib/data/import-metadata/scripts/sqlserver-script.ts
index 16783f5c..a1ac173b 100644
--- a/src/lib/data/import-metadata/scripts/sqlserver-script.ts
+++ b/src/lib/data/import-metadata/scripts/sqlserver-script.ts
@@ -3,17 +3,17 @@ export const sqlServerQuery = `WITH fk_info AS (
JSON_QUERY(
'[' + STRING_AGG(
CONVERT(nvarchar(max),
- JSON_QUERY(N'{"schema": "' + kcu.CONSTRAINT_SCHEMA COLLATE SQL_Latin1_General_CP1_CI_AS +
- '", "table": "' + kcu.TABLE_NAME COLLATE SQL_Latin1_General_CP1_CI_AS +
- '", "column": "' + kcu.COLUMN_NAME COLLATE SQL_Latin1_General_CP1_CI_AS +
- '", "foreign_key_name": "' + kcu.CONSTRAINT_NAME COLLATE SQL_Latin1_General_CP1_CI_AS +
- '", "reference_table": "' + rcu.TABLE_NAME COLLATE SQL_Latin1_General_CP1_CI_AS +
- '", "reference_column": "' + rcu.COLUMN_NAME COLLATE SQL_Latin1_General_CP1_CI_AS +
- '", "fk_def": "FOREIGN KEY (' + kcu.COLUMN_NAME COLLATE SQL_Latin1_General_CP1_CI_AS +
- ') REFERENCES ' + rcu.TABLE_NAME COLLATE SQL_Latin1_General_CP1_CI_AS +
- '(' + rcu.COLUMN_NAME COLLATE SQL_Latin1_General_CP1_CI_AS +
- ') ON DELETE ' + rc.DELETE_RULE COLLATE SQL_Latin1_General_CP1_CI_AS +
- ' ON UPDATE ' + rc.UPDATE_RULE COLLATE SQL_Latin1_General_CP1_CI_AS + '"}')
+ JSON_QUERY(N'{"schema": "' + COALESCE(REPLACE(kcu.CONSTRAINT_SCHEMA, '"', ''), '') COLLATE SQL_Latin1_General_CP1_CI_AS +
+ '", "table": "' + COALESCE(REPLACE(kcu.TABLE_NAME, '"', ''), '') COLLATE SQL_Latin1_General_CP1_CI_AS +
+ '", "column": "' + COALESCE(REPLACE(kcu.COLUMN_NAME, '"', ''), '') COLLATE SQL_Latin1_General_CP1_CI_AS +
+ '", "foreign_key_name": "' + COALESCE(REPLACE(kcu.CONSTRAINT_NAME, '"', ''), '') COLLATE SQL_Latin1_General_CP1_CI_AS +
+ '", "reference_table": "' + COALESCE(REPLACE(rcu.TABLE_NAME, '"', ''), '') COLLATE SQL_Latin1_General_CP1_CI_AS +
+ '", "reference_column": "' + COALESCE(REPLACE(rcu.COLUMN_NAME, '"', ''), '') COLLATE SQL_Latin1_General_CP1_CI_AS +
+ '", "fk_def": "FOREIGN KEY (' + COALESCE(REPLACE(kcu.COLUMN_NAME, '"', ''), '') COLLATE SQL_Latin1_General_CP1_CI_AS +
+ ') REFERENCES ' + COALESCE(REPLACE(rcu.TABLE_NAME, '"', ''), '') COLLATE SQL_Latin1_General_CP1_CI_AS +
+ '(' + COALESCE(REPLACE(rcu.COLUMN_NAME, '"', ''), '') COLLATE SQL_Latin1_General_CP1_CI_AS +
+ ') ON DELETE ' + rc.DELETE_RULE COLLATE SQL_Latin1_General_CP1_CI_AS +
+ ' ON UPDATE ' + rc.UPDATE_RULE COLLATE SQL_Latin1_General_CP1_CI_AS + '"}')
), ','
) + N']'
) AS all_fks_json
@@ -28,47 +28,47 @@ export const sqlServerQuery = `WITH fk_info AS (
ON rcu.CONSTRAINT_NAME = rc.UNIQUE_CONSTRAINT_NAME
AND rcu.CONSTRAINT_SCHEMA = rc.UNIQUE_CONSTRAINT_SCHEMA
AND rcu.ORDINAL_POSITION = kcu.ORDINAL_POSITION
-),
-pk_info AS (
+), pk_info AS (
SELECT
JSON_QUERY(
'[' + STRING_AGG(
CONVERT(nvarchar(max),
- JSON_QUERY(N'{"schema": "' + pk.TABLE_SCHEMA COLLATE SQL_Latin1_General_CP1_CI_AS +
- '", "table": "' + pk.TABLE_NAME COLLATE SQL_Latin1_General_CP1_CI_AS +
- '", "column": "' + pk.COLUMN_NAME COLLATE SQL_Latin1_General_CP1_CI_AS +
- '", "pk_def": "PRIMARY KEY (' + pk.COLUMN_NAME COLLATE SQL_Latin1_General_CP1_CI_AS + ')"}')
+ JSON_QUERY(N'{"schema": "' + COALESCE(REPLACE(pk.TABLE_SCHEMA, '"', ''), '') COLLATE SQL_Latin1_General_CP1_CI_AS +
+ '", "table": "' + COALESCE(REPLACE(pk.TABLE_NAME, '"', ''), '') COLLATE SQL_Latin1_General_CP1_CI_AS +
+ '", "column": "' + COALESCE(REPLACE(pk.COLUMN_NAME, '"', ''), '') COLLATE SQL_Latin1_General_CP1_CI_AS +
+ '", "pk_def": "PRIMARY KEY (' + pk.COLUMN_NAME COLLATE SQL_Latin1_General_CP1_CI_AS + ')"}')
), ','
) + N']'
) AS all_pks_json
- FROM (
- SELECT
- kcu.TABLE_SCHEMA,
- kcu.TABLE_NAME,
- kcu.COLUMN_NAME
- FROM
- INFORMATION_SCHEMA.KEY_COLUMN_USAGE kcu
- JOIN
- INFORMATION_SCHEMA.TABLE_CONSTRAINTS tc
- ON kcu.CONSTRAINT_NAME = tc.CONSTRAINT_NAME
- AND kcu.CONSTRAINT_SCHEMA = tc.CONSTRAINT_SCHEMA
- WHERE
- tc.CONSTRAINT_TYPE = 'PRIMARY KEY'
- ) pk
+ FROM
+ (
+ SELECT
+ kcu.TABLE_SCHEMA,
+ kcu.TABLE_NAME,
+ kcu.COLUMN_NAME
+ FROM
+ INFORMATION_SCHEMA.KEY_COLUMN_USAGE kcu
+ JOIN
+ INFORMATION_SCHEMA.TABLE_CONSTRAINTS tc
+ ON kcu.CONSTRAINT_NAME = tc.CONSTRAINT_NAME
+ AND kcu.CONSTRAINT_SCHEMA = tc.CONSTRAINT_SCHEMA
+ WHERE
+ tc.CONSTRAINT_TYPE = 'PRIMARY KEY'
+ ) pk
),
cols AS (
SELECT
JSON_QUERY(
'[' + STRING_AGG(
CONVERT(nvarchar(max),
- JSON_QUERY('{"schema": "' + cols.TABLE_SCHEMA +
- '", "table": "' + cols.TABLE_NAME +
- '", "name": "' + cols.COLUMN_NAME +
- '", "ordinal_position": "' + CAST(cols.ORDINAL_POSITION AS NVARCHAR(MAX)) +
- '", "type": "' + LOWER(cols.DATA_TYPE) +
- '", "character_maximum_length": "' +
+ JSON_QUERY('{"schema": "' + COALESCE(REPLACE(cols.TABLE_SCHEMA, '"', ''), '') +
+ '", "table": "' + COALESCE(REPLACE(cols.TABLE_NAME, '"', ''), '') +
+ '", "name": "' + COALESCE(REPLACE(cols.COLUMN_NAME, '"', ''), '') +
+ '", "ordinal_position": "' + CAST(cols.ORDINAL_POSITION AS NVARCHAR(MAX)) +
+ '", "type": "' + LOWER(cols.DATA_TYPE) +
+ '", "character_maximum_length": "' +
COALESCE(CAST(cols.CHARACTER_MAXIMUM_LENGTH AS NVARCHAR(MAX)), 'null') +
- '", "precision": ' +
+ '", "precision": ' +
CASE
WHEN cols.DATA_TYPE IN ('numeric', 'decimal') THEN
CONCAT('{"precision":', COALESCE(CAST(cols.NUMERIC_PRECISION AS NVARCHAR(MAX)), 'null'),
@@ -76,13 +76,13 @@ cols AS (
ELSE
'null'
END +
- ', "nullable": "' +
+ ', "nullable": "' +
CASE WHEN cols.IS_NULLABLE = 'YES' THEN 'true' ELSE 'false' END +
- '", "default": "' +
+ '", "default": "' +
COALESCE(REPLACE(CAST(cols.COLUMN_DEFAULT AS NVARCHAR(MAX)), '"', '\\"'), '') +
- '", "collation": "' +
+ '", "collation": "' +
COALESCE(cols.COLLATION_NAME, '') +
- '"}')
+ '"}')
), ','
) + ']'
) AS all_columns_json
@@ -95,15 +95,15 @@ indexes AS (
SELECT
'[' + STRING_AGG(
CONVERT(nvarchar(max),
- JSON_QUERY(
- N'{"schema": "' + s.name COLLATE SQL_Latin1_General_CP1_CI_AS +
- '", "table": "' + t.name COLLATE SQL_Latin1_General_CP1_CI_AS +
- '", "index_name": "' + i.name COLLATE SQL_Latin1_General_CP1_CI_AS +
- '", "column_name": "' + c.name COLLATE SQL_Latin1_General_CP1_CI_AS +
- '", "index_type": "' + LOWER(i.type_desc) COLLATE SQL_Latin1_General_CP1_CI_AS +
- '", "is_unique": ' + CASE WHEN i.is_unique = 1 THEN 'true' ELSE 'false' END +
- ', "direction": "' + CASE WHEN ic.is_descending_key = 1 THEN 'desc' ELSE 'asc' END COLLATE SQL_Latin1_General_CP1_CI_AS + '"}'
- )
+ JSON_QUERY(
+ N'{"schema": "' + COALESCE(REPLACE(s.name, '"', ''), '') COLLATE SQL_Latin1_General_CP1_CI_AS +
+ '", "table": "' + COALESCE(REPLACE(t.name, '"', ''), '') COLLATE SQL_Latin1_General_CP1_CI_AS +
+ '", "index_name": "' + COALESCE(REPLACE(i.name, '"', ''), '') COLLATE SQL_Latin1_General_CP1_CI_AS +
+ '", "column_name": "' + COALESCE(REPLACE(c.name, '"', ''), '') COLLATE SQL_Latin1_General_CP1_CI_AS +
+ '", "index_type": "' + LOWER(i.type_desc) COLLATE SQL_Latin1_General_CP1_CI_AS +
+ '", "is_unique": ' + CASE WHEN i.is_unique = 1 THEN 'true' ELSE 'false' END +
+ ', "direction": "' + CASE WHEN ic.is_descending_key = 1 THEN 'desc' ELSE 'asc' END COLLATE SQL_Latin1_General_CP1_CI_AS + '"}'
+ )
), ','
) + N']' AS all_indexes_json
FROM
@@ -124,42 +124,43 @@ tbls AS (
SELECT
'[' + STRING_AGG(
CONVERT(nvarchar(max),
- JSON_QUERY(
- N'{"schema": "' + aggregated.schema_name COLLATE SQL_Latin1_General_CP1_CI_AS +
- '", "table": "' + aggregated.table_name COLLATE SQL_Latin1_General_CP1_CI_AS +
- '", "row_count": "' + CAST(aggregated.row_count AS NVARCHAR(MAX)) +
- '", "table_type": "' + aggregated.table_type COLLATE SQL_Latin1_General_CP1_CI_AS +
- '", "creation_date": "' + CONVERT(NVARCHAR(MAX), aggregated.creation_date, 120) + '"}'
- )
+ JSON_QUERY(
+ N'{"schema": "' + COALESCE(REPLACE(aggregated.schema_name, '"', ''), '') COLLATE SQL_Latin1_General_CP1_CI_AS +
+ '", "table": "' + COALESCE(REPLACE(aggregated.table_name, '"', ''), '') COLLATE SQL_Latin1_General_CP1_CI_AS +
+ '", "row_count": "' + CAST(aggregated.row_count AS NVARCHAR(MAX)) +
+ '", "table_type": "' + aggregated.table_type COLLATE SQL_Latin1_General_CP1_CI_AS +
+ '", "creation_date": "' + CONVERT(NVARCHAR(MAX), aggregated.creation_date, 120) + '"}'
+ )
), ','
) + N']' AS all_tables_json
- FROM (
- SELECT
- s.name AS schema_name,
- t.name AS table_name,
- SUM(p.rows) AS row_count,
- t.type_desc AS table_type,
- t.create_date AS creation_date
- FROM
- sys.tables t
- JOIN
- sys.schemas s ON t.schema_id = s.schema_id
- JOIN
- sys.partitions p ON t.object_id = p.object_id AND p.index_id IN (0, 1)
- WHERE
- s.name LIKE '%'
- GROUP BY
- s.name, t.name, t.type_desc, t.create_date
- ) AS aggregated
+ FROM
+ (
+ SELECT
+ COALESCE(REPLACE(s.name, '"', ''), '') AS schema_name,
+ COALESCE(REPLACE(t.name, '"', ''), '') AS table_name,
+ SUM(p.rows) AS row_count,
+ t.type_desc AS table_type,
+ t.create_date AS creation_date
+ FROM
+ sys.tables t
+ JOIN
+ sys.schemas s ON t.schema_id = s.schema_id
+ JOIN
+ sys.partitions p ON t.object_id = p.object_id AND p.index_id IN (0, 1)
+ WHERE
+ s.name LIKE '%'
+ GROUP BY
+ s.name, t.name, t.type_desc, t.create_date
+ ) AS aggregated
),
views AS (
SELECT
'[' + STRING_AGG(
CONVERT(nvarchar(max),
- JSON_QUERY(
- N'{"schema": "' + s.name COLLATE SQL_Latin1_General_CP1_CI_AS +
- '", "view_name": "' + v.name COLLATE SQL_Latin1_General_CP1_CI_AS + '"}'
- )
+ JSON_QUERY(
+ N'{"schema": "' + COALESCE(REPLACE(s.name, '"', ''), '') COLLATE SQL_Latin1_General_CP1_CI_AS +
+ '", "view_name": "' + COALESCE(REPLACE(v.name, '"', ''), '') COLLATE SQL_Latin1_General_CP1_CI_AS + '"}'
+ )
), ','
) + N']' AS all_views_json
FROM
@@ -170,14 +171,13 @@ views AS (
s.name LIKE '%'
)
SELECT JSON_QUERY(
- N'{"fk_info": ' + ISNULL((SELECT CAST(all_fks_json AS nvarchar(max)) FROM fk_info), N'[]') +
- ', "pk_info": ' + ISNULL((SELECT CAST(all_pks_json AS nvarchar(max)) FROM pk_info), N'[]') +
- ', "columns": ' + ISNULL((SELECT CAST(all_columns_json AS nvarchar(max)) FROM cols), N'[]') +
- ', "indexes": ' + ISNULL((SELECT CAST(all_indexes_json AS nvarchar(max)) FROM indexes), N'[]') +
- ', "tables": ' + ISNULL((SELECT CAST(all_tables_json AS nvarchar(max)) FROM tbls), N'[]') +
- ', "views": ' + ISNULL((SELECT CAST(all_views_json AS nvarchar(max)) FROM views), N'[]') +
- ', "database_name": "' + DB_NAME() + '"' +
- ', "version": ""}'
+ N'{"fk_info": ' + ISNULL((SELECT cast(all_fks_json as nvarchar(max)) FROM fk_info), N'[]') +
+ ', "pk_info": ' + ISNULL((SELECT cast(all_pks_json as nvarchar(max)) FROM pk_info), N'[]') +
+ ', "columns": ' + ISNULL((SELECT cast(all_columns_json as nvarchar(max)) FROM cols), N'[]') +
+ ', "indexes": ' + ISNULL((SELECT cast(all_indexes_json as nvarchar(max)) FROM indexes), N'[]') +
+ ', "tables": ' + ISNULL((SELECT cast(all_tables_json as nvarchar(max)) FROM tbls), N'[]') +
+ ', "views": ' + ISNULL((SELECT cast(all_views_json as nvarchar(max)) FROM views), N'[]') +
+ ', "database_name": "' + DB_NAME() + '"' +
+ ', "version": ""}'
) AS full_json_result;
-
`;