Database diagrams editor that allows you to visualize and design your DB with a single query.
TypeScript databasedbdb-migrationeditorerdmariadbmssqlmysqlpostgresqlreactreact-flowschema-migrationssqlsqlitetypescriptvisualizationxyflow
fix: resolve unresponsive cursor and input glitches when editing field comments (#749)
Guy Ben-Aharond15985e3999a
diff --git a/package-lock.json b/package-lock.jsonindex 57b15862..1101bc7a 100644--- a/package-lock.json+++ b/package-lock.json@@ -4888,9 +4888,9 @@}},"node_modules/caniuse-lite": {- "version": "1.0.30001696",- "resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001696.tgz",- "integrity": "sha512-pDCPkvzfa39ehJtJ+OwGT/2yvT2SbjfHhiIW2LWOAcMQ7BzwxT/XuyUp4OTOd0XFWA6BKw0JalnBHgSi5DGJBQ==",+ "version": "1.0.30001726",+ "resolved": "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001726.tgz",+ "integrity": "sha512-VQAUIUzBiZ/UnlM28fSp2CRF3ivUn1BWEvxMcVTNwpw91Py1pGbPIyIKtd+tzct9C3ouceCVdGAXxZOpZAsgdw==","dev": true,"funding": [{diff --git a/src/pages/editor-page/side-panel/tables-section/table-list/table-list-item/table-list-item-content/table-field/table-field-modal/table-field-modal.tsx b/src/pages/editor-page/side-panel/tables-section/table-list/table-list-item/table-list-item-content/table-field/table-field-modal/table-field-modal.tsxindex 84959e5e..3be50130 100644--- a/src/pages/editor-page/side-panel/tables-section/table-list/table-list-item/table-list-item-content/table-field/table-field-modal/table-field-modal.tsx+++ b/src/pages/editor-page/side-panel/tables-section/table-list/table-list-item/table-list-item-content/table-field/table-field-modal/table-field-modal.tsx@@ -1,4 +1,4 @@-import React, { useEffect, useRef } from 'react';+import React, { useEffect, useRef, useCallback } from 'react';import { Ellipsis, Trash2 } from 'lucide-react';import { Input } from '@/components/input/input';import { Button } from '@/components/button/button';@@ -14,7 +14,7 @@ import { Label } from '@/components/label/label';import { Checkbox } from '@/components/checkbox/checkbox';import { useTranslation } from 'react-i18next';import { Textarea } from '@/components/textarea/textarea';-import { debounce } from '@/lib/utils';+import { useDebounce } from '@/hooks/use-debounce';import equal from 'fast-deep-equal';export interface TableFieldPopoverProps {@@ -30,45 +30,40 @@ export const TableFieldPopover: React.FC<TableFieldPopoverProps> = ({}) => {const { t } = useTranslation();const [localField, setLocalField] = React.useState<DBField>(field);+ const [isOpen, setIsOpen] = React.useState(false);useEffect(() => {setLocalField(field);}, [field]);- const debouncedUpdateFieldRef = useRef<((value?: DBField) => void) | null>(- null+ const updateFieldStable = useCallback(+ (attrs: Partial<DBField>) => {+ updateField(attrs);+ },+ [updateField]);- useEffect(() => {- debouncedUpdateFieldRef.current = debounce((value?: DBField) => {- updateField({- comments: value?.comments,- characterMaximumLength: value?.characterMaximumLength,- unique: value?.unique,- });- }, 200);-- return () => {- debouncedUpdateFieldRef.current = null;- };- }, [updateField]);+ const debouncedUpdateField = useDebounce(updateFieldStable, 200);const prevFieldRef = useRef<DBField>(field);useEffect(() => {- if (- debouncedUpdateFieldRef.current &&- !equal(prevFieldRef.current, localField)- ) {- debouncedUpdateFieldRef.current(localField);+ if (isOpen && !equal(prevFieldRef.current, localField)) {+ debouncedUpdateField({+ comments: localField.comments,+ characterMaximumLength: localField.characterMaximumLength,+ unique: localField.unique,+ });}prevFieldRef.current = localField;- }, [localField]);+ }, [localField, debouncedUpdateField, isOpen]);return (<Popover- onOpenChange={(isOpen) => {- if (isOpen) {+ open={isOpen}+ onOpenChange={(open) => {+ setIsOpen(open);+ if (open) {setLocalField(field);}}}