Skip to content

Database diagrams editor that allows you to visualize and design your DB with a single query.

fix(performance): update field only when changed (#685)

Guy Ben-Aharond3ddf7c51eaa
diff --git a/src/pages/editor-page/side-panel/tables-section/table-list/table-list-item/table-list-item-content/table-field/table-field-modal/table-field-modal.tsx b/src/pages/editor-page/side-panel/tables-section/table-list/table-list-item/table-list-item-content/table-field/table-field-modal/table-field-modal.tsx
index 5b3eb185..819ed624 100644
--- a/src/pages/editor-page/side-panel/tables-section/table-list/table-list-item/table-list-item-content/table-field/table-field-modal/table-field-modal.tsx
+++ b/src/pages/editor-page/side-panel/tables-section/table-list/table-list-item/table-list-item-content/table-field/table-field-modal/table-field-modal.tsx
@@ -15,6 +15,7 @@ import { Checkbox } from '@/components/checkbox/checkbox';
import { useTranslation } from 'react-i18next';
import { Textarea } from '@/components/textarea/textarea';
import { debounce } from '@/lib/utils';
+import equal from 'fast-deep-equal';
export interface TableFieldPopoverProps {
field: DBField;
@@ -49,10 +50,10 @@ export const TableFieldPopover: React.FC<TableFieldPopoverProps> = ({
}, [updateField]);
useEffect(() => {
- if (debouncedUpdateFieldRef.current) {
+ if (debouncedUpdateFieldRef.current && !equal(field, localField)) {
debouncedUpdateFieldRef.current(localField);
}
- }, [localField]);
+ }, [localField, field]);
return (
<Popover