Skip to content

Chrome DevTools for coding agents

12.5 KB
Raw Blame
/**
 * @license
 * Copyright 2026 Google LLC
 * SPDX-License-Identifier: Apache-2.0
 */

import assert from 'node:assert';
import {getEventListeners} from 'node:events';
import {describe, it} from 'node:test';

import sinon from 'sinon';

import {TaskRunner, type TaskQueue} from '../../src/utils/TaskRunner.js';

import {settle} from '../utils.js';

interface ControlledTask {
  /** True once the queue is held. */
  started: boolean;
  /** Settles when the queue is released. */
  done: Promise<void>;
  /** Releases the queue. */
  finish: () => void;
}

/** Acquires `queue` and holds it until `finish()` is called. */
function start(queue: TaskQueue): ControlledTask {
  const {promise: release, resolve: finish} = Promise.withResolvers<void>();
  const controlled: ControlledTask = {
    started: false,
    done: Promise.resolve(),
    finish,
  };
  controlled.done = (async () => {
    using guard = await queue.scheduleTask();
    controlled.started = true;
    await release;
  })();
  return controlled;
}

function createTree() {
  const runner = new TaskRunner();
  const parent = runner.createQueue();
  const childA = runner.createQueue(parent);
  const childB = runner.createQueue(parent);
  return {runner, parent, childA, childB};
}

describe('TaskRunner', () => {
  describe('cancellation', () => {
    it('preserves the reason for an already aborted signal', async () => {
      const queue = new TaskRunner().createQueue();
      const controller = new AbortController();
      controller.abort('request cancelled');
      await assert.rejects(queue.scheduleTask(controller.signal), reason => {
        assert.strictEqual(reason, controller.signal.reason);
        return true;
      });
      using guard = await queue.scheduleTask();
      assert.deepStrictEqual(getEventListeners(controller.signal, 'abort'), []);
    });

    it('unblocks another child after cancelling a waiting parent', async () => {
      const {parent, childA, childB} = createTree();
      using running = await childA.scheduleTask();
      const controller = new AbortController();
      const waiting = parent.scheduleTask(controller.signal);
      const b = start(childB);
      await settle();
      assert.strictEqual(b.started, false);
      controller.abort();
      await assert.rejects(waiting, {name: 'AbortError'});
      await settle();
      assert.strictEqual(b.started, true);
      assert.deepStrictEqual(getEventListeners(controller.signal, 'abort'), []);
      b.finish();
      await b.done;
    });

    it('cancels acquisition while waiting', async () => {
      const queue = new TaskRunner().createQueue();
      const holder = await queue.scheduleTask();
      const controller = new AbortController();
      const pending = queue.scheduleTask(controller.signal);
      controller.abort();
      await assert.rejects(pending, {name: 'AbortError'});
      holder[Symbol.dispose]();
      using probe = await queue.scheduleTask();
      assert.deepStrictEqual(getEventListeners(controller.signal, 'abort'), []);
    });

    it('keeps guard ownership with its caller after cancellation', async () => {
      const queue = new TaskRunner().createQueue();
      const controller = new AbortController();
      const guard = await queue.scheduleTask(controller.signal);
      assert.deepStrictEqual(getEventListeners(controller.signal, 'abort'), []);
      controller.abort();
      const next = start(queue);
      await settle();
      assert.strictEqual(next.started, false);
      guard[Symbol.dispose]();
      await settle();
      assert.strictEqual(next.started, true);
      next.finish();
      await next.done;
      assert.throws(() => guard[Symbol.dispose](), /already disposed/);
    });

    it('preserves the reason when cancelling a waiting task', async () => {
      const queue = new TaskRunner().createQueue();
      using holder = await queue.scheduleTask();
      const controller = new AbortController();
      const pending = queue.scheduleTask(controller.signal);
      controller.abort('request cancelled');
      await assert.rejects(pending, reason => {
        assert.strictEqual(reason, controller.signal.reason);
        return true;
      });
      assert.deepStrictEqual(getEventListeners(controller.signal, 'abort'), []);
    });

    it('keeps an acquired guard when aborted before promise delivery', async () => {
      const queue = new TaskRunner().createQueue();
      const controller = new AbortController();
      const reason = new Error('request cancelled');
      const pending = queue.scheduleTask(controller.signal);
      controller.abort(reason);
      const guard = await pending;
      const next = start(queue);
      await settle();
      assert.strictEqual(next.started, false);
      guard[Symbol.dispose]();
      await settle();
      assert.strictEqual(next.started, true);
      next.finish();
      await next.done;
    });

    for (const cancelFirst of [false, true]) {
      it(`races disposal with abort (cancelFirst=${cancelFirst})`, async () => {
        const queue = new TaskRunner().createQueue();
        using running = await queue.scheduleTask();
        const controller = new AbortController();
        const pending = queue.scheduleTask(controller.signal);
        const closed = new Error('Page closed');
        if (cancelFirst) {
          controller.abort();
          queue.dispose(closed);
        } else {
          queue.dispose(closed);
          controller.abort();
        }
        await assert.rejects(pending, reason => {
          assert.strictEqual(
            reason,
            cancelFirst ? controller.signal.reason : closed,
          );
          return true;
        });
        assert.deepStrictEqual(
          getEventListeners(controller.signal, 'abort'),
          [],
        );
      });
    }
  });

  it('runs tasks on unrelated queues at the same time', async () => {
    const {childA, childB} = createTree();
    const a = start(childA);
    const b = start(childB);
    await settle();
    assert.strictEqual(a.started, true);
    assert.strictEqual(b.started, true);
    a.finish();
    b.finish();
    await Promise.all([a.done, b.done]);
  });

  it('runs tasks on queues of different roots at the same time', async () => {
    const runner = new TaskRunner();
    const a = start(runner.createQueue());
    const b = start(runner.createQueue());
    await settle();
    assert.strictEqual(a.started, true);
    assert.strictEqual(b.started, true);
    a.finish();
    b.finish();
    await Promise.all([a.done, b.done]);
  });

  it('serializes holders of one queue in FIFO order', async () => {
    const queue = new TaskRunner().createQueue();
    const order: number[] = [];
    await Promise.all(
      [1, 2, 3].map(async id => {
        using guard = await queue.scheduleTask();
        await settle();
        order.push(id);
      }),
    );
    assert.deepStrictEqual(order, [1, 2, 3]);
  });

  it('orders by queue, not by task duration', async () => {
    const clock = sinon.useFakeTimers();
    try {
      const runner = new TaskRunner();
      const order: string[] = [];
      const run = async (queue: TaskQueue, name: string, ms: number) => {
        using guard = await queue.scheduleTask();
        await new Promise(resolve => setTimeout(resolve, ms));
        order.push(name);
      };

      const shared = runner.createQueue();
      const sameQueue = Promise.all([
        run(shared, 'slow', 300),
        run(shared, 'fast', 100),
      ]);
      await clock.tickAsync(1_000);
      await sameQueue;
      assert.deepStrictEqual(order, ['slow', 'fast']);

      order.length = 0;
      const unrelated = Promise.all([
        run(runner.createQueue(), 'slow', 300),
        run(runner.createQueue(), 'fast', 100),
      ]);
      await clock.tickAsync(1_000);
      await unrelated;
      assert.deepStrictEqual(order, ['fast', 'slow']);
    } finally {
      clock.restore();
    }
  });

  it('makes a parent task wait for a running child task', async () => {
    const {parent, childA} = createTree();
    const child = start(childA);
    const parentTask = start(parent);
    await settle();
    assert.strictEqual(parentTask.started, false);
    child.finish();
    await settle();
    assert.strictEqual(parentTask.started, true);
    parentTask.finish();
    await Promise.all([child.done, parentTask.done]);
  });

  it('makes a child task wait for a running parent task', async () => {
    const {parent, childA} = createTree();
    const parentTask = start(parent);
    const child = start(childA);
    await settle();
    assert.strictEqual(child.started, false);
    parentTask.finish();
    await settle();
    assert.strictEqual(child.started, true);
    child.finish();
    await Promise.all([child.done, parentTask.done]);
  });

  it('blocks a later child task behind a waiting parent task', async () => {
    const {parent, childA, childB} = createTree();
    const a = start(childA);
    const parentTask = start(parent);
    const b = start(childB);
    await settle();
    assert.strictEqual(b.started, false);
    a.finish();
    await settle();
    assert.strictEqual(parentTask.started, true);
    assert.strictEqual(b.started, false);
    parentTask.finish();
    await settle();
    assert.strictEqual(b.started, true);
    b.finish();
    await Promise.all([a.done, parentTask.done, b.done]);
  });

  it('throws when a guard is disposed twice', async () => {
    const queue = new TaskRunner().createQueue();
    const guard = await queue.scheduleTask();
    guard[Symbol.dispose]();
    assert.throws(
      () => guard[Symbol.dispose](),
      /The guard was already disposed\./,
    );
  });

  it('releases the queue when the holder throws', async () => {
    const queue = new TaskRunner().createQueue();
    await assert.rejects(
      (async () => {
        using guard = await queue.scheduleTask();
        throw new Error('task failed');
      })(),
      /task failed/,
    );
    const next = start(queue);
    await settle();
    assert.strictEqual(next.started, true);
    next.finish();
    await next.done;
  });

  describe('pause', () => {
    it('stops new tasks and resolves after running tasks finish', async () => {
      const {runner, childA, childB} = createTree();
      const running = start(childA);
      await settle();
      let paused = false;
      const pause = runner.pause().then(guard => {
        paused = true;
        return guard;
      });
      const late = start(childB);
      await settle();
      assert.strictEqual(paused, false);
      assert.strictEqual(late.started, false);
      running.finish();
      await running.done;
      const guard = await pause;
      await settle();
      assert.strictEqual(late.started, false);
      guard[Symbol.dispose]();
      await settle();
      assert.strictEqual(late.started, true);
      late.finish();
      await late.done;
    });

    it('goes ahead of waiting tasks', async () => {
      const {runner, childA} = createTree();
      const running = start(childA);
      const waiting = start(childA);
      await settle();
      const pause = runner.pause();
      running.finish();
      const guard = await pause;
      await settle();
      assert.strictEqual(waiting.started, false);
      guard[Symbol.dispose]();
      await settle();
      assert.strictEqual(waiting.started, true);
      waiting.finish();
      await Promise.all([running.done, waiting.done]);
    });
  });

  describe('dispose', () => {
    it('rejects waiting tasks with the reason and keeps the running task', async () => {
      const queue = new TaskRunner().createQueue();
      const running = start(queue);
      const waiting = start(queue);
      await settle();
      queue.dispose(new Error('Page 1 is closed.'));
      await assert.rejects(waiting.done, /Page 1 is closed\./);
      assert.strictEqual(running.started, true);
      running.finish();
      await running.done;
    });

    it('rejects a later scheduleTask()', async () => {
      const queue = new TaskRunner().createQueue();
      queue.dispose(new Error('Page 1 is closed.'));
      await assert.rejects(queue.scheduleTask(), /Page 1 is closed\./);
    });

    it('lets a parent task run after a waiting child task is rejected', async () => {
      const {parent, childA} = createTree();
      const running = start(childA);
      const waiting = start(childA);
      await settle();
      childA.dispose(new Error('closed'));
      await assert.rejects(waiting.done, /closed/);
      running.finish();
      await running.done;
      const parentTask = start(parent);
      await settle();
      assert.strictEqual(parentTask.started, true);
      parentTask.finish();
      await parentTask.done;
    });
  });
});