Chrome DevTools for coding agents
fix: reject unknown MCP server options (#2547)
Langning Zhang0b4390dafaf7
diff --git a/src/bin/chrome-devtools-mcp-cli-options.ts b/src/bin/chrome-devtools-mcp-cli-options.tsindex c22717da..015b61bf 100644--- a/src/bin/chrome-devtools-mcp-cli-options.ts+++ b/src/bin/chrome-devtools-mcp-cli-options.ts@@ -381,9 +381,23 @@ export function parseArguments(argv = process.argv,env = process.env,) {+ // Preserve yargs' mixed camel/kebab-case expansion under strict validation.+ const kebabCaseAliases: Record<string, string> = {};+ for (const option of Object.keys(cliOptions)) {+ const alias = option.replace(+ /[A-Z]/g,+ letter => `-${letter.toLowerCase()}`,+ );+ if (alias !== option) {+ kebabCaseAliases[option] = alias;+ }+ }+const yargsInstance = yargs(hideBin(argv)).scriptName('npx chrome-devtools-mcp@latest').options(cliOptions)+ .alias(kebabCaseAliases)+ .strictOptions().middleware(args => {// We can't set default in the options else// Yargs will complaindiff --git a/tests/cli.test.ts b/tests/cli.test.tsindex 562e6153..3b1ed5e7 100644--- a/tests/cli.test.ts+++ b/tests/cli.test.ts@@ -5,6 +5,7 @@*/import assert from 'node:assert';+import {spawnSync} from 'node:child_process';import {describe, it} from 'node:test';import {parseArguments} from '../src/bin/chrome-devtools-mcp-cli-options.js';@@ -61,6 +62,35 @@ describe('cli args parsing', () => {});});+ it('rejects unknown options', async () => {+ const moduleUrl = new URL(+ '../src/bin/chrome-devtools-mcp-cli-options.js',+ import.meta.url,+ );+ const result = spawnSync(+ process.execPath,+ [+ '--input-type=module',+ '--eval',+ `import {parseArguments} from ${JSON.stringify(moduleUrl.href)}; parseArguments('1.0.0', ['node', 'main.js', '--browserURL', 'http://localhost:3000'], {});`,+ ],+ {encoding: 'utf8'},+ );++ assert.strictEqual(result.status, 1);+ assert.match(result.stderr, /Unknown argument: browserURL/);+ });++ it('parses mixed-form option names', async () => {+ const args = parseArguments(+ '1.0.0',+ ['node', 'main.js', '--category-experimentalWebmcp'],+ {},+ );++ assert.strictEqual(args.categoryExperimentalWebmcp, true);+ });+it('parses with user data dir', async () => {const args = parseArguments('1.0.0',