Skip to content

Chrome DevTools for coding agents

fix: forbid closing the last page (#90)

Alex Rudenko0ca2434a29eb
diff --git a/docs/tool-reference.md b/docs/tool-reference.md
index dd661efc..84d4fc9d 100644
--- a/docs/tool-reference.md
+++ b/docs/tool-reference.md
@@ -116,7 +116,7 @@
### `close_page`
-**Description:** Closes the page by its index.
+**Description:** Closes the page by its index. The last open page cannot be closed.
**Parameters:**
diff --git a/src/McpContext.ts b/src/McpContext.ts
index 1456234e..035f7184 100644
--- a/src/McpContext.ts
+++ b/src/McpContext.ts
@@ -131,6 +131,16 @@ export class McpContext implements Context {
this.#consoleCollector.addPage(page);
return page;
}
+ async closePage(pageIdx: number): Promise<void> {
+ if (this.#pages.length === 1) {
+ throw new Error(
+ 'Unable to close the last page in the browser. It is fine to keep the last page open.',
+ );
+ }
+ const page = this.getPageByIdx(pageIdx);
+ this.setSelectedPageIdx(0);
+ await page.close({runBeforeUnload: false});
+ }
getNetworkRequestByUrl(url: string): HTTPRequest {
const requests = this.getNetworkRequests();
diff --git a/src/tools/ToolDefinition.ts b/src/tools/ToolDefinition.ts
index 37b0f50d..be07fdbb 100644
--- a/src/tools/ToolDefinition.ts
+++ b/src/tools/ToolDefinition.ts
@@ -62,6 +62,7 @@ export type Context = Readonly<{
clearDialog(): void;
getPageByIdx(idx: number): Page;
newPage(): Promise<Page>;
+ closePage(pageIdx: number): Promise<void>;
setSelectedPageIdx(idx: number): void;
getElementByUid(uid: string): Promise<ElementHandle<Element>>;
setNetworkConditions(conditions: string | null): void;
diff --git a/src/tools/pages.ts b/src/tools/pages.ts
index c360ef19..be6ec236 100644
--- a/src/tools/pages.ts
+++ b/src/tools/pages.ts
@@ -45,7 +45,7 @@ export const selectPage = defineTool({
export const closePage = defineTool({
name: 'close_page',
- description: `Closes the page by its index.`,
+ description: `Closes the page by its index. The last open page cannot be closed.`,
annotations: {
category: ToolCategories.NAVIGATION_AUTOMATION,
readOnlyHint: false,
@@ -58,9 +58,7 @@ export const closePage = defineTool({
),
},
handler: async (request, response, context) => {
- const page = context.getPageByIdx(request.params.pageIdx);
- context.setSelectedPageIdx(0);
- await page.close({runBeforeUnload: false});
+ await context.closePage(request.params.pageIdx);
response.setIncludePages(true);
},
});
diff --git a/tests/tools/pages.test.ts b/tests/tools/pages.test.ts
index 66985a50..5cad3b6e 100644
--- a/tests/tools/pages.test.ts
+++ b/tests/tools/pages.test.ts
@@ -53,6 +53,21 @@ describe('pages', () => {
assert.ok(response.includePages);
});
});
+ it('cannot close the last page', async () => {
+ await withBrowser(async (response, context) => {
+ const page = context.getSelectedPage();
+ try {
+ await closePage.handler({params: {pageIdx: 0}}, response, context);
+ assert.fail('not reached');
+ } catch (err) {
+ assert.strictEqual(
+ err.message,
+ 'Unable to close the last page in the browser. It is fine to keep the last page open.',
+ );
+ }
+ assert.ok(!page.isClosed());
+ });
+ });
});
describe('browser_select_page', () => {
it('selects a page', async () => {