Chrome DevTools for coding agents
fix: ordering of information in performance trace summary (#334)
Jack Franklin2d4484a12396
diff --git a/src/tools/performance.ts b/src/tools/performance.tsindex c9de76f7..9a6a3b95 100644--- a/src/tools/performance.ts+++ b/src/tools/performance.ts@@ -167,9 +167,6 @@ async function stopTracingAndAppendOutput(response.appendResponseLine('The performance trace has been stopped.');if (traceResultIsSuccess(result)) {context.storeTraceRecording(result);- response.appendResponseLine(- 'Here is a high level summary of the trace and the Insights that were found:',- );const traceSummaryText = getTraceSummary(result);response.appendResponseLine(traceSummaryText);} else {diff --git a/src/trace-processing/parse.ts b/src/trace-processing/parse.tsindex d2932fed..2b0f523f 100644--- a/src/trace-processing/parse.ts+++ b/src/trace-processing/parse.ts@@ -77,15 +77,17 @@ const extraFormatDescriptions = `Information on performance traces may contain m${PerformanceTraceFormatter.callFrameDataFormatDescription}-${PerformanceTraceFormatter.networkDataFormatDescription}-`;+${PerformanceTraceFormatter.networkDataFormatDescription}`;+export function getTraceSummary(result: TraceResult): string {const focus = AgentFocus.fromParsedTrace(result.parsedTrace);const formatter = new PerformanceTraceFormatter(focus);- const output = formatter.formatTraceSummary();- return `${extraFormatDescriptions}+ const summaryText = formatter.formatTraceSummary();+ return `## Summary of Performance trace findings:+${summaryText}-${output}`;+## Details on call tree & network request formats:+${extraFormatDescriptions}`;}export type InsightName = keyof TraceEngine.Insights.Types.InsightModels;diff --git a/tests/tools/performance.test.js.snapshot b/tests/tools/performance.test.js.snapshotindex 071909f4..ba704151 100644--- a/tests/tools/performance.test.js.snapshot+++ b/tests/tools/performance.test.js.snapshot@@ -50,7 +50,51 @@ No buffer was provided.exports[`performance > performance_stop_trace > returns the high level summary of the performance trace 1`] = `The performance trace has been stopped.-Here is a high level summary of the trace and the Insights that were found:+## Summary of Performance trace findings:+URL: https://web.dev/+Bounds: {min: 122410994891, max: 122416385853}+CPU throttling: none+Network throttling: none+Metrics (lab / observed):+ - LCP: 129 ms, event: (eventKey: r-6063, ts: 122411126100), nodeId: 7+ - LCP breakdown:+ - TTFB: 8 ms, bounds: {min: 122410996889, max: 122411004828}+ - Load delay: 33 ms, bounds: {min: 122411004828, max: 122411037986}+ - Load duration: 15 ms, bounds: {min: 122411037986, max: 122411052690}+ - Render delay: 73 ms, bounds: {min: 122411052690, max: 122411126100}+ - CLS: 0.00+Metrics (field / real users): n/a – no data for this page in CrUX+Available insights:+ - insight name: LCPBreakdown+ description: Each [subpart has specific improvement strategies](https://web.dev/articles/optimize-lcp#lcp-breakdown). Ideally, most of the LCP time should be spent on loading the resources, not within delays.+ relevant trace bounds: {min: 122410996889, max: 122411126100}+ example question: Help me optimize my LCP score+ example question: Which LCP phase was most problematic?+ example question: What can I do to reduce the LCP time for this page load?+ - insight name: LCPDiscovery+ description: Optimize LCP by making the LCP image [discoverable](https://web.dev/articles/optimize-lcp#1_eliminate_resource_load_delay) from the HTML immediately, and [avoiding lazy-loading](https://web.dev/articles/lcp-lazy-loading)+ relevant trace bounds: {min: 122411004828, max: 122411055039}+ example question: Suggest fixes to reduce my LCP+ example question: What can I do to reduce my LCP discovery time?+ example question: Why is LCP discovery time important?+ - insight name: RenderBlocking+ description: Requests are blocking the page's initial render, which may delay LCP. [Deferring or inlining](https://web.dev/learn/performance/understanding-the-critical-path#render-blocking_resources) can move these network requests out of the critical path.+ relevant trace bounds: {min: 122411037528, max: 122411053852}+ example question: Show me the most impactful render blocking requests that I should focus on+ example question: How can I reduce the number of render blocking requests?+ - insight name: DocumentLatency+ description: Your first network request is the most important. Reduce its latency by avoiding redirects, ensuring a fast server response, and enabling text compression.+ relevant trace bounds: {min: 122410998910, max: 122411043781}+ estimated metric savings: FCP 0 ms, LCP 0 ms+ estimated wasted bytes: 77.1 kB+ example question: How do I decrease the initial loading time of my page?+ example question: Did anything slow down the request for this document?+ - insight name: ThirdParties+ description: 3rd party code can significantly impact load performance. [Reduce and defer loading of 3rd party code](https://web.dev/articles/optimizing-content-efficiency-loading-third-party-javascript/) to prioritize your page's content.+ relevant trace bounds: {min: 122411037881, max: 122416229595}+ example question: Which third parties are having the largest impact on my page performance?++## Details on call tree & network request formats:Information on performance traces may contain main thread activity represented as call frames and network requests.Each call frame is presented in the following format:@@ -105,48 +149,4 @@ Durations (all in milliseconds):- \`responseHeaders\`: A list (separated by '|') of values for specific, pre-defined response headers, enclosed in square brackets.The order of headers corresponds to an internal fixed list. If a header is not present, its value will be empty.---URL: https://web.dev/-Bounds: {min: 122410994891, max: 122416385853}-CPU throttling: none-Network throttling: none-Metrics (lab / observed):- - LCP: 129 ms, event: (eventKey: r-6063, ts: 122411126100), nodeId: 7- - LCP breakdown:- - TTFB: 8 ms, bounds: {min: 122410996889, max: 122411004828}- - Load delay: 33 ms, bounds: {min: 122411004828, max: 122411037986}- - Load duration: 15 ms, bounds: {min: 122411037986, max: 122411052690}- - Render delay: 73 ms, bounds: {min: 122411052690, max: 122411126100}- - CLS: 0.00-Metrics (field / real users): n/a – no data for this page in CrUX-Available insights:- - insight name: LCPBreakdown- description: Each [subpart has specific improvement strategies](https://web.dev/articles/optimize-lcp#lcp-breakdown). Ideally, most of the LCP time should be spent on loading the resources, not within delays.- relevant trace bounds: {min: 122410996889, max: 122411126100}- example question: Help me optimize my LCP score- example question: Which LCP phase was most problematic?- example question: What can I do to reduce the LCP time for this page load?- - insight name: LCPDiscovery- description: Optimize LCP by making the LCP image [discoverable](https://web.dev/articles/optimize-lcp#1_eliminate_resource_load_delay) from the HTML immediately, and [avoiding lazy-loading](https://web.dev/articles/lcp-lazy-loading)- relevant trace bounds: {min: 122411004828, max: 122411055039}- example question: Suggest fixes to reduce my LCP- example question: What can I do to reduce my LCP discovery time?- example question: Why is LCP discovery time important?- - insight name: RenderBlocking- description: Requests are blocking the page's initial render, which may delay LCP. [Deferring or inlining](https://web.dev/learn/performance/understanding-the-critical-path#render-blocking_resources) can move these network requests out of the critical path.- relevant trace bounds: {min: 122411037528, max: 122411053852}- example question: Show me the most impactful render blocking requests that I should focus on- example question: How can I reduce the number of render blocking requests?- - insight name: DocumentLatency- description: Your first network request is the most important. Reduce its latency by avoiding redirects, ensuring a fast server response, and enabling text compression.- relevant trace bounds: {min: 122410998910, max: 122411043781}- estimated metric savings: FCP 0 ms, LCP 0 ms- estimated wasted bytes: 77.1 kB- example question: How do I decrease the initial loading time of my page?- example question: Did anything slow down the request for this document?- - insight name: ThirdParties- description: 3rd party code can significantly impact load performance. [Reduce and defer loading of 3rd party code](https://web.dev/articles/optimizing-content-efficiency-loading-third-party-javascript/) to prioritize your page's content.- relevant trace bounds: {min: 122411037881, max: 122416229595}- example question: Which third parties are having the largest impact on my page performance?`;diff --git a/tests/trace-processing/parse.test.js.snapshot b/tests/trace-processing/parse.test.js.snapshotindex 5ce7918f..815206d5 100644--- a/tests/trace-processing/parse.test.js.snapshot+++ b/tests/trace-processing/parse.test.js.snapshot@@ -1,4 +1,49 @@exports[`Trace parsing > can format results of a trace 1`] = `+## Summary of Performance trace findings:+URL: https://web.dev/+Bounds: {min: 122410994891, max: 122416385853}+CPU throttling: none+Network throttling: none+Metrics (lab / observed):+ - LCP: 129 ms, event: (eventKey: r-6063, ts: 122411126100), nodeId: 7+ - LCP breakdown:+ - TTFB: 8 ms, bounds: {min: 122410996889, max: 122411004828}+ - Load delay: 33 ms, bounds: {min: 122411004828, max: 122411037986}+ - Load duration: 15 ms, bounds: {min: 122411037986, max: 122411052690}+ - Render delay: 73 ms, bounds: {min: 122411052690, max: 122411126100}+ - CLS: 0.00+Metrics (field / real users): n/a – no data for this page in CrUX+Available insights:+ - insight name: LCPBreakdown+ description: Each [subpart has specific improvement strategies](https://web.dev/articles/optimize-lcp#lcp-breakdown). Ideally, most of the LCP time should be spent on loading the resources, not within delays.+ relevant trace bounds: {min: 122410996889, max: 122411126100}+ example question: Help me optimize my LCP score+ example question: Which LCP phase was most problematic?+ example question: What can I do to reduce the LCP time for this page load?+ - insight name: LCPDiscovery+ description: Optimize LCP by making the LCP image [discoverable](https://web.dev/articles/optimize-lcp#1_eliminate_resource_load_delay) from the HTML immediately, and [avoiding lazy-loading](https://web.dev/articles/lcp-lazy-loading)+ relevant trace bounds: {min: 122411004828, max: 122411055039}+ example question: Suggest fixes to reduce my LCP+ example question: What can I do to reduce my LCP discovery time?+ example question: Why is LCP discovery time important?+ - insight name: RenderBlocking+ description: Requests are blocking the page's initial render, which may delay LCP. [Deferring or inlining](https://web.dev/learn/performance/understanding-the-critical-path#render-blocking_resources) can move these network requests out of the critical path.+ relevant trace bounds: {min: 122411037528, max: 122411053852}+ example question: Show me the most impactful render blocking requests that I should focus on+ example question: How can I reduce the number of render blocking requests?+ - insight name: DocumentLatency+ description: Your first network request is the most important. Reduce its latency by avoiding redirects, ensuring a fast server response, and enabling text compression.+ relevant trace bounds: {min: 122410998910, max: 122411043781}+ estimated metric savings: FCP 0 ms, LCP 0 ms+ estimated wasted bytes: 77.1 kB+ example question: How do I decrease the initial loading time of my page?+ example question: Did anything slow down the request for this document?+ - insight name: ThirdParties+ description: 3rd party code can significantly impact load performance. [Reduce and defer loading of 3rd party code](https://web.dev/articles/optimizing-content-efficiency-loading-third-party-javascript/) to prioritize your page's content.+ relevant trace bounds: {min: 122411037881, max: 122416229595}+ example question: Which third parties are having the largest impact on my page performance?++## Details on call tree & network request formats:Information on performance traces may contain main thread activity represented as call frames and network requests.Each call frame is presented in the following format:@@ -53,48 +98,4 @@ Durations (all in milliseconds):- \`responseHeaders\`: A list (separated by '|') of values for specific, pre-defined response headers, enclosed in square brackets.The order of headers corresponds to an internal fixed list. If a header is not present, its value will be empty.---URL: https://web.dev/-Bounds: {min: 122410994891, max: 122416385853}-CPU throttling: none-Network throttling: none-Metrics (lab / observed):- - LCP: 129 ms, event: (eventKey: r-6063, ts: 122411126100), nodeId: 7- - LCP breakdown:- - TTFB: 8 ms, bounds: {min: 122410996889, max: 122411004828}- - Load delay: 33 ms, bounds: {min: 122411004828, max: 122411037986}- - Load duration: 15 ms, bounds: {min: 122411037986, max: 122411052690}- - Render delay: 73 ms, bounds: {min: 122411052690, max: 122411126100}- - CLS: 0.00-Metrics (field / real users): n/a – no data for this page in CrUX-Available insights:- - insight name: LCPBreakdown- description: Each [subpart has specific improvement strategies](https://web.dev/articles/optimize-lcp#lcp-breakdown). Ideally, most of the LCP time should be spent on loading the resources, not within delays.- relevant trace bounds: {min: 122410996889, max: 122411126100}- example question: Help me optimize my LCP score- example question: Which LCP phase was most problematic?- example question: What can I do to reduce the LCP time for this page load?- - insight name: LCPDiscovery- description: Optimize LCP by making the LCP image [discoverable](https://web.dev/articles/optimize-lcp#1_eliminate_resource_load_delay) from the HTML immediately, and [avoiding lazy-loading](https://web.dev/articles/lcp-lazy-loading)- relevant trace bounds: {min: 122411004828, max: 122411055039}- example question: Suggest fixes to reduce my LCP- example question: What can I do to reduce my LCP discovery time?- example question: Why is LCP discovery time important?- - insight name: RenderBlocking- description: Requests are blocking the page's initial render, which may delay LCP. [Deferring or inlining](https://web.dev/learn/performance/understanding-the-critical-path#render-blocking_resources) can move these network requests out of the critical path.- relevant trace bounds: {min: 122411037528, max: 122411053852}- example question: Show me the most impactful render blocking requests that I should focus on- example question: How can I reduce the number of render blocking requests?- - insight name: DocumentLatency- description: Your first network request is the most important. Reduce its latency by avoiding redirects, ensuring a fast server response, and enabling text compression.- relevant trace bounds: {min: 122410998910, max: 122411043781}- estimated metric savings: FCP 0 ms, LCP 0 ms- estimated wasted bytes: 77.1 kB- example question: How do I decrease the initial loading time of my page?- example question: Did anything slow down the request for this document?- - insight name: ThirdParties- description: 3rd party code can significantly impact load performance. [Reduce and defer loading of 3rd party code](https://web.dev/articles/optimizing-content-efficiency-loading-third-party-javascript/) to prioritize your page's content.- relevant trace bounds: {min: 122411037881, max: 122416229595}- example question: Which third parties are having the largest impact on my page performance?`;