Skip to content

Chrome DevTools for coding agents

chore(deps): bump third_party/devtools-frontend from `8d85196` to `e5b5826` (#3108)

dependabot[bot]305c06d0641f
diff --git a/tests/formatters/ConsoleFormatter.test.ts b/tests/formatters/ConsoleFormatter.test.ts
index 67e4ce3f..f46ab9bb 100644
--- a/tests/formatters/ConsoleFormatter.test.ts
+++ b/tests/formatters/ConsoleFormatter.test.ts
@@ -610,6 +610,7 @@ describe('ConsoleFormatter', () => {
column: i,
url: 'main.js',
name: `fn${i}`,
+ toUiLocation: () => null,
});
}
const stackTrace = {
diff --git a/tests/trace-processing/ChunkedTraceParser.test.ts b/tests/trace-processing/ChunkedTraceParser.test.ts
index fc2de5c6..4b1bb429 100644
--- a/tests/trace-processing/ChunkedTraceParser.test.ts
+++ b/tests/trace-processing/ChunkedTraceParser.test.ts
@@ -8,9 +8,23 @@ import assert from 'node:assert';
import {describe, it} from 'node:test';
import {parseTraceEventsFromBuffer} from '../../src/processors/ChunkedTraceParser.js';
+import type {DevTools} from '../../src/third_party/index.js';
import {loadTraceAsBuffer} from './fixtures/load.js';
+function getArgsDataUrl(
+ event: DevTools.TraceEngine.Types.Events.Event | undefined,
+): unknown {
+ const args: unknown = event?.args;
+ if (args && typeof args === 'object' && 'data' in args) {
+ const data: unknown = args.data;
+ if (data && typeof data === 'object' && 'url' in data) {
+ return data.url;
+ }
+ }
+ return undefined;
+}
+
describe('ChunkedTraceParser', () => {
const encoder = new TextEncoder();
@@ -108,7 +122,7 @@ describe('ChunkedTraceParser', () => {
assert.strictEqual(result.events.length, 1);
assert.strictEqual(result.events[0]?.name, 'event-{with-braces}');
assert.strictEqual(
- result.events[0]?.args?.data?.url,
+ getArgsDataUrl(result.events[0]),
'https://example.com/hello?q=} { [bracket] "escaped" \\\\ backslash',
);
assert.strictEqual(result.metadata?.title, 'nested } braces { inside');
@@ -132,10 +146,7 @@ describe('ChunkedTraceParser', () => {
assert.strictEqual(result.events.length, 1);
assert.strictEqual(result.events[0]?.name, 'deep');
- assert.strictEqual(
- result.events[0]?.args?.data?.url,
- 'https://example.com',
- );
+ assert.strictEqual(getArgsDataUrl(result.events[0]), 'https://example.com');
});
it('batches events correctly according to eventsPerBatch', () => {
@@ -249,17 +260,17 @@ describe('ChunkedTraceParser', () => {
assert.strictEqual(result.events.length, 3);
assert.strictEqual(result.events[0]?.name, '日本語テスト-1');
assert.strictEqual(
- result.events[0]?.args?.data?.url,
+ getArgsDataUrl(result.events[0]),
'https://example.com/こんにちは世界-🚀',
);
assert.strictEqual(result.events[1]?.name, 'emoji-🎉-2');
assert.strictEqual(
- result.events[1]?.args?.data?.url,
+ getArgsDataUrl(result.events[1]),
'https://example.com/€100-and-50¢',
);
assert.strictEqual(result.events[2]?.name, 'umlaut-äöü-3');
assert.strictEqual(
- result.events[2]?.args?.data?.url,
+ getArgsDataUrl(result.events[2]),
'https://example.com/Deutsch-äöü',
);
});
diff --git a/third_party/devtools-frontend b/third_party/devtools-frontend
index 8d85196f..e5b58260 160000
--- a/third_party/devtools-frontend
+++ b/third_party/devtools-frontend
@@ -1 +1 @@
-Subproject commit 8d85196f529129c6c5d4940c59fd6ab5ba33ca3b
+Subproject commit e5b582607b5a113a4142c8eaca1043c68f68ba3e