Skip to content

Chrome DevTools for coding agents

chore: turn arg name into snake case in sanitization (#1862)

yulunz48e484f20589
diff --git a/src/telemetry/ClearcutLogger.ts b/src/telemetry/ClearcutLogger.ts
index 82f766cd..c2e2b5b7 100644
--- a/src/telemetry/ClearcutLogger.ts
+++ b/src/telemetry/ClearcutLogger.ts
@@ -60,12 +60,16 @@ export function getZodType(zodType: zod.ZodTypeAny): ZodType {
type LoggedToolCallArgValue = string | number | boolean;
export function transformArgName(zodType: ZodType, name: string): string {
+ const snakeCaseName = name.replace(
+ /[A-Z]/g,
+ letter => `_${letter.toLowerCase()}`,
+ );
if (zodType === 'ZodString') {
- return `${name}_length`;
+ return `${snakeCaseName}_length`;
} else if (zodType === 'ZodArray') {
- return `${name}_count`;
+ return `${snakeCaseName}_count`;
} else {
- return name;
+ return snakeCaseName;
}
}
diff --git a/src/telemetry/tool_call_metrics.json b/src/telemetry/tool_call_metrics.json
index 496045ff..743f0eb1 100644
--- a/src/telemetry/tool_call_metrics.json
+++ b/src/telemetry/tool_call_metrics.json
@@ -3,11 +3,11 @@
"name": "click",
"args": [
{
- "name": "dblClick",
+ "name": "dbl_click",
"argType": "boolean"
},
{
- "name": "includeSnapshot",
+ "name": "include_snapshot",
"argType": "boolean"
}
]
@@ -24,11 +24,11 @@
"argType": "number"
},
{
- "name": "dblClick",
+ "name": "dbl_click",
"argType": "boolean"
},
{
- "name": "includeSnapshot",
+ "name": "include_snapshot",
"argType": "boolean"
}
]
@@ -37,7 +37,7 @@
"name": "close_page",
"args": [
{
- "name": "pageId",
+ "name": "page_id",
"argType": "number"
}
]
@@ -54,7 +54,7 @@
"argType": "number"
},
{
- "name": "includeSnapshot",
+ "name": "include_snapshot",
"argType": "boolean"
}
]
@@ -63,11 +63,11 @@
"name": "emulate",
"args": [
{
- "name": "networkConditions",
+ "name": "network_conditions",
"argType": "string"
},
{
- "name": "cpuThrottlingRate",
+ "name": "cpu_throttling_rate",
"argType": "number"
},
{
@@ -75,11 +75,11 @@
"argType": "number"
},
{
- "name": "userAgent_length",
+ "name": "user_agent_length",
"argType": "number"
},
{
- "name": "colorScheme",
+ "name": "color_scheme",
"argType": "string"
},
{
@@ -114,7 +114,7 @@
"name": "execute_in_page_tool",
"args": [
{
- "name": "toolName_length",
+ "name": "tool_name_length",
"argType": "number"
},
{
@@ -131,7 +131,7 @@
"argType": "number"
},
{
- "name": "includeSnapshot",
+ "name": "include_snapshot",
"argType": "boolean"
}
]
@@ -144,7 +144,7 @@
"argType": "number"
},
{
- "name": "includeSnapshot",
+ "name": "include_snapshot",
"argType": "boolean"
}
]
@@ -157,11 +157,11 @@
"name": "get_network_request",
"args": [
{
- "name": "requestFilePath_length",
+ "name": "request_file_path_length",
"argType": "number"
},
{
- "name": "responseFilePath_length",
+ "name": "response_file_path_length",
"argType": "number"
}
]
@@ -170,7 +170,7 @@
"name": "get_tab_id",
"args": [
{
- "name": "pageId",
+ "name": "page_id",
"argType": "number"
}
]
@@ -183,7 +183,7 @@
"argType": "string"
},
{
- "name": "promptText_length",
+ "name": "prompt_text_length",
"argType": "number"
}
]
@@ -192,7 +192,7 @@
"name": "hover",
"args": [
{
- "name": "includeSnapshot",
+ "name": "include_snapshot",
"argType": "boolean"
}
]
@@ -218,7 +218,7 @@
"argType": "string"
},
{
- "name": "outputDirPath_length",
+ "name": "output_dir_path_length",
"argType": "number"
}
]
@@ -227,11 +227,11 @@
"name": "list_console_messages",
"args": [
{
- "name": "pageSize",
+ "name": "page_size",
"argType": "number"
},
{
- "name": "pageIdx",
+ "name": "page_idx",
"argType": "number"
},
{
@@ -239,7 +239,7 @@
"argType": "number"
},
{
- "name": "includePreservedMessages",
+ "name": "include_preserved_messages",
"argType": "boolean"
}
]
@@ -256,19 +256,19 @@
"name": "list_network_requests",
"args": [
{
- "name": "pageSize",
+ "name": "page_size",
"argType": "number"
},
{
- "name": "pageIdx",
+ "name": "page_idx",
"argType": "number"
},
{
- "name": "resourceTypes_count",
+ "name": "resource_types_count",
"argType": "number"
},
{
- "name": "includePreservedRequests",
+ "name": "include_preserved_requests",
"argType": "boolean"
}
]
@@ -298,15 +298,15 @@
"argType": "number"
},
{
- "name": "ignoreCache",
+ "name": "ignore_cache",
"argType": "boolean"
},
{
- "name": "handleBeforeUnload",
+ "name": "handle_before_unload",
"argType": "string"
},
{
- "name": "initScript_length",
+ "name": "init_script_length",
"argType": "number"
},
{
@@ -327,7 +327,7 @@
"argType": "boolean"
},
{
- "name": "isolatedContext_length",
+ "name": "isolated_context_length",
"argType": "number"
},
{
@@ -340,11 +340,11 @@
"name": "performance_analyze_insight",
"args": [
{
- "name": "insightSetId_length",
+ "name": "insight_set_id_length",
"argType": "number"
},
{
- "name": "insightName_length",
+ "name": "insight_name_length",
"argType": "number"
}
]
@@ -357,11 +357,11 @@
"argType": "boolean"
},
{
- "name": "autoStop",
+ "name": "auto_stop",
"argType": "boolean"
},
{
- "name": "filePath_length",
+ "name": "file_path_length",
"argType": "number"
}
]
@@ -370,7 +370,7 @@
"name": "performance_stop_trace",
"args": [
{
- "name": "filePath_length",
+ "name": "file_path_length",
"argType": "number"
}
]
@@ -383,7 +383,7 @@
"argType": "number"
},
{
- "name": "includeSnapshot",
+ "name": "include_snapshot",
"argType": "boolean"
}
]
@@ -431,11 +431,11 @@
"name": "select_page",
"args": [
{
- "name": "pageId",
+ "name": "page_id",
"argType": "number"
},
{
- "name": "bringToFront",
+ "name": "bring_to_front",
"argType": "boolean"
}
]
@@ -444,7 +444,7 @@
"name": "take_memory_snapshot",
"args": [
{
- "name": "filePath_length",
+ "name": "file_path_length",
"argType": "number"
}
]
@@ -461,11 +461,11 @@
"argType": "number"
},
{
- "name": "fullPage",
+ "name": "full_page",
"argType": "boolean"
},
{
- "name": "filePath_length",
+ "name": "file_path_length",
"argType": "number"
}
]
@@ -478,7 +478,7 @@
"argType": "boolean"
},
{
- "name": "filePath_length",
+ "name": "file_path_length",
"argType": "number"
}
]
@@ -500,7 +500,7 @@
"argType": "number"
},
{
- "name": "submitKey_length",
+ "name": "submit_key_length",
"argType": "number"
}
]
@@ -518,11 +518,11 @@
"name": "upload_file",
"args": [
{
- "name": "filePath_length",
+ "name": "file_path_length",
"argType": "number"
},
{
- "name": "includeSnapshot",
+ "name": "include_snapshot",
"argType": "boolean"
}
]
diff --git a/tests/telemetry/ClearcutLogger.test.ts b/tests/telemetry/ClearcutLogger.test.ts
index 79220285..3f49d6de 100644
--- a/tests/telemetry/ClearcutLogger.test.ts
+++ b/tests/telemetry/ClearcutLogger.test.ts
@@ -191,11 +191,11 @@ describe('ClearcutLogger', () => {
const sanitized = sanitizeParams(params, schema);
assert.deepStrictEqual(sanitized, {
- myString_length: 5,
- myArray_count: 2,
- myNumber: 42,
- myBool: true,
- myEnum: 'a',
+ my_string_length: 5,
+ my_array_count: 2,
+ my_number: 42,
+ my_bool: true,
+ my_enum: 'a',
});
});
diff --git a/tests/telemetry/toolMetricsUtils.test.ts b/tests/telemetry/toolMetricsUtils.test.ts
index 0c369aae..2a3fa53b 100644
--- a/tests/telemetry/toolMetricsUtils.test.ts
+++ b/tests/telemetry/toolMetricsUtils.test.ts
@@ -55,7 +55,7 @@ describe('toolMetricsUtils', () => {
assert.strictEqual(metrics.length, 1);
assert.strictEqual(metrics[0].name, 'test_tool');
assert.strictEqual(metrics[0].args.length, 1); // uid is blocked
- assert.strictEqual(metrics[0].args[0].name, 'argStr_length');
+ assert.strictEqual(metrics[0].args[0].name, 'arg_str_length');
assert.strictEqual(metrics[0].args[0].argType, 'number');
});
@@ -77,7 +77,7 @@ describe('toolMetricsUtils', () => {
const metrics = generateToolMetrics([mockTool]);
assert.strictEqual(metrics.length, 1);
- assert.strictEqual(metrics[0].args[0].name, 'argEnum');
+ assert.strictEqual(metrics[0].args[0].name, 'arg_enum');
assert.strictEqual(metrics[0].args[0].argType, 'string');
});
});