Chrome DevTools for coding agents
fix: pass categoryExtensions to the target filter when connecting (#3047)
Aviad Pineles4e90238fa177
diff --git a/src/BrowserManager.ts b/src/BrowserManager.tsindex 409f1da6..73ac8936 100644--- a/src/BrowserManager.ts+++ b/src/BrowserManager.ts@@ -336,12 +336,13 @@ export class BrowserManager {userDataDir,blockedUrlPattern: blocklist,allowedUrlPattern: allowlist,+ categoryExtensions: enableExtensions,} = this.#serverArgs;// Important: only pass channel, if autoConnect is true.const channel = isAutoConnect ? this.#serverArgs.channel : undefined;const connectOptions: Parameters<typeof puppeteer.connect>[0] = {- targetFilter: BrowserManager.makeTargetFilter(),+ targetFilter: BrowserManager.makeTargetFilter(enableExtensions),defaultViewport: null,handleDevToolsAsPage: true,blocklist,diff --git a/tests/browser.test.ts b/tests/browser.test.tsindex 4585cc99..9ab00c39 100644--- a/tests/browser.test.ts+++ b/tests/browser.test.ts@@ -18,6 +18,7 @@ import {puppeteer, type Browser} from '../src/third_party/index.js';import {createMockParsedArguments,createMockPuppeteerBrowser,+ createMockPuppeteerTarget,} from './mocks.js';import {serverHooks} from './server.js';@@ -149,6 +150,27 @@ describe('browser', () => {sinon.assert.notCalled(pptrBrowser.close);});+ for (const categoryExtensions of [false, true]) {+ it(`${categoryExtensions ? 'keeps' : 'drops'} extension targets when connecting with categoryExtensions=${categoryExtensions}`, async () => {+ const connectStub = sinon+ .stub(puppeteer, 'connect')+ .resolves(createMockPuppeteerBrowser());++ const args = createMockParsedArguments({+ browserUrl: 'http://127.0.0.1:9222',+ categoryExtensions,+ });+ await new BrowserManager(args).ensureBrowser();++ const {targetFilter} = connectStub.firstCall.args[0];+ assert.ok(targetFilter);+ const target = createMockPuppeteerTarget({+ url: 'chrome-extension://abcdefgh/popup.html',+ });+ assert.strictEqual(targetFilter(target), categoryExtensions);+ });+ }+it('deduplicates concurrent ensureBrowser() calls while launch is in-flight', async () => {const pptrBrowser = createMockPuppeteerBrowser();const {promise, resolve} = Promise.withResolvers<Browser>();