Skip to content

Chrome DevTools for coding agents

refactor: remove redundant validatePath calls (#2136)

Alex Rudenko521c388624d4
diff --git a/src/McpContext.ts b/src/McpContext.ts
index 2a4e1da9..fe288c6c 100644
--- a/src/McpContext.ts
+++ b/src/McpContext.ts
@@ -830,7 +830,6 @@ export class McpContext implements Context {
}
async installExtension(extensionPath: string): Promise<string> {
- await this.validatePath(extensionPath);
const id = await this.browser.installExtension(extensionPath);
return id;
}
@@ -861,21 +860,18 @@ export class McpContext implements Context {
async getHeapSnapshotAggregates(
filePath: string,
): Promise<Record<string, AggregatedInfoWithId>> {
- await this.validatePath(filePath);
return await this.#heapSnapshotManager.getAggregates(filePath);
}
async getHeapSnapshotStats(
filePath: string,
): Promise<DevTools.HeapSnapshotModel.HeapSnapshotModel.Statistics> {
- await this.validatePath(filePath);
return await this.#heapSnapshotManager.getStats(filePath);
}
async getHeapSnapshotStaticData(
filePath: string,
): Promise<DevTools.HeapSnapshotModel.HeapSnapshotModel.StaticData | null> {
- await this.validatePath(filePath);
return await this.#heapSnapshotManager.getStaticData(filePath);
}
@@ -883,7 +879,6 @@ export class McpContext implements Context {
filePath: string,
id: number,
): Promise<DevTools.HeapSnapshotModel.HeapSnapshotModel.ItemsRange> {
- await this.validatePath(filePath);
return await this.#heapSnapshotManager.getNodesById(filePath, id);
}
@@ -891,7 +886,6 @@ export class McpContext implements Context {
filePath: string,
nodeId: number,
): Promise<DevTools.HeapSnapshotModel.HeapSnapshotModel.ItemsRange> {
- await this.validatePath(filePath);
return await this.#heapSnapshotManager.getRetainers(filePath, nodeId);
}
}
diff --git a/src/tools/extensions.ts b/src/tools/extensions.ts
index 58460ae3..f0656ded 100644
--- a/src/tools/extensions.ts
+++ b/src/tools/extensions.ts
@@ -24,6 +24,7 @@ export const installExtension = defineTool({
blockedByDialog: false,
handler: async (request, response, context) => {
const {path} = request.params;
+ await context.validatePath(path);
const id = await context.installExtension(path);
response.appendResponseLine(`Extension installed. Id: ${id}`);
},
@@ -79,6 +80,7 @@ export const reloadExtension = defineTool({
if (!extension) {
throw new Error(`Extension with ID ${id} not found.`);
}
+ await context.validatePath(extension.path);
await context.installExtension(extension.path);
response.appendResponseLine('Extension reloaded.');
},