Chrome DevTools for coding agents
fix: stop active screencast on McpPage.dispose() (#3160)
Nikolay Vitkov558af8196fc2
diff --git a/src/McpPage.ts b/src/McpPage.tsindex 8dd6ed05..71c8a255 100644--- a/src/McpPage.ts+++ b/src/McpPage.ts@@ -676,6 +676,13 @@ export class McpPage implements ContextPage {this.#disposed = true;this.#commentBridge?.dispose();this.#commentBridge = undefined;+ if (this.#screenRecorder) {+ const {recorder} = this.#screenRecorder;+ this.#screenRecorder = null;+ void recorder.stop().catch(e => {+ logger?.('Failed to stop screencast recording on dispose', e);+ });+ }this.#pptrPage?.off('dialog', this.#dialogHandler);this.#networkCollector?.dispose();this.#consoleCollector?.dispose();diff --git a/tests/McpPage.test.ts b/tests/McpPage.test.tsindex 6d44b800..5220948a 100644--- a/tests/McpPage.test.ts+++ b/tests/McpPage.test.ts@@ -11,7 +11,7 @@ import sinon from 'sinon';import type {TargetUniverse} from '../src/devtools/DevtoolsUtils.js';import {McpPage, replaceHtmlElementsWithUids} from '../src/McpPage.js';-import {DevTools, Locator} from '../src/third_party/index.js';+import {DevTools, Locator, ScreenRecorder} from '../src/third_party/index.js';import type {JSONSchema7Definition} from '../src/third_party/index.js';import {TextSnapshot} from '../src/TextSnapshot.js';import type {TextSnapshotNode} from '../src/types.js';@@ -394,6 +394,22 @@ describe('McpPage', () => {});sinon.assert.notCalled(pptrPage.emulateFocusedPage);});++ it('stops and clears an active screenRecorder on dispose()', async () => {+ const target = createMockPuppeteerTarget();+ const mcpPage = new McpPage(target, 1, {+ hasNetworkBlockOrAllowlist: false,+ locatorClass: Locator,+ });+ const recorder = sinon.createStubInstance(ScreenRecorder);+ recorder.stop.resolves();+ mcpPage.setScreenRecorder({recorder, filePath: '/tmp/video.mp4'});++ mcpPage.dispose();++ sinon.assert.calledOnceWithExactly(recorder.stop);+ assert.strictEqual(mcpPage.getScreenRecorder(), null);+ });});describe('getTitle()', () => {