Skip to content

Chrome DevTools for coding agents

refactor(config): isolate scripts and unit tests from home config discovery (#3256)

Nikolay Vitkov65e6b97afdcf
diff --git a/scripts/generate-cli.ts b/scripts/generate-cli.ts
index 367ad99c..231e8d73 100644
--- a/scripts/generate-cli.ts
+++ b/scripts/generate-cli.ts
@@ -12,7 +12,7 @@ import {
categoryToFlagName,
} from '../build/src/config/category-options.js';
import {mcpOptions} from '../build/src/config/mcp-options.js';
-import {ConfigParser} from '../build/src/config/ConfigParser.js';
+import {ServerConfig} from '../build/src/config/ServerConfig.js';
import {zod} from '../build/src/third_party/index.js';
import {labels, ToolCategory} from '../build/src/tools/categories.js';
import {isSlimTool} from '../build/src/tools/ToolDefinition.js';
@@ -78,7 +78,10 @@ function schemaToCLIOptions(toolName: string, schema: JsonSchema): CliOption[] {
async function generateCli() {
const tools = createTools(
- new ConfigParser('0.0.0', ['', '', '--viaCli']).parse(),
+ ServerConfig.applyDefaults(
+ {viaCli: true},
+ {suppressUsageStatisticsNotice: true},
+ ),
);
// Sort tools by name
diff --git a/scripts/update_metrics.ts b/scripts/update_metrics.ts
index a027f71a..4e798339 100644
--- a/scripts/update_metrics.ts
+++ b/scripts/update_metrics.ts
@@ -8,7 +8,7 @@ import * as fs from 'node:fs';
import * as path from 'node:path';
import {mcpOptions} from '../build/src/config/mcp-options.js';
-import {ConfigParser} from '../build/src/config/ConfigParser.js';
+import {ServerConfig} from '../build/src/config/ServerConfig.js';
import {ErrorCode} from '../build/src/telemetry/errors.js';
import {
getPossibleFlagMetrics,
@@ -36,8 +36,9 @@ function writeToolCallMetricsConfig() {
throw new Error(`Error: Directory ${dir} does not exist.`);
}
- // Avoid 'as ParsedArguments' by using parseArguments
- const allTools = createTools(new ConfigParser('0.0.0', ['', '']).parse());
+ const allTools = createTools(
+ ServerConfig.applyDefaults({}, {suppressUsageStatisticsNotice: true}),
+ );
if (!haveUniqueNames(allTools)) {
throw new Error('Error: Duplicate tool names found.');
diff --git a/tests/ToolHandler.test.ts b/tests/ToolHandler.test.ts
index f6ec6d97..978bba46 100644
--- a/tests/ToolHandler.test.ts
+++ b/tests/ToolHandler.test.ts
@@ -12,6 +12,7 @@ import {pathToFileURL} from 'node:url';
import sinon from 'sinon';
+import {ConfigLocator} from '../src/config/ConfigLocator.js';
import {ConfigParser} from '../src/config/ConfigParser.js';
import type {McpContext} from '../src/McpContext.js';
import {McpPage} from '../src/McpPage.js';
@@ -50,9 +51,17 @@ describe('ToolHandler', () => {
});
function parseConfig(argv: string[] = []) {
- return new ConfigParser('1.0.0', ['node', 'script.js', ...argv], {
- CHROME_DEVTOOLS_MCP_NO_USAGE_STATISTICS: 'true',
- }).parseConfig();
+ const locator = new ConfigLocator();
+ sinon.stub(locator, 'locate').returns(undefined);
+ return new ConfigParser(
+ '1.0.0',
+ ['node', 'script.js', ...argv],
+ {
+ CHROME_DEVTOOLS_MCP_NO_USAGE_STATISTICS: 'true',
+ },
+ false,
+ locator,
+ ).parseConfig();
}
it('calls getPageById for page scoped tools when pageId is provided', async () => {
diff --git a/tests/cli.test.ts b/tests/cli.test.ts
index a2202811..3507042e 100644
--- a/tests/cli.test.ts
+++ b/tests/cli.test.ts
@@ -8,6 +8,9 @@ import assert from 'node:assert';
import path from 'node:path';
import {describe, it} from 'node:test';
+import sinon from 'sinon';
+
+import {ConfigLocator} from '../src/config/ConfigLocator.js';
import {ConfigParser} from '../src/config/ConfigParser.js';
import {
getCliOptions,
@@ -26,11 +29,14 @@ import {puppeteerOptions} from '../src/config/puppeteer-options.js';
import {createTempFile} from './utils.js';
function parseConfig(argv: string[], env: NodeJS.ProcessEnv = {}) {
+ const locator = new ConfigLocator();
+ sinon.stub(locator, 'locate').returns(undefined);
return new ConfigParser(
'0.0.0',
['node', 'main.js', ...argv],
env,
false,
+ locator,
).parse();
}
diff --git a/tests/tools/pages.test.ts b/tests/tools/pages.test.ts
index 9baf4c36..16552f19 100644
--- a/tests/tools/pages.test.ts
+++ b/tests/tools/pages.test.ts
@@ -11,7 +11,6 @@ import {describe, it} from 'node:test';
import type {Dialog} from 'puppeteer-core';
import sinon from 'sinon';
-import {ConfigParser} from '../../src/config/ConfigParser.js';
import {
listPages,
newPage,
@@ -1204,11 +1203,9 @@ describe('pages', () => {
const defaultTool = navigatePage(createMockParsedArguments());
assert.strictEqual('initScript' in defaultTool.schema, true);
- const disabledArgs = new ConfigParser(
- '1.0.0',
- ['node', 'script.js', '--no-javascript-evaluation'],
- {CHROME_DEVTOOLS_MCP_NO_USAGE_STATISTICS: 'true'},
- ).parse();
+ const disabledArgs = createMockParsedArguments({
+ javascriptEvaluation: false,
+ });
const disabledTool = navigatePage(disabledArgs);
assert.strictEqual('initScript' in disabledTool.schema, false);
});
diff --git a/tests/tools/screencast.test.ts b/tests/tools/screencast.test.ts
index 0792e7cf..9c2e71a9 100644
--- a/tests/tools/screencast.test.ts
+++ b/tests/tools/screencast.test.ts
@@ -12,6 +12,7 @@ import {describe, it} from 'node:test';
import sinon from 'sinon';
+import {ConfigLocator} from '../../src/config/ConfigLocator.js';
import {ConfigParser} from '../../src/config/ConfigParser.js';
import {
CdpScreenRecording,
@@ -22,7 +23,15 @@ import {createHandlerMocks} from '../mocks.js';
import {createTempDir, html, withMcpContext} from '../utils.js';
function parseArgs(...argv: string[]) {
- return new ConfigParser('test', ['node', 'test', ...argv]).parse();
+ const locator = new ConfigLocator();
+ sinon.stub(locator, 'locate').returns(undefined);
+ return new ConfigParser(
+ 'test',
+ ['node', 'test', ...argv],
+ {CHROME_DEVTOOLS_MCP_NO_USAGE_STATISTICS: 'true'},
+ false,
+ locator,
+ ).parse();
}
function createScreencastMocks() {
diff --git a/tests/tools/slim/tools.test.ts b/tests/tools/slim/tools.test.ts
index d701030a..277a9c4d 100644
--- a/tests/tools/slim/tools.test.ts
+++ b/tests/tools/slim/tools.test.ts
@@ -11,9 +11,8 @@ import {describe, it} from 'node:test';
import sinon from 'sinon';
-import {ConfigParser} from '../../../src/config/ConfigParser.js';
import {evaluate, navigate, screenshot} from '../../../src/tools/slim/tools.js';
-import {createHandlerMocks} from '../../mocks.js';
+import {createHandlerMocks, createMockParsedArguments} from '../../mocks.js';
import {screenshots} from '../../snapshot.js';
import {withMcpContext} from '../../utils.js';
@@ -85,11 +84,10 @@ describe('slim', () => {
it('disallows javascript, data, and vbscript URLs when javascriptEvaluation is false', async () => {
const {page, context, response} = createHandlerMocks();
- const disabledArgs = new ConfigParser(
- '1.0.0',
- ['node', 'script.js', '--slim', '--no-javascript-evaluation'],
- {CHROME_DEVTOOLS_MCP_NO_USAGE_STATISTICS: 'true'},
- ).parse();
+ const disabledArgs = createMockParsedArguments({
+ slim: true,
+ javascriptEvaluation: false,
+ });
const tool = navigate(disabledArgs);
await assert.rejects(
async () => {
@@ -136,11 +134,10 @@ describe('slim', () => {
it('disallows file URLs when fileNavigations is false', async () => {
const {page, context, response} = createHandlerMocks();
- const disabledArgs = new ConfigParser(
- '1.0.0',
- ['node', 'script.js', '--slim', '--no-file-navigations'],
- {CHROME_DEVTOOLS_MCP_NO_USAGE_STATISTICS: 'true'},
- ).parse();
+ const disabledArgs = createMockParsedArguments({
+ slim: true,
+ fileNavigations: false,
+ });
const tool = navigate(disabledArgs);
await assert.rejects(
async () => {
diff --git a/tests/tools/tools.test.ts b/tests/tools/tools.test.ts
index 6e6545ff..298126b5 100644
--- a/tests/tools/tools.test.ts
+++ b/tests/tools/tools.test.ts
@@ -7,16 +7,12 @@
import assert from 'node:assert';
import {describe, it} from 'node:test';
-import {ConfigParser} from '../../src/config/ConfigParser.js';
import {createTools} from '../../src/tools/tools.js';
+import {createMockParsedArguments} from '../mocks.js';
describe('createTools', () => {
it('has unique tool names', () => {
- const serverArgs = new ConfigParser(
- '0.0.0',
- ['node', 'script.js'],
- {},
- ).parse();
+ const serverArgs = createMockParsedArguments();
const names = createTools(serverArgs).map(tool => tool.name);