Skip to content

Chrome DevTools for coding agents

chore: bucketize days_since_last_active. (#2697)

yulunz6e53015a1642
diff --git a/src/telemetry/ClearcutLogger.ts b/src/telemetry/ClearcutLogger.ts
index 5305bec5..2f20f4f7 100644
--- a/src/telemetry/ClearcutLogger.ts
+++ b/src/telemetry/ClearcutLogger.ts
@@ -13,6 +13,7 @@ import {logger} from '../utils/logger.js';
import type {ErrorCode} from './errors.js';
import type {LocalState, Persistence} from './persistence.js';
import {
+ bucketizeDaysSince,
bucketizeLatency,
buildContext,
sanitizeParams,
@@ -187,7 +188,7 @@ export class ClearcutLogger {
payload: {
mcp_client: this.#mcpClient,
daily_active: {
- days_since_last_active: daysSince,
+ days_since_last_active: bucketizeDaysSince(daysSince),
},
},
});
diff --git a/src/telemetry/transformation.ts b/src/telemetry/transformation.ts
index a57f44a2..37eeb8ec 100644
--- a/src/telemetry/transformation.ts
+++ b/src/telemetry/transformation.ts
@@ -21,6 +21,12 @@ export function bucketizeLatency(latencyMs: number): number {
return LATENCY_BUCKETS[LATENCY_BUCKETS.length - 1];
}
+export const MAX_ACTIVE_DAYS = 31;
+
+export function bucketizeDaysSince(days: number): number {
+ return Math.min(days, MAX_ACTIVE_DAYS);
+}
+
export const PARAM_BLOCKLIST = new Set(['uid', 'reqid', 'msgid']);
const SUPPORTED_ZOD_TYPES = [
diff --git a/tests/telemetry/ClearcutLogger.test.ts b/tests/telemetry/ClearcutLogger.test.ts
index 56113327..6000cdf5 100644
--- a/tests/telemetry/ClearcutLogger.test.ts
+++ b/tests/telemetry/ClearcutLogger.test.ts
@@ -252,10 +252,33 @@ describe('ClearcutLogger', () => {
const msg = mockWatchdogClient.send.firstCall.args[0];
assert.strictEqual(msg.type, WatchdogMessageType.LOG_EVENT);
assert.ok(msg.payload.daily_active);
+ assert.ok(msg.payload.daily_active.days_since_last_active !== undefined);
assert(mockPersistence.saveState.called);
});
+ it('caps days_since_last_active at 31 if lastActive was > 30 days ago', async () => {
+ const longAgo = new Date();
+ longAgo.setDate(longAgo.getDate() - 45);
+ mockPersistence.loadState.resolves({
+ lastActive: longAgo.toISOString(),
+ });
+
+ const logger = ClearcutLogger.initialize({
+ persistence: mockPersistence,
+ appVersion: '1.0.0',
+ watchdogClient: mockWatchdogClient,
+ });
+
+ await logger.logDailyActiveIfNeeded();
+
+ assert(mockWatchdogClient.send.calledOnce);
+ const msg = mockWatchdogClient.send.firstCall.args[0];
+ assert.strictEqual(msg.type, WatchdogMessageType.LOG_EVENT);
+ assert.strictEqual(msg.payload.daily_active?.days_since_last_active, 31);
+ assert(mockPersistence.saveState.called);
+ });
+
it('does not log daily active if not needed (today)', async () => {
mockPersistence.loadState.resolves({
lastActive: new Date().toISOString(),
diff --git a/tests/telemetry/transformation.test.ts b/tests/telemetry/transformation.test.ts
index 690f7f38..244c9b19 100644
--- a/tests/telemetry/transformation.test.ts
+++ b/tests/telemetry/transformation.test.ts
@@ -8,9 +8,11 @@ import assert from 'node:assert';
import {describe, it} from 'node:test';
import {
+ bucketizeDaysSince,
bucketizeLatency,
buildContext,
getEnumValues,
+ MAX_ACTIVE_DAYS,
sanitizeParams,
stripUnderscoreBeforeNumber,
transformArgName,
@@ -81,6 +83,28 @@ describe('bucketizeLatency', () => {
});
});
+describe('bucketizeDaysSince', () => {
+ it('should bucketize days correctly', () => {
+ const testCases = [
+ {input: -1, expected: -1},
+ {input: 0, expected: 0},
+ {input: 1, expected: 1},
+ {input: 7, expected: 7},
+ {input: 14, expected: 14},
+ {input: 30, expected: 30},
+ {input: 31, expected: 31},
+ {input: MAX_ACTIVE_DAYS, expected: 31},
+ {input: 32, expected: 31},
+ {input: 45, expected: 31},
+ {input: 100, expected: 31},
+ ];
+
+ for (const {input, expected} of testCases) {
+ assert.strictEqual(bucketizeDaysSince(input), expected);
+ }
+ });
+});
+
describe('sanitizeParams', () => {
it('filters out uid and transforms strings and arrays', () => {
const schema = {