Chrome DevTools for coding agents
chore: make json file for flag usage metrics append only (#1882)
yulunz7b3b4d306efa
diff --git a/scripts/update_flag_usage_metrics.ts b/scripts/update_flag_usage_metrics.tsindex bde7304b..8e0f4ffd 100644--- a/scripts/update_flag_usage_metrics.ts+++ b/scripts/update_flag_usage_metrics.ts@@ -12,6 +12,7 @@ import {getPossibleFlagMetrics,type FlagMetric,} from '../build/src/telemetry/flagUtils.js';+import {applyToExisting} from '../build/src/telemetry/toolMetricsUtils.js';function writeFlagUsageMetrics() {const outputPath = path.resolve('src/telemetry/flag_usage_metrics.json');@@ -21,15 +22,29 @@ function writeFlagUsageMetrics() {throw new Error(`Error: Directory ${dir} does not exist.`);}- const metrics = getPossibleFlagMetrics(cliOptions);+ let existingMetrics: FlagMetric[] = [];+ if (fs.existsSync(outputPath)) {+ try {+ existingMetrics = JSON.parse(+ fs.readFileSync(outputPath, 'utf8'),+ ) as FlagMetric[];+ } catch {+ console.warn(+ `Warning: Failed to parse existing metrics from ${outputPath}. Starting fresh.`,+ );+ }+ }- // Sort metrics by name for deterministic output- metrics.sort((a: FlagMetric, b: FlagMetric) => a.name.localeCompare(b.name));+ const newMetrics = getPossibleFlagMetrics(cliOptions);+ const mergedMetrics = applyToExisting<FlagMetric>(+ existingMetrics,+ newMetrics,+ );- fs.writeFileSync(outputPath, JSON.stringify(metrics, null, 2) + '\n');+ fs.writeFileSync(outputPath, JSON.stringify(mergedMetrics, null, 2) + '\n');console.log(- `Successfully wrote ${metrics.length} flag usage metrics to ${outputPath}`,+ `Successfully wrote ${mergedMetrics.length} flag usage metrics to ${outputPath}`,);}diff --git a/src/telemetry/toolMetricsUtils.ts b/src/telemetry/toolMetricsUtils.tsindex 53783645..74f2af42 100644--- a/src/telemetry/toolMetricsUtils.ts+++ b/src/telemetry/toolMetricsUtils.ts@@ -62,10 +62,9 @@ export function applyToExistingMetrics(});}-function applyToExisting<T extends {name: string; isDeprecated?: boolean}>(- existing: T[],- update: T[],-): T[] {+export function applyToExisting<+ T extends {name: string; isDeprecated?: boolean},+>(existing: T[], update: T[]): T[] {const existingNames = new Set(existing.map(item => item.name));const updatedNames = new Set(update.map(item => item.name));