Chrome DevTools for coding agents
chore: expose loadResouce HostBinding (#2194)
Nikolay Vitkov834b259eb211
diff --git a/src/McpContext.ts b/src/McpContext.tsindex 061e1e5a..756ad007 100644--- a/src/McpContext.ts+++ b/src/McpContext.ts@@ -113,7 +113,11 @@ export class McpContext implements Context {options: McpContextOptions,locatorClass: typeof Locator,) {- overrideDevToolsGlobals();+ overrideDevToolsGlobals({+ loadResource: (url: string) => {+ return this.loadResource(url);+ },+ });this.browser = browser;this.logger = logger;@@ -940,4 +944,28 @@ export class McpContext implements Context {maxSiblings,);}++ async loadResource(path: string): Promise<string> {+ const url = new URL(path);++ switch (url.protocol) {+ case 'https:':+ case 'http:': {+ // TODO: Verify allow/block list+ const response = await fetch(url);+ if (!response.ok) {+ throw new Error(`Failed to load resource: ${url}`);+ }+ return response.text();+ }++ case 'file:': {+ await this.validatePath(fileURLToPath(url));+ return await fsPromises.readFile(url, 'utf-8');+ }++ default:+ throw new Error(`Unsupported protocol for: ${url}`);+ }+ }}diff --git a/src/devtools/DevtoolsUtils.ts b/src/devtools/DevtoolsUtils.tsindex 5f130a15..0e54b113 100644--- a/src/devtools/DevtoolsUtils.ts+++ b/src/devtools/DevtoolsUtils.ts@@ -29,9 +29,13 @@ export class FakeIssuesManager extends DevTools.Common.ObjectWrapper}}-export function overrideDevToolsGlobals(): void {+export function overrideDevToolsGlobals({+ loadResource,+}: {+ loadResource: (url: string) => Promise<string>;+}): void {DevTools.Host.InspectorFrontendHost.installInspectorFrontendHost(- new McpHostBindingAdapter(),+ new McpHostBindingAdapter(loadResource),);// DevTools CDP errors can get noisy.diff --git a/src/devtools/McpHostBindingAdapter.ts b/src/devtools/McpHostBindingAdapter.tsindex b4574bad..c7966220 100644--- a/src/devtools/McpHostBindingAdapter.ts+++ b/src/devtools/McpHostBindingAdapter.ts@@ -6,7 +6,7 @@/* eslint-disable @typescript-eslint/no-empty-function */-import type {DevTools} from '../third_party/index.js';+import {DevTools} from '../third_party/index.js';/*** BaseClass that is noop or throws for methods.@@ -218,10 +218,24 @@ class BaseMcpHostBindingAdapterrequestRestart(): void {}- loadNetworkResource(): void {}+ loadNetworkResource(+ _urlString: string,+ _headers: string,+ _streamId: number,+ _callback: (+ arg0: DevTools.Host.InspectorFrontendHostAPI.LoadNetworkResourceResult,+ ) => void,+ ): void {}}export class McpHostBindingAdapter extends BaseMcpHostBindingAdapter {+ #loadResource: (path: string) => Promise<string>;++ constructor(loadResource: (path: string) => Promise<string>) {+ super();+ this.#loadResource = loadResource;+ }+override isolatedFileSystem(): null {return null;}@@ -249,7 +263,29 @@ export class McpHostBindingAdapter extends BaseMcpHostBindingAdapter {return Promise.resolve(null);}- override loadNetworkResource(): void {- // TODO(nvitkov): Add support for this+ override loadNetworkResource(+ urlString: string,+ _headers: string,+ streamId: number,+ callback: (+ arg0: DevTools.Host.InspectorFrontendHostAPI.LoadNetworkResourceResult,+ ) => void,+ ): void {+ if (!URL.canParse(urlString)) {+ callback({+ statusCode: 404,+ urlValid: false,+ });+ return;+ }++ this.#loadResource(urlString)+ .then(content => {+ DevTools.Host.ResourceLoader.streamWrite(streamId, content);+ callback({statusCode: 200});+ })+ .catch(() => {+ callback({statusCode: 404});+ });}}diff --git a/tests/McpContext.test.ts b/tests/McpContext.test.tsindex 52e2293f..5424600c 100644--- a/tests/McpContext.test.ts+++ b/tests/McpContext.test.ts@@ -298,4 +298,22 @@ describe('McpContext', () => {);});});++ describe('loadResource', () => {+ it('file protocol calls validatePath', async () => {+ await withMcpContext(async (_response, context) => {+ const validatePathSpy = sinon.spy(context, 'validatePath');+ const testFilePath = path.join(os.tmpdir(), 'load-resource-test.txt');+ await fs.writeFile(testFilePath, 'test content');+ try {+ const url = pathToFileURL(testFilePath).href;+ const content = await context.loadResource(url);+ assert.strictEqual(content, 'test content');+ sinon.assert.calledWith(validatePathSpy, testFilePath);+ } finally {+ await fs.rm(testFilePath, {force: true});+ }+ });+ });+ });});diff --git a/tests/setup.ts b/tests/setup.tsindex ed916290..5d3b4c28 100644--- a/tests/setup.ts+++ b/tests/setup.ts@@ -12,7 +12,9 @@ import {before, it} from 'node:test';import {overrideDevToolsGlobals} from '../src/devtools/DevtoolsUtils.js';before(() => {- overrideDevToolsGlobals();+ overrideDevToolsGlobals({+ loadResource: async () => '',+ });});// This is run by Node when we execute the tests via the --import flag.