Chrome DevTools for coding agents
fix: clamp async stack trace separator repeat count (#3035)
yulunz93e06ab21f18
diff --git a/src/formatters/ConsoleFormatter.ts b/src/formatters/ConsoleFormatter.tsindex aada6a3b..9375f233 100644--- a/src/formatters/ConsoleFormatter.ts+++ b/src/formatters/ConsoleFormatter.ts@@ -438,7 +438,8 @@ function formatAsyncFragment(const separatorLineLength = 40;const prefix = `--- ${fragment.description || 'async'} `;- const separator = prefix + '-'.repeat(separatorLineLength - prefix.length);+ const separator =+ prefix + '-'.repeat(Math.max(0, separatorLineLength - prefix.length));return [separator, ...formattedFrames];}diff --git a/tests/formatters/ConsoleFormatter.test.js.snapshot b/tests/formatters/ConsoleFormatter.test.js.snapshotindex be885953..376e9d24 100644--- a/tests/formatters/ConsoleFormatter.test.js.snapshot+++ b/tests/formatters/ConsoleFormatter.test.js.snapshot@@ -321,6 +321,27 @@ at schedule (util.ts:5:2)Note: line and column numbers use 1-based indexing`;+exports[`ConsoleFormatter > toStringDetailed/toJSONDetailed > formats an async fragment with a description longer than the separator line toJSONDetailed 1`] = `+{+ "id": 17,+ "type": "error",+ "text": "TypeError: Cannot read properties of undefined",+ "argsCount": 0,+ "args": [],+ "stackTrace": "at MyVeryLongReactComponentNameThatExceedsFortyCharacters (Component.tsx:10:2)\\n--- <MyVeryLongReactComponentNameThatExceedsFortyCharacters> \\nat App (App.tsx:5:2)\\nNote: line and column numbers use 1-based indexing"+}+`;++exports[`ConsoleFormatter > toStringDetailed/toJSONDetailed > formats an async fragment with a description longer than the separator line toStringDetailed 1`] = `+ID: 17+Message: error> TypeError: Cannot read properties of undefined+### Stack trace+at MyVeryLongReactComponentNameThatExceedsFortyCharacters (Component.tsx:10:2)+--- <MyVeryLongReactComponentNameThatExceedsFortyCharacters>+at App (App.tsx:5:2)+Note: line and column numbers use 1-based indexing+`;+exports[`ConsoleFormatter > toStringDetailed/toJSONDetailed > formats frames without a name or url and unnamed async fragments toJSONDetailed 1`] = `{"id": 16,diff --git a/tests/formatters/ConsoleFormatter.test.ts b/tests/formatters/ConsoleFormatter.test.tsindex e037cc02..4a9065ff 100644--- a/tests/formatters/ConsoleFormatter.test.ts+++ b/tests/formatters/ConsoleFormatter.test.ts@@ -803,5 +803,46 @@ describe('ConsoleFormatter', () => {});},);++ formatterTestDetailed(+ 'formats an async fragment with a description longer than the separator line',+ async () => {+ const message = createMockMessage({+ type: () => 'error',+ text: () => 'TypeError: Cannot read properties of undefined',+ });+ const stackTrace = {+ syncFragment: {+ frames: [+ {+ line: 10,+ column: 2,+ url: 'Component.tsx',+ name: 'MyVeryLongReactComponentNameThatExceedsFortyCharacters',+ },+ ],+ },+ asyncFragments: [+ {+ description:+ '<MyVeryLongReactComponentNameThatExceedsFortyCharacters>',+ frames: [+ {+ line: 5,+ column: 2,+ url: 'App.tsx',+ name: 'App',+ },+ ],+ },+ ],+ } as unknown as DevTools.StackTrace.StackTrace.StackTrace;++ return await ConsoleFormatter.from(message, {+ id: 17,+ resolvedStackTraceForTesting: stackTrace,+ });+ },+ );});});