Skip to content

Chrome DevTools for coding agents

chore(deps): update Puppeteer to v25.17.0 (#3459)

Nikolay Vitkov9d2d2305773c
diff --git a/package-lock.json b/package-lock.json
index e1978059..f688799a 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -36,7 +36,7 @@
"globals": "^17.0.0",
"lighthouse": "13.6.0",
"prettier": "^3.6.2",
- "puppeteer": "25.16.0",
+ "puppeteer": "25.17.0",
"semver": "^7.7.4",
"sinon": "^22.0.0",
"typescript": "npm:@typescript/typescript6@^6.0.2",
@@ -1033,9 +1033,9 @@
"license": "BSD-3-Clause"
},
"node_modules/@puppeteer/browsers": {
- "version": "3.2.6",
- "resolved": "https://registry.npmjs.org/@puppeteer/browsers/-/browsers-3.2.6.tgz",
- "integrity": "sha512-MJP29gVoHznmqmwhH1tlZqzfeQ3aylTpSSa6WKZXtkwYUH02i9imBmWGTyZrbnAou5paX78SE4jMAUqnEPf8ug==",
+ "version": "3.2.7",
+ "resolved": "https://registry.npmjs.org/@puppeteer/browsers/-/browsers-3.2.7.tgz",
+ "integrity": "sha512-B3C/v8OEEaJYcN1IzzgbPmt+GbFANr4Mf/NrqNuGk/dIchrv6quNqxgT+A6qE0Ge0MN95NjKUddcR1JMpYRMWA==",
"dev": true,
"license": "Apache-2.0",
"dependencies": {
@@ -4995,9 +4995,9 @@
"license": "Apache-2.0"
},
"node_modules/lilconfig": {
- "version": "3.1.3",
- "resolved": "https://registry.npmjs.org/lilconfig/-/lilconfig-3.1.3.tgz",
- "integrity": "sha512-/vlFKAoH5Cgt3Ie+JLhRbwOsCQePABiU3tJ1egGvyQ+33R/vcwM2Zl2QR/LzjsBeItPt3oSVXapn+m4nQDvpzw==",
+ "version": "3.1.4",
+ "resolved": "https://registry.npmjs.org/lilconfig/-/lilconfig-3.1.4.tgz",
+ "integrity": "sha512-zJZyBmQhArDRefuWTypZxwDpFDIYmrj8ypSBvwGD5P13Y95s6DjzKgu4DVdGbeQa5PDEsAOCAPNk4X+QOR006w==",
"dev": true,
"license": "MIT",
"engines": {
@@ -5648,18 +5648,18 @@
}
},
"node_modules/puppeteer": {
- "version": "25.16.0",
- "resolved": "https://registry.npmjs.org/puppeteer/-/puppeteer-25.16.0.tgz",
- "integrity": "sha512-LOr3reYnxAYYfQkpopz1fQnL0LdvqhpR5U2Fu+QnwzTX2gpVTHsn91UETo5NNC1md2/oC54Zu1ChBXgZDNSP1A==",
+ "version": "25.17.0",
+ "resolved": "https://registry.npmjs.org/puppeteer/-/puppeteer-25.17.0.tgz",
+ "integrity": "sha512-J+OQNlI7I6ZjHhF6Q8M+LgiUGldF7meer5EqMJBZMHgnFN3zcehOhpz/x0bYDEEvbEiXzKzmqSRP3QT+5accjQ==",
"dev": true,
"hasInstallScript": true,
"license": "Apache-2.0",
"dependencies": {
- "@puppeteer/browsers": "3.2.6",
+ "@puppeteer/browsers": "3.2.7",
"chromium-bidi": "157.0.8090-0",
- "devtools-protocol": "0.0.1704951",
- "lilconfig": "^3.1.3",
- "puppeteer-core": "25.16.0",
+ "devtools-protocol": "0.0.1717327",
+ "lilconfig": "^3.1.4",
+ "puppeteer-core": "25.17.0",
"typed-query-selector": "^2.12.3"
},
"bin": {
@@ -5670,34 +5670,34 @@
}
},
"node_modules/puppeteer-core": {
- "version": "25.16.0",
- "resolved": "https://registry.npmjs.org/puppeteer-core/-/puppeteer-core-25.16.0.tgz",
- "integrity": "sha512-VA5Pf54N8shfopNkZZXCdiiwfnnY8ZJYAMqFQRhlH5mGUhfwf53Ar770GPtdpTDLUqvQeYpIBtC9/G2Jij2IJw==",
+ "version": "25.17.0",
+ "resolved": "https://registry.npmjs.org/puppeteer-core/-/puppeteer-core-25.17.0.tgz",
+ "integrity": "sha512-YAgBitkd+K9gxRt+wzBAFTTkGjkC8aC2o4OxofsU8JUy2nnK/RflTCJ9bRCvCMNbq9TPhqFk4Phz98otN9FrGg==",
"dev": true,
"license": "Apache-2.0",
"dependencies": {
- "@puppeteer/browsers": "3.2.6",
+ "@puppeteer/browsers": "3.2.7",
"chromium-bidi": "157.0.8090-0",
- "devtools-protocol": "0.0.1704951",
+ "devtools-protocol": "0.0.1717327",
"typed-query-selector": "^2.12.3",
- "webdriver-bidi-protocol": "1.0.1",
- "ws": "^8.22.0"
+ "webdriver-bidi-protocol": "1.0.2",
+ "ws": "^8.22.1"
},
"engines": {
"node": ">=22.12.0"
}
},
"node_modules/puppeteer-core/node_modules/devtools-protocol": {
- "version": "0.0.1704951",
- "resolved": "https://registry.npmjs.org/devtools-protocol/-/devtools-protocol-0.0.1704951.tgz",
- "integrity": "sha512-GQhQOs9u/Mvm1zMtJIH872JS4AskuZdUSsPNPk4ChahtWAUqgz6atEtIsMt+nO7MqF1Ic4HxII/k8Cu36JivNg==",
+ "version": "0.0.1717327",
+ "resolved": "https://registry.npmjs.org/devtools-protocol/-/devtools-protocol-0.0.1717327.tgz",
+ "integrity": "sha512-3RDLDzyvv8XAYf1L+TL1og0EEk0eOW1Jn0yi88uG6Bj8fUKO1ZKfgNtwbJkqf5SWdPDS4VGEPxwdUWz78V6Xcg==",
"dev": true,
"license": "BSD-3-Clause"
},
"node_modules/puppeteer/node_modules/devtools-protocol": {
- "version": "0.0.1704951",
- "resolved": "https://registry.npmjs.org/devtools-protocol/-/devtools-protocol-0.0.1704951.tgz",
- "integrity": "sha512-GQhQOs9u/Mvm1zMtJIH872JS4AskuZdUSsPNPk4ChahtWAUqgz6atEtIsMt+nO7MqF1Ic4HxII/k8Cu36JivNg==",
+ "version": "0.0.1717327",
+ "resolved": "https://registry.npmjs.org/devtools-protocol/-/devtools-protocol-0.0.1717327.tgz",
+ "integrity": "sha512-3RDLDzyvv8XAYf1L+TL1og0EEk0eOW1Jn0yi88uG6Bj8fUKO1ZKfgNtwbJkqf5SWdPDS4VGEPxwdUWz78V6Xcg==",
"dev": true,
"license": "BSD-3-Clause"
},
@@ -6705,9 +6705,9 @@
}
},
"node_modules/webdriver-bidi-protocol": {
- "version": "1.0.1",
- "resolved": "https://registry.npmjs.org/webdriver-bidi-protocol/-/webdriver-bidi-protocol-1.0.1.tgz",
- "integrity": "sha512-WXWs/aXF2a6Al1Z2/V/7Gp2oPZOAAmHjJOTmv4KCXRJ122IMj3tSSMc6a4q3K4QOmhQbse/Ahr+oTVJOU2dUiw==",
+ "version": "1.0.2",
+ "resolved": "https://registry.npmjs.org/webdriver-bidi-protocol/-/webdriver-bidi-protocol-1.0.2.tgz",
+ "integrity": "sha512-nghazPI+J5RrLZ+qb6vMjC6l1/tnwqr2muVEax4Ufd6eIdcjeqNnhLsAxTG9s+7Zf4umgf0DrEwDC8CoU91nAA==",
"dev": true,
"license": "Apache-2.0"
},
@@ -6899,9 +6899,9 @@
}
},
"node_modules/ws": {
- "version": "8.22.0",
- "resolved": "https://registry.npmjs.org/ws/-/ws-8.22.0.tgz",
- "integrity": "sha512-Ydggc987+RO0AnWtZ/7Wq9FtNvcrL1b/RO0ud9mWjUPgDrsAAwQSF51sm2hm1XofbU/4jkpGEsLFsZZxU+1DOg==",
+ "version": "8.22.1",
+ "resolved": "https://registry.npmjs.org/ws/-/ws-8.22.1.tgz",
+ "integrity": "sha512-oyL6OPYme/CmiFvNuGzeoxCJ4nOrZE2O1FwM9MWM1AsGri6nLXB2pg+lNA8aLeXMSav0J6eIVS1j6vUPzUtK9g==",
"dev": true,
"license": "MIT",
"engines": {
diff --git a/package.json b/package.json
index 6d664f47..7221a7cf 100644
--- a/package.json
+++ b/package.json
@@ -79,7 +79,7 @@
"globals": "^17.0.0",
"lighthouse": "13.6.0",
"prettier": "^3.6.2",
- "puppeteer": "25.16.0",
+ "puppeteer": "25.17.0",
"semver": "^7.7.4",
"sinon": "^22.0.0",
"typescript": "npm:@typescript/typescript6@^6.0.2",
diff --git a/tests/NetworkOverrideManager.test.ts b/tests/NetworkOverrideManager.test.ts
index 1a58d946..666d1127 100644
--- a/tests/NetworkOverrideManager.test.ts
+++ b/tests/NetworkOverrideManager.test.ts
@@ -17,6 +17,7 @@ import {
createMockServerConfig,
} from './mocks.js';
import {NetworkOverridesFormatter} from '../src/formatters/NetworkOverridesFormatter.js';
+import {settle} from './utils.js';
describe('NetworkOverrideManager', () => {
it('retains existing rules when a replacement URL is blocked', async () => {
@@ -64,7 +65,8 @@ describe('NetworkOverrideManager', () => {
}),
);
const request = createMockHTTPRequest();
- await pptrPage.on.firstCall.args[1](request);
+ pptrPage.emit('request', request);
+ await settle();
sinon.assert.calledOnceWithExactly(
fetch,
new URL('https://allowed.example/replacement.js'),
@@ -95,7 +97,8 @@ describe('NetworkOverrideManager', () => {
);
const request = createMockHTTPRequest();
const fetch = sinon.stub(globalThis, 'fetch');
- await pptrPage.on.firstCall.args[1](request);
+ pptrPage.emit('request', request);
+ await settle();
sinon.assert.calledOnceWithExactly(request.abort, 'failed');
sinon.assert.notCalled(request.continue);
sinon.assert.notCalled(fetch);
@@ -126,7 +129,8 @@ describe('NetworkOverrideManager', () => {
}),
);
const request = createMockHTTPRequest();
- await pptrPage.on.firstCall.args[1](request);
+ pptrPage.emit('request', request);
+ await settle();
sinon.assert.calledWithExactly(
fetch.secondCall,
new URL('https://cdn.example/final'),
@@ -157,7 +161,8 @@ describe('NetworkOverrideManager', () => {
.stub(globalThis, 'fetch')
.rejects(new Error('Failed to fetch ' + upstream));
const request = createMockHTTPRequest();
- await pptrPage.on.firstCall.args[1](request);
+ pptrPage.emit('request', request);
+ await settle();
sinon.assert.calledOnceWithExactly(fetch, new URL(upstream), {
redirect: 'manual',
method: 'GET',
@@ -186,11 +191,11 @@ describe('NetworkOverrideManager', () => {
responseFilePath: '/tmp/replacement.js',
loadResponseFile: async () => new Uint8Array(),
});
- const handle = pptrPage.on.firstCall.args[1];
const request = createMockHTTPRequest();
- await handle(request);
+ pptrPage.emit('request', request);
const unmatched = createMockHTTPRequest({resourceType: 'fetch'});
- await handle(unmatched);
+ pptrPage.emit('request', unmatched);
+ await settle();
assert.deepEqual(manager.list()[0]?.diagnostics, {
hits: 1,
errors: 0,
@@ -225,17 +230,17 @@ describe('NetworkOverrideManager', () => {
/Navigate or reload/,
);
pptrPage.emit('framenavigated', pptrPage.mainFrame());
- const handle = pptrPage.on.firstCall.args[1];
const mainFrame = pptrPage.mainFrame();
const childFrame = createMockPuppeteerPage().mainFrame();
assert.ok(mainFrame instanceof CdpFrame);
assert.ok(childFrame instanceof CdpFrame);
const subframe = createMockHTTPRequest({resourceType: 'document'});
subframe.frame.returns(childFrame);
- await handle(subframe);
+ pptrPage.emit('request', subframe);
const script = createMockHTTPRequest();
script.frame.returns(mainFrame);
- await handle(script);
+ pptrPage.emit('request', script);
+ await settle();
assert.equal(manager.list()[0]?.diagnostics.navigations, 0);
assert.doesNotMatch(
new NetworkOverridesFormatter(manager.list()).toString(),
@@ -243,7 +248,8 @@ describe('NetworkOverrideManager', () => {
);
const document = createMockHTTPRequest({resourceType: 'document'});
document.frame.returns(mainFrame);
- await handle(document);
+ pptrPage.emit('request', document);
+ await settle();
assert.equal(manager.list()[0]?.diagnostics.navigations, 1);
assert.match(
new NetworkOverridesFormatter(manager.list()).toString(),
@@ -273,11 +279,11 @@ describe('NetworkOverrideManager', () => {
responseFilePath: '/tmp/app.js',
loadResponseFile: async () => new Uint8Array(),
});
- const handle = pptrPage.on.firstCall.args[1];
const request = createMockHTTPRequest({
url: 'https://example.com/app.js?v=1',
});
- await handle(request);
+ pptrPage.emit('request', request);
+ await settle();
sinon.assert.calledOnceWithExactly(request.respond, {
status: 200,
contentType: 'application/javascript; charset=utf-8',
@@ -288,7 +294,8 @@ describe('NetworkOverrideManager', () => {
const unmatched = createMockHTTPRequest({
url: 'https://example.com/app.jsxv=1',
});
- await handle(unmatched);
+ pptrPage.emit('request', unmatched);
+ await settle();
sinon.assert.calledOnceWithExactly(unmatched.continue);
sinon.assert.notCalled(unmatched.respond);
await manager.dispose();
@@ -314,7 +321,8 @@ describe('NetworkOverrideManager', () => {
loadResponseFile,
});
const request = createMockHTTPRequest();
- await pptrPage.on.firstCall.args[1](request);
+ pptrPage.emit('request', request);
+ await settle();
assert.deepEqual(manager.list()[0]?.diagnostics, {
hits: 1,
errors: 1,
@@ -544,7 +552,8 @@ describe('NetworkOverrideManager', () => {
);
assert.equal(pptrPage.listenerCount('request'), 1);
const request = createMockHTTPRequest();
- await pptrPage.on.secondCall.args[1](request);
+ pptrPage.emit('request', request);
+ await settle();
sinon.assert.calledOnceWithExactly(request.respond, {
status: 200,
contentType: 'application/javascript; charset=utf-8',
@@ -584,7 +593,8 @@ describe('NetworkOverrideManager', () => {
const request = createMockHTTPRequest({
url: 'http://localhost:8080/app.js?v=1',
});
- await pptrPage.on.firstCall.args[1](request);
+ pptrPage.emit('request', request);
+ await settle();
sinon.assert.calledOnceWithExactly(request.respond, {
status: 200,
contentType: 'application/javascript; charset=utf-8',
@@ -620,7 +630,8 @@ describe('NetworkOverrideManager', () => {
}),
);
const request = createMockHTTPRequest();
- await pptrPage.on.firstCall.args[1](request);
+ pptrPage.emit('request', request);
+ await settle();
sinon.assert.calledOnceWithExactly(
fetch,
new URL('https://example.com/start'),
@@ -664,7 +675,8 @@ describe('NetworkOverrideManager', () => {
Authorization: 'secret',
}),
);
- await pptrPage.on.firstCall.args[1](request);
+ pptrPage.emit('request', request);
+ await settle();
sinon.assert.calledOnceWithExactly(fetch, new URL(upstream), {
redirect: 'manual',
method: 'GET',
@@ -696,7 +708,8 @@ describe('NetworkOverrideManager', () => {
}
sinon.stub(globalThis, 'fetch').resolves(new Response('js', {headers}));
const request = createMockHTTPRequest();
- await pptrPage.on.firstCall.args[1](request);
+ pptrPage.emit('request', request);
+ await settle();
sinon.assert.calledOnceWithExactly(request.respond, {
status: 200,
headers: {
@@ -730,7 +743,8 @@ describe('NetworkOverrideManager', () => {
}),
);
const request = createMockHTTPRequest();
- await pptrPage.on.firstCall.args[1](request);
+ pptrPage.emit('request', request);
+ await settle();
sinon.assert.calledOnceWithExactly(request.respond, {
status: 200,
headers: {
@@ -756,7 +770,8 @@ describe('NetworkOverrideManager', () => {
const fetch = sinon.stub(globalThis, 'fetch');
const request = createMockHTTPRequest();
request.method.returns('POST');
- await pptrPage.on.firstCall.args[1](request);
+ pptrPage.emit('request', request);
+ await settle();
sinon.assert.notCalled(fetch);
sinon.assert.calledOnceWithExactly(request.abort, 'failed');
assert.match(
diff --git a/tests/mocks.ts b/tests/mocks.ts
index b1e89c34..c648e902 100644
--- a/tests/mocks.ts
+++ b/tests/mocks.ts
@@ -24,7 +24,12 @@
import './setupDevTools.js';
-import type {Frame, Mouse, SerializedAXNode} from 'puppeteer-core';
+import {
+ EventEmitter,
+ type Frame,
+ type Mouse,
+ type SerializedAXNode,
+} from 'puppeteer-core';
import sinon from 'sinon';
import type {ParsedArguments} from '../src/config/mcp-options.js';
@@ -146,62 +151,53 @@ export type MockCSSRegisteredProperty =
export type MockCSSFunctionRule =
sinon.SinonStubbedInstance<DevTools.CSSRule.CSSFunctionRule>;
+interface StubbedEventEmitter<Self> {
+ on: sinon.SinonStub<
+ [type: PropertyKey, handler: (event: unknown, eventData: never) => void],
+ Self
+ >;
+ off: sinon.SinonStub<
+ [type: PropertyKey, handler?: (event: unknown, eventData: never) => void],
+ Self
+ >;
+ once: sinon.SinonStub<
+ [type: PropertyKey, handler: (event: unknown, eventData: never) => void],
+ Self
+ >;
+ emit: sinon.SinonStub<[type: PropertyKey, event: unknown], boolean>;
+ listenerCount: sinon.SinonStub<[type: PropertyKey], number>;
+ removeAllListeners: sinon.SinonStub<[type?: PropertyKey], Self>;
+}
+
/**
- * A minimal event emitter used to back mocked `on`/`off`/`emit` methods on
- * Puppeteer objects (Page, CDPSession, Browser) so tests can trigger events
- * synchronously without a real browser.
+ * Wires a Sinon-stubbed Puppeteer EventEmitter subclass to a real Puppeteer
+ * `EventEmitter` instance (`sinon.createStubInstance` skips constructors, so
+ * EventEmitter's private fields are not initialized on the stub itself).
*/
-export function mockListener(): {
- on: (
- eventName: string | symbol | number,
- listener: (data: unknown) => void,
- ) => void;
- off: (
- eventName: string | symbol | number,
- listener?: (data: unknown) => void,
- ) => void;
- emit: (eventName: string | symbol | number, data?: unknown) => void;
- listenerCount: (eventName: string | symbol | number) => number;
-} {
- const listeners: Record<
- string | symbol | number,
- Array<(data: unknown) => void>
- > = {};
- return {
- on(
- eventName: string | symbol | number,
- listener: (data: unknown) => void,
- ): void {
- const arr = listeners[eventName];
- if (arr) {
- arr.push(listener);
- } else {
- listeners[eventName] = [listener];
- }
- },
- off(
- eventName: string | symbol | number,
- listener?: (data: unknown) => void,
- ): void {
- const arr = listeners[eventName];
- if (!arr) {
- return;
- }
- if (!listener) {
- delete listeners[eventName];
- return;
- }
- listeners[eventName] = arr.filter(entry => entry !== listener);
- },
- emit(eventName: string | symbol | number, data?: unknown): void {
- for (const listener of listeners[eventName] ?? []) {
- listener(data);
- }
- },
- listenerCount(eventName: string | symbol | number): number {
- return listeners[eventName]?.length ?? 0;
- },
- };
+function stubEventEmitter<Self>(stub: StubbedEventEmitter<Self> & Self): void {
+ const emitter = new EventEmitter<Record<PropertyKey, unknown>>();
+ stub.on.callsFake((eventName, handler) => {
+ emitter.on(eventName, handler);
+ return stub;
+ });
+ stub.off.callsFake((eventName, handler) => {
+ emitter.off(eventName, handler);
+ return stub;
+ });
+ stub.once.callsFake((eventName, handler) => {
+ emitter.once(eventName, handler);
+ return stub;
+ });
+ stub.emit.callsFake((eventName, data) => {
+ return emitter.emit(eventName, data);
+ });
+ stub.listenerCount.callsFake(eventName => {
+ return emitter.listenerCount(eventName);
+ });
+ stub.removeAllListeners.callsFake(eventName => {
+ emitter.removeAllListeners(eventName);
+ return stub;
+ });
}
export function createMockPuppeteerBrowser(): sinon.SinonStubbedInstance<Browser> {
@@ -216,28 +212,7 @@ export function createMockPuppeteerBrowser(): sinon.SinonStubbedInstance<Browser
browser.targets.returns([]);
browser.browserContexts.returns([]);
browser.process.returns(null);
-
- const browserListener = mockListener();
- browser.on.callsFake((eventName, handler) => {
- browserListener.on(eventName, handler);
- return browser;
- });
- browser.off.callsFake((eventName, handler) => {
- browserListener.off(eventName, handler);
- return browser;
- });
- browser.once.callsFake((eventName, handler) => {
- const onceHandler = (data: unknown) => {
- browserListener.off(eventName, onceHandler);
- handler(data);
- };
- browserListener.on(eventName, onceHandler);
- return browser;
- });
- browser.emit.callsFake((eventName, data) => {
- browserListener.emit(eventName, data);
- return true;
- });
+ stubEventEmitter(browser);
return browser;
}
@@ -268,15 +243,7 @@ export function createMockCDPSession(): sinon.SinonStubbedInstance<MockCDPSessio
session.id.returns('<mock-session-id>');
session.send.resolves();
session.detach.resolves();
- const listener = mockListener();
- session.on.callsFake((eventName, handler) => {
- listener.on(eventName, handler);
- return session;
- });
- session.off.callsFake((eventName, handler) => {
- listener.off(eventName, handler);
- return session;
- });
+ stubEventEmitter(session);
return session;
}
@@ -300,20 +267,7 @@ export function createMockHTTPRequest(
export function createMockPuppeteerPage(): MockPuppeteerPage {
const pptrPage = sinon.createStubInstance(CdpPage);
const page = pptrPage as unknown as sinon.SinonStubbedInstance<Page>;
- const pageListener = mockListener();
- page.listenerCount.callsFake(pageListener.listenerCount);
- page.on.callsFake((eventName, handler) => {
- pageListener.on(eventName, handler);
- return page;
- });
- page.off.callsFake((eventName, handler) => {
- pageListener.off(eventName, handler);
- return page;
- });
- page.emit.callsFake((eventName, data) => {
- pageListener.emit(eventName, data);
- return true;
- });
+ stubEventEmitter(page);
// mainFrame() must return a stable object so tests can pass it back into
// page.emit('framenavigated', mainFrame) and have it recognized as the
@@ -322,19 +276,7 @@ export function createMockPuppeteerPage(): MockPuppeteerPage {
// can trigger it.
const mainFrameStub = sinon.createStubInstance(CdpFrame);
mainFrameStub.page.returns(pptrPage);
- const mainFrameListener = mockListener();
- mainFrameStub.on.callsFake((eventName, handler) => {
- mainFrameListener.on(eventName, handler);
- return mainFrameStub;
- });
- mainFrameStub.off.callsFake((eventName, handler) => {
- mainFrameListener.off(eventName, handler);
- return mainFrameStub;
- });
- mainFrameStub.emit.callsFake((eventName, data) => {
- mainFrameListener.emit(eventName, data);
- return true;
- });
+ stubEventEmitter(mainFrameStub);
// SinonStubbedInstance<CdpFrame> is not assignable to Frame due to private fields.
page.mainFrame.returns(mainFrameStub as unknown as Frame);
@@ -342,13 +284,15 @@ export function createMockPuppeteerPage(): MockPuppeteerPage {
// in the McpPage constructor. Not on the CdpPage prototype, so added
// explicitly. It needs real on/off/emit behavior so tests can trigger CDP
// events directly via cdpSession.emit(...).
- const cdpListener = mockListener();
+ const cdpListener = new EventEmitter<Record<PropertyKey, unknown>>();
const cdpSession = {
- on: sinon.stub().callsFake(cdpListener.on),
- off: sinon.stub().callsFake(cdpListener.off),
+ on: sinon.stub().callsFake(cdpListener.on.bind(cdpListener)),
+ off: sinon.stub().callsFake(cdpListener.off.bind(cdpListener)),
send: sinon.stub().resolves({}),
target: sinon.stub().returns({_targetId: '<mock>'}),
- emit: cdpListener.emit,
+ emit: (eventName: PropertyKey, data?: unknown): void => {
+ cdpListener.emit(eventName, data);
+ },
};
// @ts-expect-error internal API
page._client = sinon.stub().returns(cdpSession);
diff --git a/tests/utils.ts b/tests/utils.ts
index 822417e0..5a0ab2d6 100644
--- a/tests/utils.ts
+++ b/tests/utils.ts
@@ -41,9 +41,9 @@ import {stableIdSymbol} from '../src/utils/id.js';
import {
createMockParsedArguments,
+ createMockPuppeteerBrowser,
createMockPuppeteerPage,
createMockServerConfig,
- mockListener,
stripUndefined,
} from './mocks.js';
@@ -451,31 +451,11 @@ export function getMockBrowser(options?: {
wsEndpoint?: string;
}): Browser {
const page = createMockPuppeteerPage();
- const listener = mockListener();
- page.on.callsFake((eventName, handler) => {
- listener.on(eventName, handler);
- return page;
- });
- page.off.callsFake((eventName, handler) => {
- if (handler) {
- listener.off(eventName, handler);
- }
- return page;
- });
- (page as unknown as {emit: typeof listener.emit}).emit = listener.emit;
- const pages = [page as unknown as Page];
- return {
- process() {
- return options?.process ?? null;
- },
- wsEndpoint() {
- return options?.wsEndpoint ?? '';
- },
- pages() {
- return Promise.resolve(pages);
- },
- ...mockListener(),
- } as Browser;
+ const browser = createMockPuppeteerBrowser();
+ browser.process.returns(options?.process ?? null);
+ browser.wsEndpoint.returns(options?.wsEndpoint ?? '');
+ browser.pages.resolves([page]);
+ return browser;
}
export const CLI_PATH: string = path.resolve(