Skip to content

Chrome DevTools for coding agents

chore: handling more client name enums (#1228)

yulunzb2b5e3fef684
diff --git a/src/daemon/daemon.ts b/src/daemon/daemon.ts
index 35af3cb7..cde62374 100644
--- a/src/daemon/daemon.ts
+++ b/src/daemon/daemon.ts
@@ -21,6 +21,7 @@ import {VERSION} from '../version.js';
import type {DaemonMessage} from './types.js';
import {
+ DAEMON_CLIENT_NAME,
getDaemonPid,
getPidFilePath,
getSocketPath,
@@ -65,7 +66,7 @@ async function setupMCPClient() {
});
mcpClient = new Client(
{
- name: 'chrome-devtools-cli-daemon',
+ name: DAEMON_CLIENT_NAME,
version: VERSION,
},
{
diff --git a/src/daemon/utils.ts b/src/daemon/utils.ts
index fbfe8c49..7b73bc0f 100644
--- a/src/daemon/utils.ts
+++ b/src/daemon/utils.ts
@@ -21,6 +21,7 @@ export const INDEX_SCRIPT_PATH = path.join(
);
const APP_NAME = 'chrome-devtools-mcp';
+export const DAEMON_CLIENT_NAME = 'chrome-devtools-cli-daemon';
// Using these paths due to strict limits on the POSIX socket path length.
export function getSocketPath(): string {
diff --git a/src/telemetry/ClearcutLogger.ts b/src/telemetry/ClearcutLogger.ts
index dfb59245..06cfe8df 100644
--- a/src/telemetry/ClearcutLogger.ts
+++ b/src/telemetry/ClearcutLogger.ts
@@ -6,6 +6,7 @@
import process from 'node:process';
+import {DAEMON_CLIENT_NAME} from '../daemon/utils.js';
import {logger} from '../logger.js';
import type {LocalState, Persistence} from './persistence.js';
@@ -68,6 +69,14 @@ export class ClearcutLogger {
this.#mcpClient = McpClient.MCP_CLIENT_CLAUDE_CODE;
} else if (lowerName.includes('gemini')) {
this.#mcpClient = McpClient.MCP_CLIENT_GEMINI_CLI;
+ } else if (clientName === DAEMON_CLIENT_NAME) {
+ this.#mcpClient = McpClient.MCP_CLIENT_DT_MCP_CLI;
+ } else if (lowerName.includes('openclaw')) {
+ this.#mcpClient = McpClient.MCP_CLIENT_OPENCLAW;
+ } else if (lowerName.includes('codex')) {
+ this.#mcpClient = McpClient.MCP_CLIENT_CODEX;
+ } else if (lowerName.includes('antigravity')) {
+ this.#mcpClient = McpClient.MCP_CLIENT_ANTIGRAVITY;
} else {
this.#mcpClient = McpClient.MCP_CLIENT_OTHER;
}
diff --git a/src/telemetry/types.ts b/src/telemetry/types.ts
index 8d832541..8acb3292 100644
--- a/src/telemetry/types.ts
+++ b/src/telemetry/types.ts
@@ -75,6 +75,10 @@ export enum McpClient {
MCP_CLIENT_UNSPECIFIED = 0,
MCP_CLIENT_CLAUDE_CODE = 1,
MCP_CLIENT_GEMINI_CLI = 2,
+ MCP_CLIENT_DT_MCP_CLI = 4,
+ MCP_CLIENT_OPENCLAW = 5,
+ MCP_CLIENT_CODEX = 6,
+ MCP_CLIENT_ANTIGRAVITY = 7,
MCP_CLIENT_OTHER = 3,
}
diff --git a/tests/telemetry/ClearcutLogger.test.ts b/tests/telemetry/ClearcutLogger.test.ts
index 96068961..36e21bc6 100644
--- a/tests/telemetry/ClearcutLogger.test.ts
+++ b/tests/telemetry/ClearcutLogger.test.ts
@@ -9,6 +9,7 @@ import {describe, it, afterEach, beforeEach} from 'node:test';
import sinon from 'sinon';
+import {DAEMON_CLIENT_NAME} from '../../src/daemon/utils.js';
import {ClearcutLogger} from '../../src/telemetry/ClearcutLogger.js';
import type {Persistence} from '../../src/telemetry/persistence.js';
import {FilePersistence} from '../../src/telemetry/persistence.js';
@@ -55,21 +56,32 @@ describe('ClearcutLogger', () => {
});
describe('setClientName', () => {
- it('appends mapped mcp_client to payload', async () => {
- const logger = new ClearcutLogger({
- persistence: mockPersistence,
- appVersion: '1.0.0',
- watchdogClient: mockWatchdogClient,
+ const clients = [
+ {name: 'claude-code', expected: 1}, // MCP_CLIENT_CLAUDE_CODE
+ {name: 'gemini-cli', expected: 2}, // MCP_CLIENT_GEMINI_CLI
+ {name: DAEMON_CLIENT_NAME, expected: 4}, // MCP_CLIENT_DT_MCP_CLI
+ {name: 'openclaw-browser', expected: 5}, // MCP_CLIENT_OPENCLAW
+ {name: 'codex-mcp-client', expected: 6}, // MCP_CLIENT_CODEX
+ {name: 'antigravity-client', expected: 7}, // MCP_CLIENT_ANTIGRAVITY
+ ];
+
+ for (const {name, expected} of clients) {
+ it(`maps ${name} client correctly`, async () => {
+ const logger = new ClearcutLogger({
+ persistence: mockPersistence,
+ appVersion: '1.0.0',
+ watchdogClient: mockWatchdogClient,
+ });
+
+ logger.setClientName(name);
+ await logger.logServerStart({headless: true});
+
+ assert(mockWatchdogClient.send.calledOnce);
+ const msg = mockWatchdogClient.send.firstCall.args[0];
+ assert.strictEqual(msg.type, WatchdogMessageType.LOG_EVENT);
+ assert.strictEqual(msg.payload.mcp_client, expected);
});
-
- logger.setClientName('gemini-cli-mcp-client');
- await logger.logServerStart({headless: true});
-
- assert(mockWatchdogClient.send.calledOnce);
- const msg = mockWatchdogClient.send.firstCall.args[0];
- assert.strictEqual(msg.type, WatchdogMessageType.LOG_EVENT);
- assert.strictEqual(msg.payload.mcp_client, 2); // 2 is MCP_CLIENT_GEMINI_CLI
- });
+ }
});
describe('logServerStart', () => {