Chrome DevTools for coding agents
chore: implement stack trace formatting for console messages (#738)
Simon Zündb48e10b69c8b
diff --git a/src/formatters/consoleFormatter.ts b/src/formatters/consoleFormatter.tsindex 6111e337..06071c19 100644--- a/src/formatters/consoleFormatter.ts+++ b/src/formatters/consoleFormatter.ts@@ -15,6 +15,7 @@ export interface ConsoleMessageData {count?: number;description?: string;args?: string[];+ stackTrace?: DevTools.StackTrace.StackTrace.StackTrace;}// The short format for a console message, based on a previous format.@@ -46,6 +47,7 @@ export function formatConsoleEventVerbose(`ID: ${msg.consoleMessageStableId}`,`Message: ${msg.type}> ${aggregatedIssue ? formatIssue(aggregatedIssue, msg.description, context) : msg.message}`,aggregatedIssue ? undefined : formatArgs(msg),+ formatStackTrace(msg.stackTrace),].filter(line => !!line);return result.join('\n');}@@ -163,3 +165,42 @@ export function formatIssue(if (result.length === 0) return 'No affected resources found';return result.join('\n');}++function formatStackTrace(+ stackTrace: DevTools.StackTrace.StackTrace.StackTrace | undefined,+): string {+ if (!stackTrace) {+ return '';+ }++ return [+ '### Stack trace',+ formatFragment(stackTrace.syncFragment),+ ...stackTrace.asyncFragments.map(formatAsyncFragment),+ ].join('\n');+}++function formatFragment(+ fragment: DevTools.StackTrace.StackTrace.Fragment,+): string {+ return fragment.frames.map(formatFrame).join('\n');+}++function formatAsyncFragment(+ fragment: DevTools.StackTrace.StackTrace.AsyncFragment,+): string {+ const separatorLineLength = 40;+ const prefix = `--- ${fragment.description || 'async'} `;+ const separator = prefix + '-'.repeat(separatorLineLength - prefix.length);+ return separator + '\n' + formatFragment(fragment);+}++function formatFrame(frame: DevTools.StackTrace.StackTrace.Frame): string {+ let result = `at ${frame.name ?? '<anonymous>'}`;+ if (frame.uiSourceCode) {+ result += ` (${frame.uiSourceCode.displayName()}:${frame.line}:${frame.column})`;+ } else if (frame.url) {+ result += ` (${frame.url}:${frame.line}:${frame.column})`;+ }+ return result;+}diff --git a/src/third_party/devtools.ts b/src/third_party/devtools.tsindex 5e06db4e..d4838b17 100644--- a/src/third_party/devtools.ts+++ b/src/third_party/devtools.ts@@ -7,6 +7,7 @@export type {IssuesManagerEventTypes,CDPConnection,+ StackTrace,} from '../../node_modules/chrome-devtools-frontend/mcp/mcp.js';export {AgentFocus,diff --git a/tests/formatters/consoleFormatter.test.js.snapshot b/tests/formatters/consoleFormatter.test.js.snapshotindex d6803572..411b28e5 100644--- a/tests/formatters/consoleFormatter.test.js.snapshot+++ b/tests/formatters/consoleFormatter.test.js.snapshot@@ -10,6 +10,16 @@ exports[`consoleFormatter > formatConsoleEventShort > formats a console.log messmsgid=2 [log] Processing file: (1 args)`;+exports[`consoleFormatter > formatConsoleEventVerbose > formats a console message with a stack trace 1`] = `+ID: 5+Message: log> Hello stack trace!+### Stack trace+at foo (foo.ts:10:2)+at bar (foo.ts:20:2)+--- setTimeout -------------------------+at schedule (util.ts:5:2)+`;+exports[`consoleFormatter > formatConsoleEventVerbose > formats a console.error message 1`] = `ID: 4Message: error> Something went wrongdiff --git a/tests/formatters/consoleFormatter.test.ts b/tests/formatters/consoleFormatter.test.tsindex 8734a91f..4c7e69b7 100644--- a/tests/formatters/consoleFormatter.test.ts+++ b/tests/formatters/consoleFormatter.test.ts@@ -11,6 +11,7 @@ import {formatConsoleEventShort,formatConsoleEventVerbose,} from '../../src/formatters/consoleFormatter.js';+import type {DevTools} from '../../src/third_party/index.js';import {getMockAggregatedIssue} from '../utils.js';describe('consoleFormatter', () => {@@ -92,6 +93,48 @@ describe('consoleFormatter', () => {const result = formatConsoleEventVerbose(message);t.assert.snapshot?.(result);});++ it('formats a console message with a stack trace', t => {+ const message: ConsoleMessageData = {+ consoleMessageStableId: 5,+ type: 'log',+ message: 'Hello stack trace!',+ args: [],+ stackTrace: {+ syncFragment: {+ frames: [+ {+ line: 10,+ column: 2,+ url: 'foo.ts',+ name: 'foo',+ },+ {+ line: 20,+ column: 2,+ url: 'foo.ts',+ name: 'bar',+ },+ ],+ },+ asyncFragments: [+ {+ description: 'setTimeout',+ frames: [+ {+ line: 5,+ column: 2,+ url: 'util.ts',+ name: 'schedule',+ },+ ],+ },+ ],+ } as unknown as DevTools.StackTrace.StackTrace.StackTrace,+ };+ const result = formatConsoleEventVerbose(message);+ t.assert.snapshot?.(result);+ });});it('formats a console.log message with issue type', t => {