Skip to content

Chrome DevTools for coding agents

fix(network): start an empty request list for navigations without a request (#3357)

Victor Hugo Macedo Paes Lemeb7017767a4b2
diff --git a/src/collectors/PageCollector.ts b/src/collectors/PageCollector.ts
index ae812dc9..145de825 100644
--- a/src/collectors/PageCollector.ts
+++ b/src/collectors/PageCollector.ts
@@ -405,6 +405,9 @@ class PageEventSubscriber {
export class NetworkCollector extends PageCollector<HTTPRequest> {
static readonly MAX_REQUESTS_PER_NAVIGATION = 1_000;
+ /** The navigation request that started the latest navigation, if any. */
+ #navigationRequest?: HTTPRequest;
+
constructor(
page: Page,
{
@@ -432,19 +435,25 @@ export class NetworkCollector extends PageCollector<HTTPRequest> {
override splitAfterNavigation(): void {
const requests = this.storage[0];
+ // A navigation without a request, such as a back/forward cache restore or
+ // about:blank, must not claim the request of the previous navigation.
const lastRequestIdx = requests.findLastIndex(request => {
- return request.frame() === this.pptrPage.mainFrame()
- ? request.isNavigationRequest()
- : false;
+ return (
+ request !== this.#navigationRequest &&
+ request.frame() === this.pptrPage.mainFrame() &&
+ request.isNavigationRequest()
+ );
});
// Keep all requests since the last navigation request including that
// navigation request itself.
// Keep the reference
if (lastRequestIdx !== -1) {
+ this.#navigationRequest = requests[lastRequestIdx];
const fromCurrentNavigation = requests.splice(lastRequestIdx);
this.storage.unshift(fromCurrentNavigation);
} else {
+ this.#navigationRequest = undefined;
this.storage.unshift([]);
}
this.storage.splice(this.maxNavigationSaved);
diff --git a/tests/collectors/PageCollector.test.ts b/tests/collectors/PageCollector.test.ts
index 8c749b04..97ee4c26 100644
--- a/tests/collectors/PageCollector.test.ts
+++ b/tests/collectors/PageCollector.test.ts
@@ -374,6 +374,27 @@ describe('NetworkCollector', () => {
assert.strictEqual(collector.getData().length, 2);
});
+ it('lists no requests after a navigation without a request', () => {
+ const pptrPage = createMockPuppeteerPage();
+ const mainFrame = pptrPage.mainFrame();
+ const navRequest = getMockRequest({
+ navigationRequest: true,
+ frame: mainFrame,
+ });
+ const request = getMockRequest();
+ const collector = new NetworkCollector(pptrPage);
+
+ pptrPage.emit('request', navRequest);
+ pptrPage.emit('framenavigated', mainFrame);
+ pptrPage.emit('request', request);
+ // A back/forward cache restore or about:blank commits without a request.
+ pptrPage.emit('framenavigated', mainFrame);
+
+ assert.deepStrictEqual(collector.getData(), []);
+ assert.deepStrictEqual(collector.getData(true), [navRequest, request]);
+ collector.dispose();
+ });
+
it('works with previous navigations', async () => {
const browser = getMockBrowser();
const page = (await browser.pages())[0];