Skip to content

Chrome DevTools for coding agents

perf(memory): drop async parents of request initiators in NetworkCollector (#3345)

Thomas Bachemca6f83498014
diff --git a/src/collectors/PageCollector.ts b/src/collectors/PageCollector.ts
index 25c87dcb..ae812dc9 100644
--- a/src/collectors/PageCollector.ts
+++ b/src/collectors/PageCollector.ts
@@ -416,6 +416,12 @@ export class NetworkCollector extends PageCollector<HTTPRequest> {
) => ListenerMap<PageEvents> = collect => {
return {
request: req => {
+ // With the debugger `createTargetUniverse()` starts, initiator stacks
+ // carry up to 32 async parents, which no tool reads.
+ const stack = req.initiator()?.stack;
+ if (stack) {
+ delete stack.parent;
+ }
collect(req);
},
} as ListenerMap;
diff --git a/tests/collectors/PageCollector.test.ts b/tests/collectors/PageCollector.test.ts
index 477a5be3..8c749b04 100644
--- a/tests/collectors/PageCollector.test.ts
+++ b/tests/collectors/PageCollector.test.ts
@@ -253,6 +253,33 @@ describe('NetworkCollector', () => {
collector.dispose();
});
+ it('drops the async parents of a request initiator stack', () => {
+ const pptrPage = createMockPuppeteerPage();
+ const collector = new NetworkCollector(pptrPage);
+ const frame: Protocol.Runtime.CallFrame = {
+ functionName: 'poll',
+ scriptId: '1',
+ url: 'https://example.com/app.js',
+ lineNumber: 0,
+ columnNumber: 0,
+ };
+ const request = getMockRequest({
+ initiator: {
+ type: 'script',
+ stack: {
+ callFrames: [frame],
+ parent: {description: 'setTimeout', callFrames: [frame]},
+ },
+ },
+ });
+ pptrPage.emit('request', request);
+ assert.deepStrictEqual(request.initiator(), {
+ type: 'script',
+ stack: {callFrames: [frame]},
+ });
+ collector.dispose();
+ });
+
it('retains only the newest requests without navigation', async () => {
const browser = getMockBrowser();
const page = (await browser.pages())[0];
diff --git a/tests/utils.ts b/tests/utils.ts
index 504896c1..4786359c 100644
--- a/tests/utils.ts
+++ b/tests/utils.ts
@@ -23,6 +23,7 @@ import type {
HTTPResponse,
LaunchOptions,
Page,
+ Protocol,
Target,
} from 'puppeteer-core';
import sinon from 'sinon';
@@ -277,6 +278,7 @@ export function getMockRequest(
frame?: Frame;
redirectChain?: HTTPRequest[];
headers?: Record<string, string>;
+ initiator?: Protocol.Network.Initiator;
} = {},
): HTTPRequest {
return {
@@ -323,6 +325,9 @@ export function getMockRequest(
frame() {
return options.frame ?? ({} as Frame);
},
+ initiator() {
+ return options.initiator;
+ },
[stableIdSymbol]: options.stableId ?? 1,
} as unknown as HTTPRequest;
}