Skip to content

Chrome DevTools for coding agents

test: replace assert.equal with assert.strictEqual (#3299)

Nikolay Vitkovd0a2306ea981
diff --git a/tests/McpResponse.test.ts b/tests/McpResponse.test.ts
index 8e80ed95..d234f389 100644
--- a/tests/McpResponse.test.ts
+++ b/tests/McpResponse.test.ts
@@ -169,7 +169,7 @@ describe('McpResponse', () => {
await withMcpContext(async (response, context) => {
response.setIncludePages(true);
const {content, structuredContent} = await response.handle(context);
- assert.equal(content[0].type, 'text');
+ assert.strictEqual(content[0].type, 'text');
t.assert.snapshot(getTextContent(content[0]));
t.assert.snapshot(stabilizeStructuredContent(structuredContent));
});
@@ -206,7 +206,7 @@ describe('McpResponse', () => {
response.appendResponseLine('Testing 1');
response.appendResponseLine('Testing 2');
const {content, structuredContent} = await response.handle(context);
- assert.equal(content[0].type, 'text');
+ assert.strictEqual(content[0].type, 'text');
t.assert.snapshot(getTextContent(content[0]));
t.assert.snapshot(stabilizeStructuredContent(structuredContent));
});
@@ -253,7 +253,7 @@ describe('McpResponse', () => {
await page.focus('input');
response.includeSnapshot();
const {content, structuredContent} = await response.handle(context);
- assert.equal(content[0].type, 'text');
+ assert.strictEqual(content[0].type, 'text');
t.assert.snapshot(getTextContent(content[0]));
t.assert.snapshot(stabilizeStructuredContent(structuredContent));
});
@@ -267,7 +267,7 @@ describe('McpResponse', () => {
verbose: true,
});
const {content, structuredContent} = await response.handle(context);
- assert.equal(content[0].type, 'text');
+ assert.strictEqual(content[0].type, 'text');
t.assert.snapshot(getTextContent(content[0]));
t.assert.snapshot(stabilizeStructuredContent(structuredContent));
});
@@ -284,7 +284,7 @@ describe('McpResponse', () => {
filePath,
});
const {content, structuredContent} = await response.handle(context);
- assert.equal(content[0].type, 'text');
+ assert.strictEqual(content[0].type, 'text');
t.assert.snapshot(stabilizeResponseOutput(getTextContent(content[0])));
t.assert.snapshot(stabilizeStructuredContent(structuredContent));
});
@@ -433,7 +433,7 @@ describe('McpResponse', () => {
.getSelectedMcpPage()
.emulate({networkConditions: 'Slow 3G'});
const {content, structuredContent} = await response.handle(context);
- assert.equal(content[0].type, 'text');
+ assert.strictEqual(content[0].type, 'text');
t.assert.snapshot(getTextContent(content[0]));
t.assert.snapshot(stabilizeStructuredContent(structuredContent));
},
@@ -454,7 +454,7 @@ describe('McpResponse', () => {
response.attachImage({data: 'imageBase64', mimeType: 'image/png'});
const {content, structuredContent} = await response.handle(context);
t.assert.snapshot(getTextContent(content[0]));
- assert.equal(content[1].type, 'image');
+ assert.strictEqual(content[1].type, 'image');
assert.strictEqual(getImageContent(content[1]).data, 'imageBase64');
assert.strictEqual(getImageContent(content[1]).mimeType, 'image/png');
t.assert.snapshot(stabilizeStructuredContent(structuredContent));
diff --git a/tests/McpWorker.test.ts b/tests/McpWorker.test.ts
index 29fe8071..0dbebd2e 100644
--- a/tests/McpWorker.test.ts
+++ b/tests/McpWorker.test.ts
@@ -13,15 +13,15 @@ import {createMockTarget, createMockWebWorker} from './mocks.js';
describe('McpWorker', () => {
it('labels ids by worker type', () => {
- assert.equal(workerIdPrefix('service_worker'), 'sw');
- assert.equal(workerIdPrefix('dedicated_worker'), 'dw');
- assert.equal(workerIdPrefix('shared_worker'), 'shw');
+ assert.strictEqual(workerIdPrefix('service_worker'), 'sw');
+ assert.strictEqual(workerIdPrefix('dedicated_worker'), 'dw');
+ assert.strictEqual(workerIdPrefix('shared_worker'), 'shw');
});
it('exposes the id and type it was created with', () => {
const worker = new McpWorker('sw-3', 'service_worker', createMockTarget());
- assert.equal(worker.id, 'sw-3');
- assert.equal(worker.type, 'service_worker');
+ assert.strictEqual(worker.id, 'sw-3');
+ assert.strictEqual(worker.type, 'service_worker');
});
it('reads url from the target rather than a cached copy', () => {
@@ -32,15 +32,15 @@ describe('McpWorker', () => {
.onSecondCall()
.returns('chrome-extension://abc/second.js');
const worker = new McpWorker('sw-1', 'service_worker', target);
- assert.equal(worker.url, 'chrome-extension://abc/first.js');
- assert.equal(worker.url, 'chrome-extension://abc/second.js');
+ assert.strictEqual(worker.url, 'chrome-extension://abc/first.js');
+ assert.strictEqual(worker.url, 'chrome-extension://abc/second.js');
});
it('coerces a missing worker execution context to undefined', async () => {
const target = createMockTarget();
target.worker.resolves(null);
const worker = new McpWorker('sw-1', 'service_worker', target);
- assert.equal(await worker.worker(), undefined);
+ assert.strictEqual(await worker.worker(), undefined);
});
it('returns the underlying WebWorker when the target has one', async () => {
@@ -48,6 +48,6 @@ describe('McpWorker', () => {
const target = createMockTarget();
target.worker.resolves(webWorker);
const worker = new McpWorker('sw-1', 'service_worker', target);
- assert.equal(await worker.worker(), webWorker);
+ assert.strictEqual(await worker.worker(), webWorker);
});
});
diff --git a/tests/collectors/PageCollector.test.ts b/tests/collectors/PageCollector.test.ts
index e0200058..05f583d1 100644
--- a/tests/collectors/PageCollector.test.ts
+++ b/tests/collectors/PageCollector.test.ts
@@ -78,7 +78,7 @@ describe('PageCollector', () => {
page.emit('request', request);
- assert.equal(collector.getData()[0], request);
+ assert.strictEqual(collector.getData()[0], request);
});
it('clean up after navigation', async () => {
@@ -96,10 +96,10 @@ describe('PageCollector', () => {
page.emit('request', request);
- assert.equal(collector.getData()[0], request);
+ assert.strictEqual(collector.getData()[0], request);
page.emit('framenavigated', mainFrame);
- assert.equal(collector.getData().length, 0);
+ assert.strictEqual(collector.getData().length, 0);
});
it('does not clean up after same-document navigation', async () => {
@@ -117,14 +117,14 @@ describe('PageCollector', () => {
page.emit('request', request);
- assert.equal(collector.getData()[0], request);
+ assert.strictEqual(collector.getData()[0], request);
// Simulate a same-document (SPA) navigation: Puppeteer emits
// `FrameNavigatedWithinDocument` right before `framenavigated`.
mainFrame.emit(FrameEvent.FrameNavigatedWithinDocument, undefined);
page.emit('framenavigated', mainFrame);
- assert.equal(collector.getData()[0], request);
+ assert.strictEqual(collector.getData()[0], request);
});
it('cleans up after a cross-document navigation following a same-document one', async () => {
@@ -145,11 +145,11 @@ describe('PageCollector', () => {
// Same-document navigation: history is kept.
mainFrame.emit(FrameEvent.FrameNavigatedWithinDocument, undefined);
page.emit('framenavigated', mainFrame);
- assert.equal(collector.getData()[0], request);
+ assert.strictEqual(collector.getData()[0], request);
// A real cross-document navigation must still rotate the history.
page.emit('framenavigated', mainFrame);
- assert.equal(collector.getData().length, 0);
+ assert.strictEqual(collector.getData().length, 0);
});
it('does not clean up after sub frame navigation', async () => {
@@ -167,7 +167,7 @@ describe('PageCollector', () => {
page.emit('request', request);
page.emit('framenavigated', {} as Frame);
- assert.equal(collector.getData().length, 1);
+ assert.strictEqual(collector.getData().length, 1);
});
it('clean up after navigation and be able to add data after', async () => {
@@ -185,14 +185,14 @@ describe('PageCollector', () => {
page.emit('request', request);
- assert.equal(collector.getData()[0], request);
+ assert.strictEqual(collector.getData()[0], request);
page.emit('framenavigated', mainFrame);
- assert.equal(collector.getData().length, 0);
+ assert.strictEqual(collector.getData().length, 0);
page.emit('request', request);
- assert.equal(collector.getData().length, 1);
+ assert.strictEqual(collector.getData().length, 1);
});
it('should assign ids to requests', async () => {
@@ -211,10 +211,10 @@ describe('PageCollector', () => {
page.emit('request', request1);
page.emit('request', request2);
- assert.equal(collector.getData().length, 2);
+ assert.strictEqual(collector.getData().length, 2);
- assert.equal(collector.getIdForResource(request1), 1);
- assert.equal(collector.getIdForResource(request2), 2);
+ assert.strictEqual(collector.getIdForResource(request1), 1);
+ assert.strictEqual(collector.getIdForResource(request2), 2);
});
});
@@ -270,13 +270,13 @@ describe('NetworkCollector', () => {
}
const retainedRequests = collector.getData();
- assert.equal(
+ assert.strictEqual(
retainedRequests.length,
NetworkCollector.MAX_REQUESTS_PER_NAVIGATION,
);
assert.deepEqual(retainedRequests, requests.slice(1));
- assert.equal(collector.getIdForResource(retainedRequests[0]), 2);
- assert.equal(collector.getById(2), retainedRequests[0]);
+ assert.strictEqual(collector.getIdForResource(retainedRequests[0]), 2);
+ assert.strictEqual(collector.getById(2), retainedRequests[0]);
assert.throws(() => collector.getById(1), {
message: 'Request not found for selected page',
});
@@ -297,18 +297,18 @@ describe('NetworkCollector', () => {
page.emit('request', request);
page.emit('request', navRequest);
- assert.equal(collector.getData()[0], request);
- assert.equal(collector.getData()[1], navRequest);
+ assert.strictEqual(collector.getData()[0], request);
+ assert.strictEqual(collector.getData()[1], navRequest);
page.emit('framenavigated', mainFrame);
- assert.equal(collector.getData().length, 1);
- assert.equal(collector.getData()[0], navRequest);
+ assert.strictEqual(collector.getData().length, 1);
+ assert.strictEqual(collector.getData()[0], navRequest);
page.emit('request', request2);
- assert.equal(collector.getData().length, 2);
- assert.equal(collector.getData()[0], navRequest);
- assert.equal(collector.getData()[1], request2);
+ assert.strictEqual(collector.getData().length, 2);
+ assert.strictEqual(collector.getData()[0], navRequest);
+ assert.strictEqual(collector.getData()[1], request2);
});
it('correctly picks up after multiple back to back navigations', async () => {
@@ -328,23 +328,23 @@ describe('NetworkCollector', () => {
const collector = new NetworkCollector(page);
page.emit('request', navRequest);
- assert.equal(collector.getData()[0], navRequest);
+ assert.strictEqual(collector.getData()[0], navRequest);
page.emit('framenavigated', mainFrame);
- assert.equal(collector.getData().length, 1);
- assert.equal(collector.getData()[0], navRequest);
+ assert.strictEqual(collector.getData().length, 1);
+ assert.strictEqual(collector.getData()[0], navRequest);
page.emit('request', navRequest2);
- assert.equal(collector.getData().length, 2);
- assert.equal(collector.getData()[0], navRequest);
- assert.equal(collector.getData()[1], navRequest2);
+ assert.strictEqual(collector.getData().length, 2);
+ assert.strictEqual(collector.getData()[0], navRequest);
+ assert.strictEqual(collector.getData()[1], navRequest2);
page.emit('framenavigated', mainFrame);
- assert.equal(collector.getData().length, 1);
- assert.equal(collector.getData()[0], navRequest2);
+ assert.strictEqual(collector.getData().length, 1);
+ assert.strictEqual(collector.getData()[0], navRequest2);
page.emit('request', request);
- assert.equal(collector.getData().length, 2);
+ assert.strictEqual(collector.getData().length, 2);
});
it('works with previous navigations', async () => {
@@ -364,19 +364,19 @@ describe('NetworkCollector', () => {
const collector = new NetworkCollector(page);
page.emit('request', navRequest);
- assert.equal(collector.getData(true).length, 1);
+ assert.strictEqual(collector.getData(true).length, 1);
page.emit('framenavigated', mainFrame);
- assert.equal(collector.getData(true).length, 1);
+ assert.strictEqual(collector.getData(true).length, 1);
page.emit('request', navRequest2);
- assert.equal(collector.getData(true).length, 2);
+ assert.strictEqual(collector.getData(true).length, 2);
page.emit('framenavigated', mainFrame);
- assert.equal(collector.getData(true).length, 2);
+ assert.strictEqual(collector.getData(true).length, 2);
page.emit('request', request);
- assert.equal(collector.getData(true).length, 3);
+ assert.strictEqual(collector.getData(true).length, 3);
});
it('should not grow beyond maxNavigationSaved', async () => {
@@ -398,7 +398,7 @@ describe('NetworkCollector', () => {
// We expect 3 arrays in navigations (current + 2 saved)
// Each navigation has 1 request, so total should be 3
- assert.equal(collector.getData(true).length, 3);
+ assert.strictEqual(collector.getData(true).length, 3);
});
it('respects a custom maxNavigationSaved', async () => {
@@ -417,7 +417,7 @@ describe('NetworkCollector', () => {
page.emit('framenavigated', mainFrame);
}
- assert.equal(collector.getData(true).length, 5);
+ assert.strictEqual(collector.getData(true).length, 5);
});
it('bounds retained navigation buckets with redirects and subframes', async () => {
@@ -494,8 +494,8 @@ describe('NetworkCollector', () => {
finalResource1,
finalResource2,
]);
- assert.equal(collector.getData().length, 3);
- assert.equal(collector.getData()[0], finalNavigation);
+ assert.strictEqual(collector.getData().length, 3);
+ assert.strictEqual(collector.getData()[0], finalNavigation);
assert.deepEqual(collector.navigationSizes, [3, 2, 2]);
});
});
@@ -579,7 +579,7 @@ describe('ConsoleCollector', () => {
page.emit('issue', issue);
page.emit('issue', issue2);
const data = collector.getData();
- assert.equal(data.length, 2);
+ assert.strictEqual(data.length, 2);
});
it('silently ignores unmapped PerformanceIssue events', async () => {
@@ -606,7 +606,7 @@ describe('ConsoleCollector', () => {
page.emit('issue', performanceIssue);
- assert.equal(collector.getData().length, 0);
+ assert.strictEqual(collector.getData().length, 0);
sinon.assert.notCalled(warnStub);
});
@@ -625,11 +625,11 @@ describe('ConsoleCollector', () => {
page.emit('issue', issue);
page.emit('issue', issue);
const data = collector.getData();
- assert.equal(data.length, 1);
+ assert.strictEqual(data.length, 1);
const collectedIssue = data[0];
assert(collectedIssue instanceof DevTools.AggregatedIssue);
- assert.equal(collectedIssue.code(), 'MixedContentIssue');
- assert.equal(collectedIssue.getAggregatedIssuesCount(), 1);
+ assert.strictEqual(collectedIssue.code(), 'MixedContentIssue');
+ assert.strictEqual(collectedIssue.getAggregatedIssuesCount(), 1);
});
it('emits UncaughtErrors for Runtime.exceptionThrown CDP events', async () => {
@@ -689,7 +689,7 @@ describe('ConsoleCollector', () => {
}
const retained = collector.getData();
- assert.equal(retained.length, cap);
+ assert.strictEqual(retained.length, cap);
assert.deepEqual(retained, messages.slice(messages.length - cap));
});
@@ -713,7 +713,7 @@ describe('ConsoleCollector', () => {
page.emit('console', msg);
}
- assert.equal(
+ assert.strictEqual(
collector.getData().length,
ConsoleCollector.MAX_MESSAGES_PER_NAVIGATION,
);
diff --git a/tests/formatters/HeapSnapshotFormatter.test.ts b/tests/formatters/HeapSnapshotFormatter.test.ts
index b31b3291..7175b68a 100644
--- a/tests/formatters/HeapSnapshotFormatter.test.ts
+++ b/tests/formatters/HeapSnapshotFormatter.test.ts
@@ -192,8 +192,8 @@ describe('HeapSnapshotFormatter', () => {
const summarizedJson = JSON.stringify(summarized);
assert.ok(summarizedJson);
- assert.equal(summarizedJson.includes('addedIndexes'), false);
- assert.equal(summarizedJson.includes('deletedIndexes'), false);
+ assert.strictEqual(summarizedJson.includes('addedIndexes'), false);
+ assert.strictEqual(summarizedJson.includes('deletedIndexes'), false);
});
it('truncates className according to maxNameLength', () => {
diff --git a/tests/formatters/NetworkFormatter.test.ts b/tests/formatters/NetworkFormatter.test.ts
index 27af395a..861b6eef 100644
--- a/tests/formatters/NetworkFormatter.test.ts
+++ b/tests/formatters/NetworkFormatter.test.ts
@@ -25,7 +25,7 @@ describe('NetworkFormatter', () => {
redactNetworkHeaders: false,
});
- assert.equal(
+ assert.strictEqual(
formatter.toString(),
'reqid=1 GET http://example.com [pending]',
);
@@ -38,7 +38,7 @@ describe('NetworkFormatter', () => {
redactNetworkHeaders: false,
});
- assert.equal(
+ assert.strictEqual(
formatter.toString(),
'reqid=1 POST http://example.com [pending]',
);
@@ -52,7 +52,7 @@ describe('NetworkFormatter', () => {
redactNetworkHeaders: false,
});
- assert.equal(
+ assert.strictEqual(
formatter.toString(),
'reqid=1 GET http://example.com [200]',
);
@@ -68,7 +68,7 @@ describe('NetworkFormatter', () => {
redactNetworkHeaders: false,
});
- assert.equal(
+ assert.strictEqual(
formatter.toString(),
'reqid=1 GET http://example.com [199]',
);
@@ -84,7 +84,7 @@ describe('NetworkFormatter', () => {
redactNetworkHeaders: false,
});
- assert.equal(
+ assert.strictEqual(
formatter.toString(),
'reqid=1 GET http://example.com [300]',
);
@@ -103,7 +103,7 @@ describe('NetworkFormatter', () => {
redactNetworkHeaders: false,
});
- assert.equal(
+ assert.strictEqual(
formatter.toString(),
'reqid=1 GET http://example.com [Error in Network]',
);
@@ -118,7 +118,7 @@ describe('NetworkFormatter', () => {
redactNetworkHeaders: false,
});
- assert.equal(
+ assert.strictEqual(
formatter.toString(),
'reqid=1 GET http://example.com [pending] [selected in the DevTools Network panel]',
);
@@ -133,12 +133,12 @@ describe('NetworkFormatter', () => {
redactNetworkHeaders: false,
});
- assert.equal(
+ assert.strictEqual(
formatter.toString(),
`reqid=1 GET ${longUrl.substring(0, 255)}... <truncated> [pending]`,
);
// The structured data keeps the full URL.
- assert.equal(formatter.toJSON().url, longUrl);
+ assert.strictEqual(formatter.toJSON().url, longUrl);
});
it('does not split a surrogate pair when truncating a url', async () => {
@@ -152,7 +152,7 @@ describe('NetworkFormatter', () => {
redactNetworkHeaders: false,
});
- assert.equal(
+ assert.strictEqual(
formatter.toString(),
`reqid=1 GET ${prefix}... <truncated> [pending]`,
);
@@ -167,7 +167,7 @@ describe('NetworkFormatter', () => {
redactNetworkHeaders: false,
});
- assert.equal(
+ assert.strictEqual(
formatter.toString(),
`reqid=1 GET ${dataUrl.substring(0, 255)}... <truncated> [pending]`,
);
@@ -183,7 +183,7 @@ describe('NetworkFormatter', () => {
redactNetworkHeaders: false,
});
- assert.equal(formatter.toString(), `reqid=1 GET ${url} [pending]`);
+ assert.strictEqual(formatter.toString(), `reqid=1 GET ${url} [pending]`);
});
});
diff --git a/tests/network_blocking.test.ts b/tests/network_blocking.test.ts
index ff996d24..3bd9ab77 100644
--- a/tests/network_blocking.test.ts
+++ b/tests/network_blocking.test.ts
@@ -393,7 +393,7 @@ describe('Network Blocking Integration', () => {
context,
);
- assert.equal(
+ assert.strictEqual(
response.attachedLighthouseResult?.summary.mode,
'navigation',
);
diff --git a/tests/processors/HeapSnapshotManager.test.ts b/tests/processors/HeapSnapshotManager.test.ts
index 1f8e2222..d9029b39 100644
--- a/tests/processors/HeapSnapshotManager.test.ts
+++ b/tests/processors/HeapSnapshotManager.test.ts
@@ -92,8 +92,8 @@ describe('HeapSnapshotManager', () => {
);
assert.ok(firstNewObjectDiff);
assert.ok(secondNewObjectDiff);
- assert.equal(firstNewObjectDiff.addedCount, 7);
- assert.equal(secondNewObjectDiff.addedCount, 5);
+ assert.strictEqual(firstNewObjectDiff.addedCount, 7);
+ assert.strictEqual(secondNewObjectDiff.addedCount, 5);
});
it('throws when getDetailedClassDiff is called with an invalid classIndex', async () => {
diff --git a/tests/telemetry/flagUtils.test.ts b/tests/telemetry/flagUtils.test.ts
index 4e6af00b..3629cdbb 100644
--- a/tests/telemetry/flagUtils.test.ts
+++ b/tests/telemetry/flagUtils.test.ts
@@ -38,32 +38,32 @@ describe('computeFlagUsage', () => {
it('logs boolean flags directly with snake_case keys', () => {
const args = {boolFlag: true};
const usage = computeFlagUsage(args, mockOptions);
- assert.equal(usage.bool_flag, true);
+ assert.strictEqual(usage.bool_flag, true);
});
it('logs boolean flags as false when false', () => {
const args = {boolFlag: false};
const usage = computeFlagUsage(args, mockOptions);
- assert.equal(usage.bool_flag, false);
+ assert.strictEqual(usage.bool_flag, false);
});
it('logs enum flags as uppercase strings prefixed by snake case flag name', () => {
const args = {enumFlag: 'a'};
const usage = computeFlagUsage(args, mockOptions);
- assert.equal(usage.enum_flag, 'ENUM_FLAG_A');
+ assert.strictEqual(usage.enum_flag, 'ENUM_FLAG_A');
});
it('logs other flags as present with snake_case keys', () => {
const args = {stringFlag: 'value'};
const usage = computeFlagUsage(args, mockOptions);
- assert.equal(usage.string_flag, undefined);
- assert.equal(usage.string_flag_present, true);
+ assert.strictEqual(usage.string_flag, undefined);
+ assert.strictEqual(usage.string_flag_present, true);
});
it('handles undefined/null values', () => {
const args = {stringFlag: undefined};
const usage = computeFlagUsage(args, mockOptions);
- assert.equal(usage.string_flag_present, false);
+ assert.strictEqual(usage.string_flag_present, false);
});
describe('defaults behavior', () => {
@@ -72,8 +72,8 @@ describe('computeFlagUsage', () => {
// default is false, user provides true.
const args = {flagWithDefault: true};
const usage = computeFlagUsage(args, mockOptions);
- assert.equal(usage.flag_with_default, true);
- assert.equal(usage.flag_with_default_present, true);
+ assert.strictEqual(usage.flag_with_default, true);
+ assert.strictEqual(usage.flag_with_default_present, true);
});
it('does not log presence when default exists and user provides no value', () => {
@@ -81,30 +81,30 @@ describe('computeFlagUsage', () => {
// Argument parsing would populate with default.
const args = {flagWithDefault: false};
const usage = computeFlagUsage(args, mockOptions);
- assert.equal(usage.flag_with_default, false);
- assert.equal(usage.flag_with_default_present, undefined);
+ assert.strictEqual(usage.flag_with_default, false);
+ assert.strictEqual(usage.flag_with_default_present, undefined);
});
it('does not log presence when default exists and user explicitly provides the default value', () => {
// Case 2b: User explicitly provides 'false', which matches default.
const args = {flagWithDefault: false};
const usage = computeFlagUsage(args, mockOptions);
- assert.equal(usage.flag_with_default, false);
- assert.equal(usage.flag_with_default_present, undefined);
+ assert.strictEqual(usage.flag_with_default, false);
+ assert.strictEqual(usage.flag_with_default_present, undefined);
});
it('logs presence when no default exists and user provides value', () => {
// Case 3: No default, user provides value.
const args = {stringFlag: 'value'};
const usage = computeFlagUsage(args, mockOptions);
- assert.equal(usage.string_flag_present, true);
+ assert.strictEqual(usage.string_flag_present, true);
});
it('logs non-presence when no default exists and user provides no value', () => {
// Case 4: No default, user provides nothing.
const args = {};
const usage = computeFlagUsage(args, mockOptions);
- assert.equal(usage.string_flag_present, false);
+ assert.strictEqual(usage.string_flag_present, false);
});
it('sanitizes flag names containing underscores before numbers', () => {
@@ -116,7 +116,7 @@ describe('computeFlagUsage', () => {
} as unknown as typeof mcpOptions;
const args = {experimental3pTool: true};
const usage = computeFlagUsage(args, mock3pOptions);
- assert.equal(usage.experimental3p_tool, true);
+ assert.strictEqual(usage.experimental3p_tool, true);
});
});
});
diff --git a/tests/tools/lighthouse.test.ts b/tests/tools/lighthouse.test.ts
index 874fdecd..414c7d77 100644
--- a/tests/tools/lighthouse.test.ts
+++ b/tests/tools/lighthouse.test.ts
@@ -46,8 +46,8 @@ describe('lighthouse', () => {
maxTouchPoints: navigator.maxTouchPoints,
}));
const emulated = await readViewport();
- assert.equal(emulated.width, 390);
- assert.equal(emulated.deviceScaleFactor, 3);
+ assert.strictEqual(emulated.width, 390);
+ assert.strictEqual(emulated.deviceScaleFactor, 3);
assert.ok(emulated.maxTouchPoints > 0);
await lighthouseAudit(args).handler(
@@ -70,10 +70,13 @@ describe('lighthouse', () => {
assert.ok(data);
assert.ok(data.summary);
- assert.equal(data.summary.mode, 'navigation');
- assert.equal(data.summary.device, 'desktop');
+ assert.strictEqual(data.summary.mode, 'navigation');
+ assert.strictEqual(data.summary.device, 'desktop');
assert.ok(data.reports.length === 2); // json, html
- assert.equal(data.failedAudits.length, data.summary.audits.failed);
+ assert.strictEqual(
+ data.failedAudits.length,
+ data.summary.audits.failed,
+ );
// Verify files exist
for (const reportPath of data.reports) {
@@ -230,7 +233,7 @@ describe('lighthouse', () => {
);
const [flags] = page.lighthouseNavigation.firstCall.args;
- assert.equal(flags?.formFactor, 'desktop');
+ assert.strictEqual(flags?.formFactor, 'desktop');
assert.match(String(flags?.emulatedUserAgent), /Macintosh/);
assert.doesNotMatch(String(flags?.emulatedUserAgent), /Mobile/);
});
@@ -253,7 +256,7 @@ describe('lighthouse', () => {
);
const [flags] = page.lighthouseSnapshot.firstCall.args;
- assert.equal(flags?.formFactor, 'mobile');
+ assert.strictEqual(flags?.formFactor, 'mobile');
assert.match(String(flags?.emulatedUserAgent), /Mobile Safari/);
});
@@ -280,7 +283,7 @@ describe('lighthouse', () => {
);
sinon.assert.calledOnce(response.attachLighthouseResult);
- assert.equal(
+ assert.strictEqual(
response.attachLighthouseResult.firstCall.args[0].summary.url,
'https://example.com/page',
);
@@ -315,8 +318,8 @@ describe('lighthouse', () => {
sinon.assert.calledOnce(response.attachLighthouseResult);
const {summary, reports} =
response.attachLighthouseResult.firstCall.args[0];
- assert.equal(summary.mode, 'snapshot');
- assert.equal(summary.device, 'mobile');
+ assert.strictEqual(summary.mode, 'snapshot');
+ assert.strictEqual(summary.device, 'mobile');
assert.deepEqual(reports, ['/tmp/report.json', '/tmp/report.html']);
});
@@ -350,8 +353,8 @@ describe('lighthouse', () => {
sinon.assert.calledOnce(response.attachLighthouseResult);
const {summary, reports} =
response.attachLighthouseResult.firstCall.args[0];
- assert.equal(summary.mode, 'snapshot');
- assert.equal(summary.device, 'mobile');
+ assert.strictEqual(summary.mode, 'snapshot');
+ assert.strictEqual(summary.device, 'mobile');
assert.deepEqual(reports, [`${reportPath}.json`, `${reportPath}.html`]);
});
@@ -473,24 +476,24 @@ describe('lighthouse', () => {
const {summary, failedAudits} =
response.attachLighthouseResult.firstCall.args[0];
assert.deepEqual(summary.audits, {failed: 2, passed: 1});
- assert.equal(failedAudits.length, 2);
+ assert.strictEqual(failedAudits.length, 2);
const [contrast, title] = failedAudits;
- assert.equal(contrast.id, 'color-contrast');
+ assert.strictEqual(contrast.id, 'color-contrast');
assert.deepEqual(contrast.categories, ['accessibility']);
- assert.equal(
+ assert.strictEqual(
contrast.description,
'Low-contrast text is difficult to read.',
);
- assert.equal(contrast.totalNodes, 13);
- assert.equal(contrast.nodes.length, 10);
+ assert.strictEqual(contrast.totalNodes, 13);
+ assert.strictEqual(contrast.nodes.length, 10);
assert.deepEqual(contrast.nodes[0], {
selector: 'div.item-1',
snippet: '<div class="item-1">',
nodeLabel: 'Item 1',
explanation: 'Fix any of the following: contrast',
});
- assert.equal(contrast.nodes[1].selector, 'div.item-3');
+ assert.strictEqual(contrast.nodes[1].selector, 'div.item-3');
assert.ok(!contrast.nodes.some(n => n.selector === 'div.item-2'));
assert.ok(!contrast.nodes.some(n => n.selector === 'div.item-99'));
diff --git a/tests/tools/memory.test.ts b/tests/tools/memory.test.ts
index 0a8e191c..9ce9fabf 100644
--- a/tests/tools/memory.test.ts
+++ b/tests/tools/memory.test.ts
@@ -59,7 +59,7 @@ describe('memory', () => {
context,
);
const canonicalFilePath = await resolveCanonicalPath(filePath);
- assert.equal(
+ assert.strictEqual(
response.responseLines.at(0),
`Heap snapshot saved to ${canonicalFilePath}`,
);
diff --git a/tests/tools/pages.test.ts b/tests/tools/pages.test.ts
index 150242d8..80259d18 100644
--- a/tests/tools/pages.test.ts
+++ b/tests/tools/pages.test.ts
@@ -1002,7 +1002,7 @@ describe('pages', () => {
context,
);
const page = context.getSelectedMcpPage().pptrPage;
- assert.equal(
+ assert.strictEqual(
await page.evaluate(() => document.querySelector('div')?.textContent),
'Hello MCP',
);
@@ -1113,7 +1113,7 @@ describe('pages', () => {
context,
);
- assert.equal(
+ assert.strictEqual(
await page.evaluate(() => document.location.href),
'about:blank',
);
@@ -1131,7 +1131,7 @@ describe('pages', () => {
context,
);
- assert.equal(
+ assert.strictEqual(
await page.evaluate(() => document.querySelector('div')?.textContent),
'Hello MCP',
);
@@ -1148,7 +1148,7 @@ describe('pages', () => {
context,
);
- assert.equal(
+ assert.strictEqual(
await page.evaluate(() => document.location.href),
'data:text/html,<div>Hello MCP</div>',
);
diff --git a/tests/tools/screenshot.test.ts b/tests/tools/screenshot.test.ts
index ff9b4eee..58059d29 100644
--- a/tests/tools/screenshot.test.ts
+++ b/tests/tools/screenshot.test.ts
@@ -219,9 +219,9 @@ describe('screenshot', () => {
context,
);
- assert.equal(response.images.length, 1);
- assert.equal(response.images[0].mimeType, 'image/png');
- assert.equal(
+ assert.strictEqual(response.images.length, 1);
+ assert.strictEqual(response.images[0].mimeType, 'image/png');
+ assert.strictEqual(
response.responseLines.at(0),
"Took a screenshot of the current page's viewport.",
);
@@ -335,9 +335,9 @@ describe('screenshot', () => {
context,
);
- assert.equal(response.images.length, 1);
- assert.equal(response.images[0].mimeType, 'image/png');
- assert.equal(
+ assert.strictEqual(response.images.length, 1);
+ assert.strictEqual(response.images[0].mimeType, 'image/png');
+ assert.strictEqual(
response.responseLines.at(0),
'Took a screenshot of the full current page.',
);
@@ -370,8 +370,8 @@ describe('screenshot', () => {
context,
);
- assert.equal(response.images.length, 0);
- assert.equal(
+ assert.strictEqual(response.images.length, 0);
+ assert.strictEqual(
response.responseLines.at(0),
'Took a screenshot of the full current page.',
);
@@ -402,9 +402,9 @@ describe('screenshot', () => {
context,
);
- assert.equal(response.images.length, 1);
- assert.equal(response.images[0].mimeType, 'image/png');
- assert.equal(
+ assert.strictEqual(response.images.length, 1);
+ assert.strictEqual(response.images[0].mimeType, 'image/png');
+ assert.strictEqual(
response.responseLines.at(0),
'Took a screenshot of node with uid "1_1".',
);
@@ -469,13 +469,13 @@ describe('screenshot', () => {
context,
);
- assert.equal(response.images.length, 0);
- assert.equal(
+ assert.strictEqual(response.images.length, 0);
+ assert.strictEqual(
response.responseLines.at(0),
"Took a screenshot of the current page's viewport.",
);
const canonicalFilePath = await resolveCanonicalPath(filePath);
- assert.equal(
+ assert.strictEqual(
response.responseLines.at(1),
`Saved screenshot to ${canonicalFilePath}.`,
);
@@ -562,14 +562,14 @@ describe('screenshot', () => {
context,
);
- assert.equal(response.images.length, 1);
- assert.equal(response.images[0].mimeType, 'image/jpeg');
+ assert.strictEqual(response.images.length, 1);
+ assert.strictEqual(response.images[0].mimeType, 'image/jpeg');
});
});
it('keeps "png" as default format when no CLI override is set', async () => {
const tool = screenshot({} as ParsedArguments);
- assert.equal(zod.object(tool.schema).parse({}).format, 'png');
+ assert.strictEqual(zod.object(tool.schema).parse({}).format, 'png');
});
it('downscales viewport screenshot when screenshotMaxWidth is set', async () => {
@@ -589,11 +589,11 @@ describe('screenshot', () => {
context,
);
- assert.equal(response.images.length, 1);
+ assert.strictEqual(response.images.length, 1);
const buf = Buffer.from(response.images[0].data, 'base64');
- assert.equal(pngWidth(buf), 100);
+ assert.strictEqual(pngWidth(buf), 100);
// Aspect ratio preserved: 800x600 -> 100x75.
- assert.equal(pngHeight(buf), 75);
+ assert.strictEqual(pngHeight(buf), 75);
});
});
@@ -604,7 +604,7 @@ describe('screenshot', () => {
await withMcpContext(
async (response, context) => {
const page = context.getSelectedMcpPage().pptrPage;
- assert.equal(page.viewport(), null);
+ assert.strictEqual(page.viewport(), null);
await page.setContent(
html`<div style="width:100vw;height:100vh;background:red"></div>`,
);
@@ -613,7 +613,7 @@ describe('screenshot', () => {
height: window.innerHeight,
devicePixelRatio: window.devicePixelRatio,
}));
- assert.equal(source.devicePixelRatio, 2);
+ assert.strictEqual(source.devicePixelRatio, 2);
await tool.handler(
{params: {format: 'png'}, page: context.getSelectedMcpPage()},
@@ -621,9 +621,9 @@ describe('screenshot', () => {
context,
);
- assert.equal(response.images.length, 1);
+ assert.strictEqual(response.images.length, 1);
const buf = Buffer.from(response.images[0].data, 'base64');
- assert.equal(pngWidth(buf), 100);
+ assert.strictEqual(pngWidth(buf), 100);
const expectedHeight = Math.round(
source.height * (100 / source.width),
);
@@ -645,7 +645,7 @@ describe('screenshot', () => {
// No setViewport call here: the browser is launched and connected with
// `defaultViewport: null`, so this is what a page looks like unless the
// emulate tool has set a viewport.
- assert.equal(page.viewport(), null);
+ assert.strictEqual(page.viewport(), null);
await page.setContent(
html`<div style="width:100vw;height:100vh;background:red"></div>`,
);
@@ -660,9 +660,9 @@ describe('screenshot', () => {
context,
);
- assert.equal(response.images.length, 1);
+ assert.strictEqual(response.images.length, 1);
const buf = Buffer.from(response.images[0].data, 'base64');
- assert.equal(pngWidth(buf), 100);
+ assert.strictEqual(pngWidth(buf), 100);
// The window size comes from the environment rather than an emulated
// viewport, so allow a pixel of rounding slack on the derived height.
const expectedHeight = Math.round(source.height * (100 / source.width));
@@ -693,8 +693,8 @@ describe('screenshot', () => {
const buf = Buffer.from(response.images[0].data, 'base64');
// height bound dictates: 60/600 = 0.1 -> 80x60.
- assert.equal(pngHeight(buf), 60);
- assert.equal(pngWidth(buf), 80);
+ assert.strictEqual(pngHeight(buf), 60);
+ assert.strictEqual(pngWidth(buf), 80);
});
});
@@ -715,8 +715,8 @@ describe('screenshot', () => {
);
const buf = Buffer.from(response.images[0].data, 'base64');
- assert.equal(pngWidth(buf), 800);
- assert.equal(pngHeight(buf), 600);
+ assert.strictEqual(pngWidth(buf), 800);
+ assert.strictEqual(pngHeight(buf), 600);
});
});
@@ -747,7 +747,7 @@ describe('screenshot', () => {
const buf = Buffer.from(response.images[0].data, 'base64');
// Source is at least 1000x1500; scale = 200/1000 = 0.2 -> ~200x300.
// Allow ±2px to absorb sub-pixel rasterization rounding by Chrome.
- assert.equal(pngWidth(buf), 200);
+ assert.strictEqual(pngWidth(buf), 200);
assert.ok(
Math.abs(pngHeight(buf) - 300) <= 2,
`expected height near 300, got ${pngHeight(buf)}`,
diff --git a/tests/tools/slim/tools.test.ts b/tests/tools/slim/tools.test.ts
index b71891f4..8ba098d6 100644
--- a/tests/tools/slim/tools.test.ts
+++ b/tests/tools/slim/tools.test.ts
@@ -53,7 +53,7 @@ describe('slim', () => {
context,
);
const page = context.getSelectedMcpPage().pptrPage;
- assert.equal(
+ assert.strictEqual(
await page.evaluate(() => document.querySelector('div')?.textContent),
'Hello MCP',
);