Skip to content

Chrome DevTools for coding agents

fix(daemon): preserve hyphenated browser flags in arg serialization and lazy daemon startup (#2405)

gvojtad79f3ba24f3c
diff --git a/src/bin/chrome-devtools.ts b/src/bin/chrome-devtools.ts
index 30677ede..99bbc0d0 100644
--- a/src/bin/chrome-devtools.ts
+++ b/src/bin/chrome-devtools.ts
@@ -263,7 +263,7 @@ for (const [commandName, commandDef] of Object.entries(commands)) {
const sessionId = argv.sessionId as string;
try {
if (!isDaemonRunning(sessionId)) {
- await start([], sessionId);
+ await start(serializeArgs(cliOptions, argv), sessionId);
}
const commandArgs: Record<string, unknown> = {};
diff --git a/src/daemon/utils.ts b/src/daemon/utils.ts
index 8bf7bb66..8114071b 100644
--- a/src/daemon/utils.ts
+++ b/src/daemon/utils.ts
@@ -128,10 +128,10 @@ export function serializeArgs(
}
} else if (Array.isArray(value)) {
for (const item of value) {
- args.push(`--${kebabKey}`, String(item));
+ args.push(`--${kebabKey}=${String(item)}`);
}
} else {
- args.push(`--${kebabKey}`, String(value));
+ args.push(`--${kebabKey}=${String(value)}`);
}
}
return args;
diff --git a/tests/daemon/utils.test.ts b/tests/daemon/utils.test.ts
index 4be3baa2..c0fb045c 100644
--- a/tests/daemon/utils.test.ts
+++ b/tests/daemon/utils.test.ts
@@ -26,7 +26,7 @@ describe('serializeArgs', () => {
$0: 'test',
} as unknown as ParsedArguments;
const result = serializeArgs(options, argv);
- assert.deepStrictEqual(result, ['--baz', 'value']);
+ assert.deepStrictEqual(result, ['--baz=value']);
});
it('should handle boolean values', () => {
@@ -41,15 +41,24 @@ describe('serializeArgs', () => {
assert.deepStrictEqual(result, ['--foo', '--no-bar']);
});
- it('should handle array values', () => {
- const options: Record<string, YargsOptions> = {foo: {}};
+ it('should handle array values including hyphenated flags', () => {
+ const options: Record<string, YargsOptions> = {foo: {}, chromeArg: {}};
const argv = {
foo: ['val1', 'val2'],
+ chromeArg: [
+ '--use-fake-device-for-media-stream',
+ '--use-file-for-fake-audio-capture=/tmp/test.wav',
+ ],
_: [],
$0: 'test',
} as unknown as ParsedArguments;
const result = serializeArgs(options, argv);
- assert.deepStrictEqual(result, ['--foo', 'val1', '--foo', 'val2']);
+ assert.deepStrictEqual(result, [
+ '--foo=val1',
+ '--foo=val2',
+ '--chrome-arg=--use-fake-device-for-media-stream',
+ '--chrome-arg=--use-file-for-fake-audio-capture=/tmp/test.wav',
+ ]);
});
it('should handle primitive values', () => {
@@ -61,7 +70,7 @@ describe('serializeArgs', () => {
$0: 'test',
} as unknown as ParsedArguments;
const result = serializeArgs(options, argv);
- assert.deepStrictEqual(result, ['--foo', 'string', '--bar', '42']);
+ assert.deepStrictEqual(result, ['--foo=string', '--bar=42']);
});
it('should convert camelCase keys to kebab-case', () => {
@@ -77,8 +86,7 @@ describe('serializeArgs', () => {
} as unknown as ParsedArguments;
const result = serializeArgs(options, argv);
assert.deepStrictEqual(result, [
- '--camel-case-key',
- 'value1',
+ '--camel-case-key=value1',
'--another-key',
]);
});