Chrome DevTools for coding agents
test: refactor CLI tests (#2575)
Nikolay Vitkovec014d178f57
diff --git a/src/bin/chrome-devtools-mcp-cli-options.ts b/src/bin/chrome-devtools-mcp-cli-options.tsindex 015b61bf..d972b1f2 100644--- a/src/bin/chrome-devtools-mcp-cli-options.ts+++ b/src/bin/chrome-devtools-mcp-cli-options.ts@@ -376,7 +376,10 @@ export const cliOptions = {export type ParsedArguments = ReturnType<typeof parseArguments>;-export function parseArguments(+/**+ * Exported only for testing to not trigger process exit.+ */+export function parser(version: string,argv = process.argv,env = process.env,@@ -482,6 +485,13 @@ export function parseArguments(return yargsInstance.wrap(Math.min(120, yargsInstance.terminalWidth())).help()- .version(version)- .parseSync();+ .version(version);+}++export function parseArguments(+ version: string,+ argv = process.argv,+ env = process.env,+) {+ return parser(version, argv, env).parseSync();}diff --git a/tests/cli.test.ts b/tests/cli.test.tsindex 3b1ed5e7..60749b6f 100644--- a/tests/cli.test.ts+++ b/tests/cli.test.ts@@ -5,10 +5,15 @@*/import assert from 'node:assert';-import {spawnSync} from 'node:child_process';import {describe, it} from 'node:test';-import {parseArguments} from '../src/bin/chrome-devtools-mcp-cli-options.js';+import {parser} from '../src/bin/chrome-devtools-mcp-cli-options.js';++function parseArguments(argv: string[], env: NodeJS.ProcessEnv = {}) {+ return parser('0.0.0', ['node', 'main.js', ...argv], env)+ .exitProcess(false)+ .parseSync();+}describe('cli args parsing', () => {const defaultArgs = {@@ -35,7 +40,7 @@ describe('cli args parsing', () => {};it('parses with default args', async () => {- const args = parseArguments('1.0.0', ['node', 'main.js'], {});+ const args = parseArguments([]);assert.deepStrictEqual(args, {...defaultArgs,_: [],@@ -46,11 +51,7 @@ describe('cli args parsing', () => {});it('parses with browser url', async () => {- const args = parseArguments(- '1.0.0',- ['node', 'main.js', '--browserUrl', 'http://localhost:3000'],- {},- );+ const args = parseArguments(['--browserUrl', 'http://localhost:3000']);assert.deepStrictEqual(args, {...defaultArgs,_: [],@@ -63,40 +64,20 @@ describe('cli args parsing', () => {});it('rejects unknown options', async () => {- const moduleUrl = new URL(- '../src/bin/chrome-devtools-mcp-cli-options.js',- import.meta.url,- );- const result = spawnSync(- process.execPath,- [- '--input-type=module',- '--eval',- `import {parseArguments} from ${JSON.stringify(moduleUrl.href)}; parseArguments('1.0.0', ['node', 'main.js', '--browserURL', 'http://localhost:3000'], {});`,- ],- {encoding: 'utf8'},+ assert.throws(+ () => parseArguments(['--browserURL', 'http://localhost:3000']),+ /Unknown argument: browserURL/,);-- assert.strictEqual(result.status, 1);- assert.match(result.stderr, /Unknown argument: browserURL/);});it('parses mixed-form option names', async () => {- const args = parseArguments(- '1.0.0',- ['node', 'main.js', '--category-experimentalWebmcp'],- {},- );+ const args = parseArguments(['--category-experimentalWebmcp']);assert.strictEqual(args.categoryExperimentalWebmcp, true);});it('parses with user data dir', async () => {- const args = parseArguments(- '1.0.0',- ['node', 'main.js', '--user-data-dir', '/tmp/chrome-profile'],- {},- );+ const args = parseArguments(['--user-data-dir', '/tmp/chrome-profile']);assert.deepStrictEqual(args, {...defaultArgs,_: [],@@ -109,11 +90,7 @@ describe('cli args parsing', () => {});it('parses an empty browser url', async () => {- const args = parseArguments(- '1.0.0',- ['node', 'main.js', '--browserUrl', ''],- {},- );+ const args = parseArguments(['--browserUrl', ''], {});assert.deepStrictEqual(args, {...defaultArgs,_: [],@@ -127,11 +104,7 @@ describe('cli args parsing', () => {});it('parses with executable path', async () => {- const args = parseArguments(- '1.0.0',- ['node', 'main.js', '--executablePath', '/tmp/test 123/chrome'],- {},- );+ const args = parseArguments(['--executablePath', '/tmp/test 123/chrome']);assert.deepStrictEqual(args, {...defaultArgs,_: [],@@ -144,11 +117,7 @@ describe('cli args parsing', () => {});it('parses viewport', async () => {- const args = parseArguments(- '1.0.0',- ['node', 'main.js', '--viewport', '888x777'],- {},- );+ const args = parseArguments(['--viewport', '888x777']);assert.deepStrictEqual(args, {...defaultArgs,_: [],@@ -163,16 +132,10 @@ describe('cli args parsing', () => {});it('parses chrome args', async () => {- const args = parseArguments(- '1.0.0',- [- 'node',- 'main.js',- `--chrome-arg='--no-sandbox'`,- `--chrome-arg='--disable-setuid-sandbox'`,- ],- {},- );+ const args = parseArguments([+ `--chrome-arg='--no-sandbox'`,+ `--chrome-arg='--disable-setuid-sandbox'`,+ ]);assert.deepStrictEqual(args, {...defaultArgs,_: [],@@ -185,16 +148,10 @@ describe('cli args parsing', () => {});it('parses ignore chrome args', async () => {- const args = parseArguments(- '1.0.0',- [- 'node',- 'main.js',- `--ignore-default-chrome-arg='--disable-extensions'`,- `--ignore-default-chrome-arg='--disable-cancel-all-touches'`,- ],- {},- );+ const args = parseArguments([+ `--ignore-default-chrome-arg='--disable-extensions'`,+ `--ignore-default-chrome-arg='--disable-cancel-all-touches'`,+ ]);assert.deepStrictEqual(args, {...defaultArgs,_: [],@@ -213,16 +170,10 @@ describe('cli args parsing', () => {});it('parses wsEndpoint with ws:// protocol', async () => {- const args = parseArguments(- '1.0.0',- [- 'node',- 'main.js',- '--wsEndpoint',- 'ws://127.0.0.1:9222/devtools/browser/abc123',- ],- {},- );+ const args = parseArguments([+ '--wsEndpoint',+ 'ws://127.0.0.1:9222/devtools/browser/abc123',+ ]);assert.deepStrictEqual(args, {...defaultArgs,_: [],@@ -235,16 +186,10 @@ describe('cli args parsing', () => {});it('parses wsEndpoint with wss:// protocol', async () => {- const args = parseArguments(- '1.0.0',- [- 'node',- 'main.js',- '--wsEndpoint',- 'wss://example.com:9222/devtools/browser/abc123',- ],- {},- );+ const args = parseArguments([+ '--wsEndpoint',+ 'wss://example.com:9222/devtools/browser/abc123',+ ]);assert.deepStrictEqual(args, {...defaultArgs,_: [],@@ -257,18 +202,12 @@ describe('cli args parsing', () => {});it('parses wsHeaders with valid JSON', async () => {- const args = parseArguments(- '1.0.0',- [- 'node',- 'main.js',- '--wsEndpoint',- 'ws://127.0.0.1:9222/devtools/browser/abc123',- '--wsHeaders',- '{"Authorization":"Bearer token","X-Custom":"value"}',- ],- {},- );+ const args = parseArguments([+ '--wsEndpoint',+ 'ws://127.0.0.1:9222/devtools/browser/abc123',+ '--wsHeaders',+ '{"Authorization":"Bearer token","X-Custom":"value"}',+ ]);assert.deepStrictEqual(args.wsHeaders, {Authorization: 'Bearer token','X-Custom': 'value',@@ -276,11 +215,7 @@ describe('cli args parsing', () => {});it('parses disabled category', async () => {- const args = parseArguments(- '1.0.0',- ['node', 'main.js', '--no-category-emulation'],- {},- );+ const args = parseArguments(['--no-category-emulation']);assert.deepStrictEqual(args, {...defaultArgs,_: [],@@ -292,11 +227,7 @@ describe('cli args parsing', () => {});});it('parses auto-connect', async () => {- const args = parseArguments(- '1.0.0',- ['node', 'main.js', '--auto-connect'],- {},- );+ const args = parseArguments(['--auto-connect'], {});assert.deepStrictEqual(args, {...defaultArgs,_: [],@@ -310,113 +241,75 @@ describe('cli args parsing', () => {it('parses usage statistics flag', async () => {// Test default (should be true).- const defaultArgs = parseArguments('1.0.0', ['node', 'main.js'], {});+ const defaultArgs = parseArguments(['main.js'], {});assert.strictEqual(defaultArgs.usageStatistics, true);// Test enabling it- const enabledArgs = parseArguments(- '1.0.0',- ['node', 'main.js', '--usage-statistics'],- {},- );+ const enabledArgs = parseArguments(['--usage-statistics']);assert.strictEqual(enabledArgs.usageStatistics, true);// Test disabling it- const disabledArgs = parseArguments(- '1.0.0',- ['node', 'main.js', '--no-usage-statistics'],- {},- );+ const disabledArgs = parseArguments(['--no-usage-statistics']);assert.strictEqual(disabledArgs.usageStatistics, false);});it('respects env variable', async () => {// Test default (should be true).- const defaultArgs = parseArguments('1.0.0', ['node', 'main.js'], {+ const defaultArgs = parseArguments(['main.js'], {CHROME_DEVTOOLS_MCP_NO_USAGE_STATISTICS: 'true',});assert.strictEqual(defaultArgs.usageStatistics, false);// Test enabling it- const enabledArgs = parseArguments(- '1.0.0',- ['node', 'main.js', '--usage-statistics'],- {- CHROME_DEVTOOLS_MCP_NO_USAGE_STATISTICS: 'true',- },- );+ const enabledArgs = parseArguments(['--usage-statistics'], {+ CHROME_DEVTOOLS_MCP_NO_USAGE_STATISTICS: 'true',+ });assert.strictEqual(enabledArgs.usageStatistics, false);// Test disabling it- const disabledArgs = parseArguments(- '1.0.0',- ['node', 'main.js', '--no-usage-statistics'],- {- CHROME_DEVTOOLS_MCP_NO_USAGE_STATISTICS: 'true',- },- );+ const disabledArgs = parseArguments(['--no-usage-statistics'], {+ CHROME_DEVTOOLS_MCP_NO_USAGE_STATISTICS: 'true',+ });assert.strictEqual(disabledArgs.usageStatistics, false);});it('parses performance crux flag', async () => {- const defaultArgs = parseArguments('1.0.0', ['node', 'main.js']);+ const defaultArgs = parseArguments(['main.js']);assert.strictEqual(defaultArgs.performanceCrux, true);// force enable- const enabledArgs = parseArguments(- '1.0.0',- ['node', 'main.js', '--performance-crux'],- {},- );+ const enabledArgs = parseArguments(['--performance-crux']);assert.strictEqual(enabledArgs.performanceCrux, true);- const disabledArgs = parseArguments(- '1.0.0',- ['node', 'main.js', '--no-performance-crux'],- {},- );+ const disabledArgs = parseArguments(['--no-performance-crux']);assert.strictEqual(disabledArgs.performanceCrux, false);});it('parses blocked-url-pattern flags as array', async () => {- const defaultArgs = parseArguments('1.0.0', ['node', 'main.js']);+ const defaultArgs = parseArguments(['main.js']);assert.strictEqual(defaultArgs.blockedUrlPattern, undefined);- const singleArgs = parseArguments(- '1.0.0',- ['node', 'main.js', '--blocked-url-pattern=https://example.com/*'],- {},- );+ const singleArgs = parseArguments([+ '--blocked-url-pattern=https://example.com/*',+ ]);assert.deepStrictEqual(singleArgs.blockedUrlPattern, ['https://example.com/*',]);- const repeatedArgs = parseArguments(- '1.0.0',- [- 'node',- 'main.js',- '--blocked-url-pattern=https://a.com/*',- '--blocked-url-pattern=https://b.com/*',- ],- {},- );+ const repeatedArgs = parseArguments([+ '--blocked-url-pattern=https://a.com/*',+ '--blocked-url-pattern=https://b.com/*',+ ]);assert.deepStrictEqual(repeatedArgs.blockedUrlPattern, ['https://a.com/*','https://b.com/*',]);- const spaceSeparatedArgs = parseArguments(- '1.0.0',- [- 'node',- 'main.js',- '--blocked-url-pattern',- 'https://a.com/*',- 'https://b.com/*',- ],- {},- );+ const spaceSeparatedArgs = parseArguments([+ '--blocked-url-pattern',+ 'https://a.com/*',+ 'https://b.com/*',+ ]);assert.deepStrictEqual(spaceSeparatedArgs.blockedUrlPattern, ['https://a.com/*','https://b.com/*',@@ -424,44 +317,30 @@ describe('cli args parsing', () => {});it('parses allowed-url-pattern flags as array', async () => {- const defaultArgs = parseArguments('1.0.0', ['node', 'main.js']);+ const defaultArgs = parseArguments(['main.js']);assert.strictEqual(defaultArgs.allowedUrlPattern, undefined);- const singleArgs = parseArguments(- '1.0.0',- ['node', 'main.js', '--allowed-url-pattern=https://example.com/*'],- {},- );+ const singleArgs = parseArguments([+ '--allowed-url-pattern=https://example.com/*',+ ]);assert.deepStrictEqual(singleArgs.allowedUrlPattern, ['https://example.com/*',]);- const repeatedArgs = parseArguments(- '1.0.0',- [- 'node',- 'main.js',- '--allowed-url-pattern=https://a.com/*',- '--allowed-url-pattern=https://b.com/*',- ],- {},- );+ const repeatedArgs = parseArguments([+ '--allowed-url-pattern=https://a.com/*',+ '--allowed-url-pattern=https://b.com/*',+ ]);assert.deepStrictEqual(repeatedArgs.allowedUrlPattern, ['https://a.com/*','https://b.com/*',]);- const spaceSeparatedArgs = parseArguments(- '1.0.0',- [- 'node',- 'main.js',- '--allowed-url-pattern',- 'https://a.com/*',- 'https://b.com/*',- ],- {},- );+ const spaceSeparatedArgs = parseArguments([+ '--allowed-url-pattern',+ 'https://a.com/*',+ 'https://b.com/*',+ ]);assert.deepStrictEqual(spaceSeparatedArgs.allowedUrlPattern, ['https://a.com/*','https://b.com/*',